* [PATCH 0/6] gpio: simplify getting .driver_data
@ 2018-10-21 19:59 Wolfram Sang
2018-10-21 19:59 ` [PATCH 1/6] gpio: gpio-dwapb: " Wolfram Sang
` (5 more replies)
0 siblings, 6 replies; 15+ messages in thread
From: Wolfram Sang @ 2018-10-21 19:59 UTC (permalink / raw)
To: linux-kernel
Cc: linux-renesas-soc, Wolfram Sang, linux-arm-kernel, linux-gpio,
linux-omap, linux-tegra
I got tired of fixing this in Renesas drivers manually, so I took the big
hammer. Remove this cumbersome code pattern which got copy-pasted too much
already:
- struct platform_device *pdev = to_platform_device(dev);
- struct ep93xx_keypad *keypad = platform_get_drvdata(pdev);
+ struct ep93xx_keypad *keypad = dev_get_drvdata(dev);
A branch, tested by buildbot, can be found here:
git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git coccinelle/get_drvdata
I have been asked if it couldn't be done for dev_set_drvdata as well. I checked
it and did not find one occasion where it could be simplified like this. Not
much of a surprise because driver_data is usually set in probe() functions
which access struct platform_device in many other ways.
I am open for other comments, suggestions, too, of course.
Here is the cocci-script I created:
@@
struct device* d;
identifier pdev;
expression *ptr;
@@
(
- struct platform_device *pdev = to_platform_device(d);
|
- struct platform_device *pdev;
...
- pdev = to_platform_device(d);
)
<... when != pdev
- &pdev->dev
+ d
...>
ptr =
- platform_get_drvdata(pdev)
+ dev_get_drvdata(d)
<... when != pdev
- &pdev->dev
+ d
...>
Kind regards,
Wolfram
Wolfram Sang (6):
gpio: gpio-dwapb: simplify getting .driver_data
gpio: gpio-lynxpoint: simplify getting .driver_data
gpio: gpio-mxc: simplify getting .driver_data
gpio: gpio-omap: simplify getting .driver_data
gpio: gpio-tegra: simplify getting .driver_data
gpio: gpio-zynq: simplify getting .driver_data
drivers/gpio/gpio-dwapb.c | 6 ++----
drivers/gpio/gpio-lynxpoint.c | 3 +--
drivers/gpio/gpio-mxc.c | 6 ++----
drivers/gpio/gpio-omap.c | 12 ++++--------
drivers/gpio/gpio-tegra.c | 6 ++----
drivers/gpio/gpio-zynq.c | 6 ++----
6 files changed, 13 insertions(+), 26 deletions(-)
--
2.19.0
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 1/6] gpio: gpio-dwapb: simplify getting .driver_data
2018-10-21 19:59 [PATCH 0/6] gpio: simplify getting .driver_data Wolfram Sang
@ 2018-10-21 19:59 ` Wolfram Sang
2018-10-30 13:12 ` Linus Walleij
2018-10-21 19:59 ` [PATCH 2/6] gpio: gpio-lynxpoint: " Wolfram Sang
` (4 subsequent siblings)
5 siblings, 1 reply; 15+ messages in thread
From: Wolfram Sang @ 2018-10-21 19:59 UTC (permalink / raw)
To: linux-kernel
Cc: linux-renesas-soc, Wolfram Sang, Hoan Tran, Linus Walleij, linux-gpio
We should get 'driver_data' from 'struct device' directly. Going via
platform_device is an unneeded step back and forth.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
Build tested only. buildbot is happy.
drivers/gpio/gpio-dwapb.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpio/gpio-dwapb.c b/drivers/gpio/gpio-dwapb.c
index 044888fd96a1..84ae04402f70 100644
--- a/drivers/gpio/gpio-dwapb.c
+++ b/drivers/gpio/gpio-dwapb.c
@@ -748,8 +748,7 @@ static int dwapb_gpio_remove(struct platform_device *pdev)
#ifdef CONFIG_PM_SLEEP
static int dwapb_gpio_suspend(struct device *dev)
{
- struct platform_device *pdev = to_platform_device(dev);
- struct dwapb_gpio *gpio = platform_get_drvdata(pdev);
+ struct dwapb_gpio *gpio = dev_get_drvdata(dev);
struct gpio_chip *gc = &gpio->ports[0].gc;
unsigned long flags;
int i;
@@ -793,8 +792,7 @@ static int dwapb_gpio_suspend(struct device *dev)
static int dwapb_gpio_resume(struct device *dev)
{
- struct platform_device *pdev = to_platform_device(dev);
- struct dwapb_gpio *gpio = platform_get_drvdata(pdev);
+ struct dwapb_gpio *gpio = dev_get_drvdata(dev);
struct gpio_chip *gc = &gpio->ports[0].gc;
unsigned long flags;
int i;
--
2.19.0
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH 2/6] gpio: gpio-lynxpoint: simplify getting .driver_data
2018-10-21 19:59 [PATCH 0/6] gpio: simplify getting .driver_data Wolfram Sang
2018-10-21 19:59 ` [PATCH 1/6] gpio: gpio-dwapb: " Wolfram Sang
@ 2018-10-21 19:59 ` Wolfram Sang
2018-10-30 13:14 ` Linus Walleij
2018-10-21 19:59 ` [PATCH 3/6] gpio: gpio-mxc: " Wolfram Sang
` (3 subsequent siblings)
5 siblings, 1 reply; 15+ messages in thread
From: Wolfram Sang @ 2018-10-21 19:59 UTC (permalink / raw)
To: linux-kernel; +Cc: linux-renesas-soc, Wolfram Sang, Linus Walleij, linux-gpio
We should get 'driver_data' from 'struct device' directly. Going via
platform_device is an unneeded step back and forth.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
Build tested only. buildbot is happy.
drivers/gpio/gpio-lynxpoint.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpio/gpio-lynxpoint.c b/drivers/gpio/gpio-lynxpoint.c
index b5b5e500e72c..ca12d9f96914 100644
--- a/drivers/gpio/gpio-lynxpoint.c
+++ b/drivers/gpio/gpio-lynxpoint.c
@@ -408,8 +408,7 @@ static int lp_gpio_runtime_resume(struct device *dev)
static int lp_gpio_resume(struct device *dev)
{
- struct platform_device *pdev = to_platform_device(dev);
- struct lp_gpio *lg = platform_get_drvdata(pdev);
+ struct lp_gpio *lg = dev_get_drvdata(dev);
unsigned long reg;
int i;
--
2.19.0
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH 3/6] gpio: gpio-mxc: simplify getting .driver_data
2018-10-21 19:59 [PATCH 0/6] gpio: simplify getting .driver_data Wolfram Sang
2018-10-21 19:59 ` [PATCH 1/6] gpio: gpio-dwapb: " Wolfram Sang
2018-10-21 19:59 ` [PATCH 2/6] gpio: gpio-lynxpoint: " Wolfram Sang
@ 2018-10-21 19:59 ` Wolfram Sang
2018-10-30 13:15 ` Linus Walleij
2018-10-21 19:59 ` [PATCH 4/6] gpio: gpio-omap: " Wolfram Sang
` (2 subsequent siblings)
5 siblings, 1 reply; 15+ messages in thread
From: Wolfram Sang @ 2018-10-21 19:59 UTC (permalink / raw)
To: linux-kernel; +Cc: linux-renesas-soc, Wolfram Sang, Linus Walleij, linux-gpio
We should get 'driver_data' from 'struct device' directly. Going via
platform_device is an unneeded step back and forth.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
Build tested only. buildbot is happy.
drivers/gpio/gpio-mxc.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpio/gpio-mxc.c b/drivers/gpio/gpio-mxc.c
index 995cf0b9e0b1..5c69516e90b1 100644
--- a/drivers/gpio/gpio-mxc.c
+++ b/drivers/gpio/gpio-mxc.c
@@ -552,8 +552,7 @@ static void mxc_gpio_restore_regs(struct mxc_gpio_port *port)
static int __maybe_unused mxc_gpio_noirq_suspend(struct device *dev)
{
- struct platform_device *pdev = to_platform_device(dev);
- struct mxc_gpio_port *port = platform_get_drvdata(pdev);
+ struct mxc_gpio_port *port = dev_get_drvdata(dev);
mxc_gpio_save_regs(port);
clk_disable_unprepare(port->clk);
@@ -563,8 +562,7 @@ static int __maybe_unused mxc_gpio_noirq_suspend(struct device *dev)
static int __maybe_unused mxc_gpio_noirq_resume(struct device *dev)
{
- struct platform_device *pdev = to_platform_device(dev);
- struct mxc_gpio_port *port = platform_get_drvdata(pdev);
+ struct mxc_gpio_port *port = dev_get_drvdata(dev);
int ret;
ret = clk_prepare_enable(port->clk);
--
2.19.0
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH 4/6] gpio: gpio-omap: simplify getting .driver_data
2018-10-21 19:59 [PATCH 0/6] gpio: simplify getting .driver_data Wolfram Sang
` (2 preceding siblings ...)
2018-10-21 19:59 ` [PATCH 3/6] gpio: gpio-mxc: " Wolfram Sang
@ 2018-10-21 19:59 ` Wolfram Sang
2018-10-22 18:30 ` Grygorii Strashko
2018-10-30 13:18 ` Linus Walleij
2018-10-21 20:00 ` [PATCH 5/6] gpio: gpio-tegra: " Wolfram Sang
2018-10-21 20:00 ` [PATCH 6/6] gpio: gpio-zynq: " Wolfram Sang
5 siblings, 2 replies; 15+ messages in thread
From: Wolfram Sang @ 2018-10-21 19:59 UTC (permalink / raw)
To: linux-kernel
Cc: linux-renesas-soc, Wolfram Sang, Grygorii Strashko,
Santosh Shilimkar, Kevin Hilman, Linus Walleij, linux-omap,
linux-gpio
We should get 'driver_data' from 'struct device' directly. Going via
platform_device is an unneeded step back and forth.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
Build tested only. buildbot is happy.
drivers/gpio/gpio-omap.c | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c
index 9887c3db6e16..6ed621a00561 100644
--- a/drivers/gpio/gpio-omap.c
+++ b/drivers/gpio/gpio-omap.c
@@ -984,8 +984,7 @@ omap4_gpio_disable_level_quirk(struct gpio_bank *bank)
static int omap_mpuio_suspend_noirq(struct device *dev)
{
- struct platform_device *pdev = to_platform_device(dev);
- struct gpio_bank *bank = platform_get_drvdata(pdev);
+ struct gpio_bank *bank = dev_get_drvdata(dev);
void __iomem *mask_reg = bank->base +
OMAP_MPUIO_GPIO_MASKIT / bank->stride;
unsigned long flags;
@@ -999,8 +998,7 @@ static int omap_mpuio_suspend_noirq(struct device *dev)
static int omap_mpuio_resume_noirq(struct device *dev)
{
- struct platform_device *pdev = to_platform_device(dev);
- struct gpio_bank *bank = platform_get_drvdata(pdev);
+ struct gpio_bank *bank = dev_get_drvdata(dev);
void __iomem *mask_reg = bank->base +
OMAP_MPUIO_GPIO_MASKIT / bank->stride;
unsigned long flags;
@@ -1688,8 +1686,7 @@ static void omap_gpio_restore_context(struct gpio_bank *bank)
static int __maybe_unused omap_gpio_runtime_suspend(struct device *dev)
{
- struct platform_device *pdev = to_platform_device(dev);
- struct gpio_bank *bank = platform_get_drvdata(pdev);
+ struct gpio_bank *bank = dev_get_drvdata(dev);
unsigned long flags;
int error = 0;
@@ -1709,8 +1706,7 @@ static int __maybe_unused omap_gpio_runtime_suspend(struct device *dev)
static int __maybe_unused omap_gpio_runtime_resume(struct device *dev)
{
- struct platform_device *pdev = to_platform_device(dev);
- struct gpio_bank *bank = platform_get_drvdata(pdev);
+ struct gpio_bank *bank = dev_get_drvdata(dev);
unsigned long flags;
int error = 0;
--
2.19.0
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH 5/6] gpio: gpio-tegra: simplify getting .driver_data
2018-10-21 19:59 [PATCH 0/6] gpio: simplify getting .driver_data Wolfram Sang
` (3 preceding siblings ...)
2018-10-21 19:59 ` [PATCH 4/6] gpio: gpio-omap: " Wolfram Sang
@ 2018-10-21 20:00 ` Wolfram Sang
2018-10-22 8:01 ` Thierry Reding
2018-10-30 13:20 ` Linus Walleij
2018-10-21 20:00 ` [PATCH 6/6] gpio: gpio-zynq: " Wolfram Sang
5 siblings, 2 replies; 15+ messages in thread
From: Wolfram Sang @ 2018-10-21 20:00 UTC (permalink / raw)
To: linux-kernel
Cc: linux-renesas-soc, Wolfram Sang, Linus Walleij, Thierry Reding,
Jonathan Hunter, linux-gpio, linux-tegra
We should get 'driver_data' from 'struct device' directly. Going via
platform_device is an unneeded step back and forth.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
Build tested only. buildbot is happy.
drivers/gpio/gpio-tegra.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpio/gpio-tegra.c b/drivers/gpio/gpio-tegra.c
index 47dbd19751d0..02f6db925fd5 100644
--- a/drivers/gpio/gpio-tegra.c
+++ b/drivers/gpio/gpio-tegra.c
@@ -404,8 +404,7 @@ static void tegra_gpio_irq_handler(struct irq_desc *desc)
#ifdef CONFIG_PM_SLEEP
static int tegra_gpio_resume(struct device *dev)
{
- struct platform_device *pdev = to_platform_device(dev);
- struct tegra_gpio_info *tgi = platform_get_drvdata(pdev);
+ struct tegra_gpio_info *tgi = dev_get_drvdata(dev);
unsigned long flags;
unsigned int b, p;
@@ -444,8 +443,7 @@ static int tegra_gpio_resume(struct device *dev)
static int tegra_gpio_suspend(struct device *dev)
{
- struct platform_device *pdev = to_platform_device(dev);
- struct tegra_gpio_info *tgi = platform_get_drvdata(pdev);
+ struct tegra_gpio_info *tgi = dev_get_drvdata(dev);
unsigned long flags;
unsigned int b, p;
--
2.19.0
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH 6/6] gpio: gpio-zynq: simplify getting .driver_data
2018-10-21 19:59 [PATCH 0/6] gpio: simplify getting .driver_data Wolfram Sang
` (4 preceding siblings ...)
2018-10-21 20:00 ` [PATCH 5/6] gpio: gpio-tegra: " Wolfram Sang
@ 2018-10-21 20:00 ` Wolfram Sang
2018-10-30 13:19 ` Linus Walleij
5 siblings, 1 reply; 15+ messages in thread
From: Wolfram Sang @ 2018-10-21 20:00 UTC (permalink / raw)
To: linux-kernel
Cc: linux-renesas-soc, Wolfram Sang, Linus Walleij, Michal Simek,
linux-gpio, linux-arm-kernel
We should get 'driver_data' from 'struct device' directly. Going via
platform_device is an unneeded step back and forth.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
Build tested only. buildbot is happy.
drivers/gpio/gpio-zynq.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpio/gpio-zynq.c b/drivers/gpio/gpio-zynq.c
index 3f5fcdd5a429..ac9b02c9598f 100644
--- a/drivers/gpio/gpio-zynq.c
+++ b/drivers/gpio/gpio-zynq.c
@@ -693,8 +693,7 @@ static int __maybe_unused zynq_gpio_resume(struct device *dev)
static int __maybe_unused zynq_gpio_runtime_suspend(struct device *dev)
{
- struct platform_device *pdev = to_platform_device(dev);
- struct zynq_gpio *gpio = platform_get_drvdata(pdev);
+ struct zynq_gpio *gpio = dev_get_drvdata(dev);
clk_disable_unprepare(gpio->clk);
@@ -703,8 +702,7 @@ static int __maybe_unused zynq_gpio_runtime_suspend(struct device *dev)
static int __maybe_unused zynq_gpio_runtime_resume(struct device *dev)
{
- struct platform_device *pdev = to_platform_device(dev);
- struct zynq_gpio *gpio = platform_get_drvdata(pdev);
+ struct zynq_gpio *gpio = dev_get_drvdata(dev);
return clk_prepare_enable(gpio->clk);
}
--
2.19.0
^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [PATCH 5/6] gpio: gpio-tegra: simplify getting .driver_data
2018-10-21 20:00 ` [PATCH 5/6] gpio: gpio-tegra: " Wolfram Sang
@ 2018-10-22 8:01 ` Thierry Reding
2018-10-30 13:20 ` Linus Walleij
1 sibling, 0 replies; 15+ messages in thread
From: Thierry Reding @ 2018-10-22 8:01 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-kernel, linux-renesas-soc, Linus Walleij, Jonathan Hunter,
linux-gpio, linux-tegra
[-- Attachment #1: Type: text/plain, Size: 458 bytes --]
On Sun, Oct 21, 2018 at 10:00:00PM +0200, Wolfram Sang wrote:
> We should get 'driver_data' from 'struct device' directly. Going via
> platform_device is an unneeded step back and forth.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>
> Build tested only. buildbot is happy.
>
> drivers/gpio/gpio-tegra.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 4/6] gpio: gpio-omap: simplify getting .driver_data
2018-10-21 19:59 ` [PATCH 4/6] gpio: gpio-omap: " Wolfram Sang
@ 2018-10-22 18:30 ` Grygorii Strashko
2018-10-30 13:18 ` Linus Walleij
1 sibling, 0 replies; 15+ messages in thread
From: Grygorii Strashko @ 2018-10-22 18:30 UTC (permalink / raw)
To: Wolfram Sang, linux-kernel
Cc: linux-renesas-soc, Santosh Shilimkar, Kevin Hilman,
Linus Walleij, linux-omap, linux-gpio
On 10/21/18 2:59 PM, Wolfram Sang wrote:
> We should get 'driver_data' from 'struct device' directly. Going via
> platform_device is an unneeded step back and forth.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>
> Build tested only. buildbot is happy.
Thank you
Acked-by: Grygorii Strashko <grygorii.strashko@ti.com>
--
regards,
-grygorii
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 1/6] gpio: gpio-dwapb: simplify getting .driver_data
2018-10-21 19:59 ` [PATCH 1/6] gpio: gpio-dwapb: " Wolfram Sang
@ 2018-10-30 13:12 ` Linus Walleij
0 siblings, 0 replies; 15+ messages in thread
From: Linus Walleij @ 2018-10-30 13:12 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-kernel, Linux-Renesas, Hoan Tran, open list:GPIO SUBSYSTEM
On Sun, Oct 21, 2018 at 10:00 PM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> We should get 'driver_data' from 'struct device' directly. Going via
> platform_device is an unneeded step back and forth.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Patch applied for v4.21.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 2/6] gpio: gpio-lynxpoint: simplify getting .driver_data
2018-10-21 19:59 ` [PATCH 2/6] gpio: gpio-lynxpoint: " Wolfram Sang
@ 2018-10-30 13:14 ` Linus Walleij
0 siblings, 0 replies; 15+ messages in thread
From: Linus Walleij @ 2018-10-30 13:14 UTC (permalink / raw)
To: Wolfram Sang; +Cc: linux-kernel, Linux-Renesas, open list:GPIO SUBSYSTEM
On Sun, Oct 21, 2018 at 10:00 PM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> We should get 'driver_data' from 'struct device' directly. Going via
> platform_device is an unneeded step back and forth.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Patch applied for v4.21.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 3/6] gpio: gpio-mxc: simplify getting .driver_data
2018-10-21 19:59 ` [PATCH 3/6] gpio: gpio-mxc: " Wolfram Sang
@ 2018-10-30 13:15 ` Linus Walleij
0 siblings, 0 replies; 15+ messages in thread
From: Linus Walleij @ 2018-10-30 13:15 UTC (permalink / raw)
To: Wolfram Sang; +Cc: linux-kernel, Linux-Renesas, open list:GPIO SUBSYSTEM
On Sun, Oct 21, 2018 at 10:00 PM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> We should get 'driver_data' from 'struct device' directly. Going via
> platform_device is an unneeded step back and forth.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Patch applied for v4.21.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 4/6] gpio: gpio-omap: simplify getting .driver_data
2018-10-21 19:59 ` [PATCH 4/6] gpio: gpio-omap: " Wolfram Sang
2018-10-22 18:30 ` Grygorii Strashko
@ 2018-10-30 13:18 ` Linus Walleij
1 sibling, 0 replies; 15+ messages in thread
From: Linus Walleij @ 2018-10-30 13:18 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-kernel, Linux-Renesas, Grygorii Strashko,
Santosh Shilimkar, Kevin Hilman, Linux-OMAP,
open list:GPIO SUBSYSTEM
On Sun, Oct 21, 2018 at 10:00 PM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> We should get 'driver_data' from 'struct device' directly. Going via
> platform_device is an unneeded step back and forth.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 6/6] gpio: gpio-zynq: simplify getting .driver_data
2018-10-21 20:00 ` [PATCH 6/6] gpio: gpio-zynq: " Wolfram Sang
@ 2018-10-30 13:19 ` Linus Walleij
0 siblings, 0 replies; 15+ messages in thread
From: Linus Walleij @ 2018-10-30 13:19 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-kernel, Linux-Renesas, Michal Simek,
open list:GPIO SUBSYSTEM, Linux ARM
On Sun, Oct 21, 2018 at 10:00 PM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> We should get 'driver_data' from 'struct device' directly. Going via
> platform_device is an unneeded step back and forth.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 5/6] gpio: gpio-tegra: simplify getting .driver_data
2018-10-21 20:00 ` [PATCH 5/6] gpio: gpio-tegra: " Wolfram Sang
2018-10-22 8:01 ` Thierry Reding
@ 2018-10-30 13:20 ` Linus Walleij
1 sibling, 0 replies; 15+ messages in thread
From: Linus Walleij @ 2018-10-30 13:20 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-kernel, Linux-Renesas, thierry.reding, Jon Hunter,
open list:GPIO SUBSYSTEM, linux-tegra
On Sun, Oct 21, 2018 at 10:00 PM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> We should get 'driver_data' from 'struct device' directly. Going via
> platform_device is an unneeded step back and forth.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2018-10-30 13:21 UTC | newest]
Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-21 19:59 [PATCH 0/6] gpio: simplify getting .driver_data Wolfram Sang
2018-10-21 19:59 ` [PATCH 1/6] gpio: gpio-dwapb: " Wolfram Sang
2018-10-30 13:12 ` Linus Walleij
2018-10-21 19:59 ` [PATCH 2/6] gpio: gpio-lynxpoint: " Wolfram Sang
2018-10-30 13:14 ` Linus Walleij
2018-10-21 19:59 ` [PATCH 3/6] gpio: gpio-mxc: " Wolfram Sang
2018-10-30 13:15 ` Linus Walleij
2018-10-21 19:59 ` [PATCH 4/6] gpio: gpio-omap: " Wolfram Sang
2018-10-22 18:30 ` Grygorii Strashko
2018-10-30 13:18 ` Linus Walleij
2018-10-21 20:00 ` [PATCH 5/6] gpio: gpio-tegra: " Wolfram Sang
2018-10-22 8:01 ` Thierry Reding
2018-10-30 13:20 ` Linus Walleij
2018-10-21 20:00 ` [PATCH 6/6] gpio: gpio-zynq: " Wolfram Sang
2018-10-30 13:19 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).