From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F468C46475 for ; Thu, 25 Oct 2018 07:50:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DA26E204FD for ; Thu, 25 Oct 2018 07:50:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DA26E204FD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727117AbeJYQWR (ORCPT ); Thu, 25 Oct 2018 12:22:17 -0400 Received: from mga12.intel.com ([192.55.52.136]:40401 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726546AbeJYQWR (ORCPT ); Thu, 25 Oct 2018 12:22:17 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Oct 2018 00:50:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,423,1534834800"; d="scan'208";a="94874090" Received: from reinig-mobl1.ger.corp.intel.com (HELO [10.252.35.227]) ([10.252.35.227]) by orsmga003.jf.intel.com with ESMTP; 25 Oct 2018 00:50:40 -0700 Subject: Re: [PATCH] drm: fix call_kern.cocci warnings (fwd) To: Julia Lawall , Chunming Zhou Cc: kbuild-all@01.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, =?UTF-8?Q?Christian_K=c3=b6nig?= , Gustavo Padovan , Sean Paul , David Airlie , linux-kernel@vger.kernel.org References: From: Maarten Lankhorst Message-ID: <995c8e64-46d3-7320-744e-b9bd1cb66530@linux.intel.com> Date: Thu, 25 Oct 2018 09:50:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Op 24-10-18 om 20:57 schreef Julia Lawall: > The containing function is called with a spin_lock held, so GFP_KERNEL > can't be used. > > julia > > ---------- Forwarded message ---------- > Date: Tue, 23 Oct 2018 17:14:25 +0800 > From: kbuild test robot > To: kbuild@01.org > Cc: Julia Lawall > Subject: [PATCH] drm: fix call_kern.cocci warnings > > CC: kbuild-all@01.org > CC: intel-gfx@lists.freedesktop.org > CC: dri-devel@lists.freedesktop.org > TO: Chunming Zhou > CC: "Christian König" > CC: Gustavo Padovan > CC: Maarten Lankhorst > CC: Sean Paul > CC: David Airlie > CC: dri-devel@lists.freedesktop.org > CC: linux-kernel@vger.kernel.org > > From: kbuild test robot > > drivers/gpu/drm/drm_syncobj.c:202:4-14: ERROR: function drm_syncobj_find_signal_pt_for_point called on line 390 inside lock on line 389 but uses GFP_KERNEL > > Find functions that refer to GFP_KERNEL but are called with locks held. > > Semantic patch information: > The proposed change of converting the GFP_KERNEL is not necessarily the > correct one. It may be desired to unlock the lock, or to not call the > function under the lock in the first place. > > Generated by: scripts/coccinelle/locks/call_kern.cocci > > Fixes: 48197bc564c7 ("drm: add syncobj timeline support v9") > CC: Chunming Zhou > Signed-off-by: kbuild test robot The issue appears to be real and the patch looks sane. Chunming Zhou, do you want to fix it like this, or preallocate a fence obj? If former, just ack. :) ~Maarten > > tree: git://anongit.freedesktop.org/drm/drm-tip drm-tip > head: 8d7ffd2298c607c3e1a16f94d51450d7940fd6a7 > commit: 48197bc564c7a1888c86024a1ba4f956e0ec2300 [1968/2033] drm: add syncobj timeline support v9 > :::::: branch date: 4 hours ago > :::::: commit date: 5 days ago > > Please take the patch only if it's a positive warning. Thanks! > > drm_syncobj.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/drivers/gpu/drm/drm_syncobj.c > +++ b/drivers/gpu/drm/drm_syncobj.c > @@ -199,7 +199,7 @@ static struct dma_fence > (point <= syncobj->timeline)) { > struct drm_syncobj_stub_fence *fence = > kzalloc(sizeof(struct drm_syncobj_stub_fence), > - GFP_KERNEL); > + GFP_ATOMIC); > > if (!fence) > return NULL;