From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 100A3C35242 for ; Fri, 14 Feb 2020 19:24:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3A5992168B for ; Fri, 14 Feb 2020 19:24:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=goldelico.com header.i=@goldelico.com header.b="bnllaR1c" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388359AbgBNTYx (ORCPT ); Fri, 14 Feb 2020 14:24:53 -0500 Received: from mo4-p01-ob.smtp.rzone.de ([81.169.146.166]:10127 "EHLO mo4-p01-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729320AbgBNTYx (ORCPT ); Fri, 14 Feb 2020 14:24:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1581708290; s=strato-dkim-0002; d=goldelico.com; h=To:References:Message-Id:Cc:Date:In-Reply-To:From:Subject: X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender; bh=03m8BEwlXcwChCVlIXs0rdo4wuFy4IhdekvfTMx1/rY=; b=bnllaR1cxkOIVntJxgWbSAFmFZ/eaNfIKxJls/ANKTChbjNz0b4bRuYQPkhx00lYt7 XPGVQV3VV/8iDdgkZNr6z7J1fRUbSn/llSpJZgyW1YHFDoZHX2FkicuTrLN+zdXDmNPo NS+Kuek2B25Jw9NcH62m+87ScWvA0lKy9QoKS6Ei9FgoS2hASX8kjlLEczWyfSYGGqYv a+LXgBtcSr0C1tJp8fq0LZcBIJY9Bcod/cfvoldM7iKHwPKAoK1lIG/6XB8lb4j7ELul JEJfplM+tbJt6XHvmzvZJ0uRYDeEDBMJo5m+vI+++GOTt2XzYCN07uT9kuP48vM2hUAF 1gwg== X-RZG-AUTH: ":JGIXVUS7cutRB/49FwqZ7WcJeFKiMgPgp8VKxflSZ1P34KBj7wpz8NMGH/PuwDOspHA=" X-RZG-CLASS-ID: mo00 Received: from imac.fritz.box by smtp.strato.de (RZmta 46.1.12 DYNA|AUTH) with ESMTPSA id U06217w1EJOOGBY (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (curve X9_62_prime256v1 with 256 ECDH bits, eq. 3072 bits RSA)) (Client did not present a certificate); Fri, 14 Feb 2020 20:24:24 +0100 (CET) Content-Type: text/plain; charset=iso-8859-1 Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Subject: Re: [PATCH v2] net: davicom: dm9000: allow to pass MAC address through mac_addr module parameter From: "H. Nikolaus Schaller" In-Reply-To: <1581706048.3.3@crapouillou.net> Date: Fri, 14 Feb 2020 20:24:22 +0100 Cc: Andrew Lunn , "David S. Miller" , =?utf-8?Q?Petr_=C5=A0tetiar?= , Richard Fontana , Thomas Gleixner , Heiner Kallweit , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, letux-kernel@openphoenux.org, kernel@pyra-handheld.com Content-Transfer-Encoding: quoted-printable Message-Id: <996F2206-B261-46E3-9167-B48BA7D3C9FF@goldelico.com> References: <0d6b4d383bb29ed5d4710e9706e5ad6c7f92d9da.1581696454.git.hns@goldelico.com> <1581706048.3.3@crapouillou.net> To: Paul Cercueil X-Mailer: Apple Mail (2.3124) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Am 14.02.2020 um 19:47 schrieb Paul Cercueil : >=20 > Hi Nikolaus, >=20 > What I'd suggest is to write a NVMEM driver for the efuse and retrieve = the MAC address cleanly with nvmem_get_mac_address(). >=20 > It shouldn't be hard to do (there's already code for it in the = non-upstream 3.18 kernel for the CI20) and you remove the dependency on = uboot. Interesting approach. I have found this: https://lore.kernel.org/patchwork/patch/868158/ but it looks as if it was never finished (I could not locate a V3 or = anything mainline?) and and it tries to solve other problems as well. And it looks to be much more complex than my "solution" to the immediate = problem. I have to study it to know if I can write a nvmem_get_mac_address(). BR, Nikolaus >=20 > -Paul >=20 >=20 > Le ven., f=E9vr. 14, 2020 at 17:07, H. Nikolaus Schaller = a =E9crit : >> The MIPS Ingenic CI20 board is shipped with a quite old u-boot >> (ci20-v2013.10 see https://elinux.org/CI20_Dev_Zone). This passes >> the MAC address through dm9000.mac_addr=3Dxx:xx:xx:xx:xx:xx >> kernel module parameter to give the board a fixed MAC address. >> This is not processed by the dm9000 driver which assigns a random >> MAC address on each boot, making DHCP assign a new IP address >> each time. >> So we add a check for the mac_addr module parameter as a last >> resort before assigning a random one. This mechanism can also >> be used outside of u-boot to provide a value through modprobe >> config. >> To parse the MAC address in a new function get_mac_addr() we >> use an copy adapted from the ksz884x.c driver which provides >> the same functionality. >> Signed-off-by: H. Nikolaus Schaller >> --- >> drivers/net/ethernet/davicom/dm9000.c | 42 = +++++++++++++++++++++++++++ >> 1 file changed, 42 insertions(+) >> diff --git a/drivers/net/ethernet/davicom/dm9000.c = b/drivers/net/ethernet/davicom/dm9000.c >> index 1ea3372775e6..7402030b0352 100644 >> --- a/drivers/net/ethernet/davicom/dm9000.c >> +++ b/drivers/net/ethernet/davicom/dm9000.c >> @@ -1409,6 +1409,43 @@ static struct dm9000_plat_data = *dm9000_parse_dt(struct device *dev) >> return pdata; >> } >> +static char *mac_addr =3D ":"; >> +module_param(mac_addr, charp, 0); >> +MODULE_PARM_DESC(mac_addr, "MAC address"); >> + >> +static void get_mac_addr(struct net_device *ndev, char *macaddr) >> +{ >> + int i =3D 0; >> + int j =3D 0; >> + int got_num =3D 0; >> + int num =3D 0; >> + >> + while (j < ETH_ALEN) { >> + if (macaddr[i]) { >> + int digit; >> + >> + got_num =3D 1; >> + digit =3D hex_to_bin(macaddr[i]); >> + if (digit >=3D 0) >> + num =3D num * 16 + digit; >> + else if (':' =3D=3D macaddr[i]) >> + got_num =3D 2; >> + else >> + break; >> + } else if (got_num) { >> + got_num =3D 2; >> + } else { >> + break; >> + } >> + if (got_num =3D=3D 2) { >> + ndev->dev_addr[j++] =3D (u8)num; >> + num =3D 0; >> + got_num =3D 0; >> + } >> + i++; >> + } >> +} >> + >> /* >> * Search DM9000 board, allocate space and register it >> */ >> @@ -1679,6 +1716,11 @@ dm9000_probe(struct platform_device *pdev) >> ndev->dev_addr[i] =3D ior(db, i+DM9000_PAR); >> } >> + if (!is_valid_ether_addr(ndev->dev_addr)) { >> + mac_src =3D "param"; >> + get_mac_addr(ndev, mac_addr); >> + } >> + >> if (!is_valid_ether_addr(ndev->dev_addr)) { >> inv_mac_addr =3D true; >> eth_hw_addr_random(ndev); >> -- >> 2.23.0 >=20 >=20