LKML Archive on
 help / color / Atom feed
From: Markus Elfring <>
To: Wen Yang <>,
Cc: Benjamin Herrenschmidt <>,
	Cheng Shengyu <>,
	Kumar Gala <>,
	Michael Ellerman <>,
	Paul Mackerras <>, Scott Wood <>,
	Xue Zhihong <>,
	Yi Wang <>,,
Subject: Re: powerpc/83xx: fix use-after-free on mpc831x_usb_cfg()
Date: Mon, 8 Jul 2019 17:21:48 +0200
Message-ID: <> (raw)
In-Reply-To: <>

> The np variable is still being used after the of_node_put() call,

> which may result in use-after-free.

> We fix this issue by calling of_node_put() after the last usage.

I imagine that this commit description can be improved a bit more
(by mentioning the influence of “immr_node”?).
How do you think about to omit the word “We” here?

> This patatch also do some cleanup.

Should the renaming of a jump label be contributed in a separate update
step of a small patch series besides a wording without a typo?


      reply index

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-05  8:58 [PATCH] " Wen Yang
2019-07-08 15:21 ` Markus Elfring [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

LKML Archive on

Archives are clonable:
	git clone --mirror lkml/git/0.git
	git clone --mirror lkml/git/1.git
	git clone --mirror lkml/git/2.git
	git clone --mirror lkml/git/3.git
	git clone --mirror lkml/git/4.git
	git clone --mirror lkml/git/5.git
	git clone --mirror lkml/git/6.git
	git clone --mirror lkml/git/7.git
	git clone --mirror lkml/git/8.git
	git clone --mirror lkml/git/9.git
	git clone --mirror lkml/git/10.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ \
	public-inbox-index lkml

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone