From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Bhupesh Sharma <bhupesh.sharma@linaro.org>, devicetree@vger.kernel.org
Cc: linux-arm-msm@vger.kernel.org, agross@kernel.org,
bhupesh.linux@gmail.com, linux-kernel@vger.kernel.org,
robh+dt@kernel.org, netdev@vger.kernel.org,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh@kernel.org>, Vinod Koul <vkoul@kernel.org>,
David Miller <davem@davemloft.net>
Subject: Re: [PATCH v2 3/4] dt-bindings: net: qcom,ethqos: Convert bindings to yaml
Date: Fri, 30 Sep 2022 12:26:11 +0200 [thread overview]
Message-ID: <9999a1a3-cda0-2759-f6f4-9bc7414f9ee4@linaro.org> (raw)
In-Reply-To: <1163e862-d36a-9b5e-2019-c69be41cc220@linaro.org>
On 30/09/2022 10:12, Bhupesh Sharma wrote:
>>> + snps,reset-gpio:
>>> + maxItems: 1
>>
>> Why is this one here? It's already in snps,dwmac.
>>
>> Actually this applies to several other properties. You have
>> unevaluatedProperties:false, so you do not have to duplicate snps,dwmac.
>> You only need to constrain it, like we said about interrupts in your
>> previous patch.
>
> I was actually getting errors like the following without the same:
>
> arm64/boot/dts/qcom/qcs404-evb-1000.dtb: ethernet@7a80000: Unevaluated
> properties are not allowed ('snps,tso' was unexpected)
> From schema: Documentation/devicetree/bindings/net/qcom,ethqos.yaml
>
> So, its not clear to me that even though 'snps,dwmac.yaml' is referenced
> here, the property appears as unevaluated.
Because snps,tso is not allowed, but the rest is.
>
>>> +
>>> + power-domains:
>>> + maxItems: 1
>>> +
>>> + resets:
>>> + maxItems: 1
>>> +
>>> + rx-fifo-depth:
>>> + $ref: /schemas/types.yaml#/definitions/uint32
>>> +
>>> + tx-fifo-depth:
>>> + $ref: /schemas/types.yaml#/definitions/uint32
>>> +
>>> + snps,tso:
>>> + type: boolean
>>> + description: Enables the TSO feature (otherwise managed by MAC HW capability register).
>>
>> You add here several new properties. Mention in commit msg changes from
>> pure conversion with answer to "why".
>
> Right, most of them are to avoid the make dtbs_check errors / warnings
> like the one mentioned above.
All of them should not be here.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-09-30 11:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-29 6:04 [PATCH v2 0/4] dt-bindings: net: Convert qcom,ethqos bindings to YAML (and related fixes) Bhupesh Sharma
2022-09-29 6:04 ` [PATCH v2 1/4] dt-bindings: net: snps,dwmac: Update interrupt-names Bhupesh Sharma
2022-09-29 7:17 ` Krzysztof Kozlowski
2022-09-29 6:04 ` [PATCH v2 2/4] dt-bindings: net: snps,dwmac: Add Qualcomm Ethernet ETHQOS compatibles Bhupesh Sharma
2022-09-29 7:17 ` Krzysztof Kozlowski
2022-09-29 6:04 ` [PATCH v2 3/4] dt-bindings: net: qcom,ethqos: Convert bindings to yaml Bhupesh Sharma
2022-09-29 7:22 ` Krzysztof Kozlowski
2022-09-30 8:12 ` Bhupesh Sharma
2022-09-30 10:26 ` Krzysztof Kozlowski [this message]
2022-10-01 12:51 ` Bhupesh Sharma
2022-10-02 7:54 ` Krzysztof Kozlowski
2022-10-03 8:29 ` Bhupesh Sharma
2022-10-03 9:32 ` Krzysztof Kozlowski
2023-02-22 20:29 ` Andrew Halaney
2023-02-23 19:09 ` Bhupesh Sharma
2022-09-29 6:04 ` [PATCH v2 4/4] MAINTAINERS: Point to the yaml version of 'qcom,ethqos' dt-bindings Bhupesh Sharma
2022-09-29 7:23 ` Krzysztof Kozlowski
2022-09-30 6:01 ` Bhupesh Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9999a1a3-cda0-2759-f6f4-9bc7414f9ee4@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=bhupesh.linux@gmail.com \
--cc=bhupesh.sharma@linaro.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).