From: Grygorii Strashko <grygorii.strashko@ti.com>
To: Boris Brezillon <boris.brezillon@bootlin.com>,
Wolfram Sang <wsa@the-dreams.de>, <linux-i2c@vger.kernel.org>,
Jonathan Corbet <corbet@lwn.net>, <linux-doc@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Arnd Bergmann <arnd@arndb.de>
Cc: Przemyslaw Sroka <psroka@cadence.com>,
Arkadiusz Golec <agolec@cadence.com>,
Alan Douglas <adouglas@cadence.com>,
Bartosz Folta <bfolta@cadence.com>, Damian Kos <dkos@cadence.com>,
Alicja Jurasik-Urbaniak <alicja@cadence.com>,
Cyprian Wronka <cwronka@cadence.com>,
Suresh Punnoose <sureshp@cadence.com>,
Rafal Ciepiela <rafalc@cadence.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Nishanth Menon <nm@ti.com>, Rob Herring <robh+dt@kernel.org>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
Vitor Soares <Vitor.Soares@synopsys.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Linus Walleij <linus.walleij@linaro.org>,
Xiang Lin <Xiang.Lin@synaptics.com>, <linux-gpio@vger.kernel.org>,
Sekhar Nori <nsekhar@ti.com>, Przemyslaw Gaj <pgaj@cadence.com>,
Peter Rosin <peda@axentia.se>,
Mike Shettel <mshettel@codeaurora.org>,
Stephen Boyd <swboyd@chromium.org>, Joe Perches <joe@perches.com>
Subject: Re: [PATCH v9 6/9] i3c: master: Add driver for Cadence IP
Date: Wed, 24 Oct 2018 15:25:17 -0500 [thread overview]
Message-ID: <99a506e3-d9d5-0d3e-26e1-031447c14857@ti.com> (raw)
In-Reply-To: <20181024202048.7e3534f7@bbrezillon>
On 10/24/18 1:20 PM, Boris Brezillon wrote:
> Hi Arnd,
>
> On Mon, 22 Oct 2018 15:34:01 +0200
> Boris Brezillon <boris.brezillon@bootlin.com> wrote:
>
>
>> +
>> +static void cdns_i3c_master_rd_from_rx_fifo(struct cdns_i3c_master *master,
>> + u8 *bytes, int nbytes)
>> +{
>> + readsl(master->regs + RX_FIFO, bytes, nbytes / 4);
>
> Vitor reported a problem with readsl(): this function expects the 2nd
> argument to be aligned on 32-bit, which is not guaranteed here. Unless
> you see a better solution, I'll switch back to a loop doing:
>
> for (i = 0; i < nbytes; i += 4) {
> u32 tmp = __raw_readl(...);
Pls, do not use __raw io.
> memcpy(bytes + i, &tmp,
> nbytes - i > 4 ? 4 : nbytes - i);
> }
>
>> + if (nbytes & 3) {
>> + u32 tmp;
>> +
>> + readsl(master->regs + RX_FIFO, &tmp, 1);
>> + memcpy(bytes + (nbytes & ~3), &tmp, nbytes & 3);
>> + }
>> +}
>
> Regards,
>
> Boris
>
--
regards,
-grygorii
next prev parent reply other threads:[~2018-10-24 20:25 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-22 13:33 [PATCH v9 0/9] Add the I3C subsystem Boris Brezillon
2018-10-22 13:33 ` [PATCH v9 1/9] i3c: Add core I3C infrastructure Boris Brezillon
2018-10-22 13:33 ` [PATCH v9 2/9] docs: driver-api: Add I3C documentation Boris Brezillon
2018-10-22 13:33 ` [PATCH v9 3/9] i3c: Add sysfs ABI spec Boris Brezillon
2018-10-22 13:33 ` [PATCH v9 4/9] dt-bindings: i3c: Document core bindings Boris Brezillon
2018-10-22 20:45 ` Rob Herring
2018-10-22 13:34 ` [PATCH v9 5/9] MAINTAINERS: Add myself as the I3C subsystem maintainer Boris Brezillon
2018-10-22 13:34 ` [PATCH v9 6/9] i3c: master: Add driver for Cadence IP Boris Brezillon
2018-10-24 18:20 ` Boris Brezillon
2018-10-24 20:25 ` Grygorii Strashko [this message]
2018-10-24 21:04 ` Boris Brezillon
2018-10-24 22:43 ` Grygorii Strashko
2018-10-24 22:52 ` Boris Brezillon
2018-10-25 15:30 ` Arnd Bergmann
2018-10-25 16:07 ` Boris Brezillon
2018-10-25 16:13 ` Arnd Bergmann
2018-10-25 16:30 ` Boris Brezillon
2018-10-26 7:43 ` Arnd Bergmann
2018-10-26 7:57 ` Boris Brezillon
2018-10-26 10:01 ` Arnd Bergmann
2018-10-26 12:46 ` Boris Brezillon
2018-10-26 13:21 ` Arnd Bergmann
2018-10-22 13:34 ` [PATCH v9 7/9] dt-bindings: i3c: Document Cadence I3C master bindings Boris Brezillon
2018-10-22 13:34 ` [PATCH v9 8/9] gpio: Add a driver for Cadence I3C GPIO expander Boris Brezillon
2018-10-22 13:34 ` [PATCH v9 9/9] dt-bindings: gpio: Add bindings for Cadence I3C gpio expander Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99a506e3-d9d5-0d3e-26e1-031447c14857@ti.com \
--to=grygorii.strashko@ti.com \
--cc=Vitor.Soares@synopsys.com \
--cc=Xiang.Lin@synaptics.com \
--cc=adouglas@cadence.com \
--cc=agolec@cadence.com \
--cc=alicja@cadence.com \
--cc=arnd@arndb.de \
--cc=bfolta@cadence.com \
--cc=boris.brezillon@bootlin.com \
--cc=corbet@lwn.net \
--cc=cwronka@cadence.com \
--cc=devicetree@vger.kernel.org \
--cc=dkos@cadence.com \
--cc=galak@codeaurora.org \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=joe@perches.com \
--cc=linus.walleij@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mshettel@codeaurora.org \
--cc=nm@ti.com \
--cc=nsekhar@ti.com \
--cc=pawel.moll@arm.com \
--cc=peda@axentia.se \
--cc=pgaj@cadence.com \
--cc=psroka@cadence.com \
--cc=rafalc@cadence.com \
--cc=robh+dt@kernel.org \
--cc=sureshp@cadence.com \
--cc=swboyd@chromium.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).