From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=xYIU=RV=vger.kernel.org=linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no
	version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 6E51AC43381
	for <linux-kernel@archiver.kernel.org>; Mon, 18 Mar 2019 17:58:00 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id 4115E20685
	for <linux-kernel@archiver.kernel.org>; Mon, 18 Mar 2019 17:58:00 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726889AbfCRR56 (ORCPT
        <rfc822;linux-kernel@archiver.kernel.org>);
        Mon, 18 Mar 2019 13:57:58 -0400
Received: from mga18.intel.com ([134.134.136.126]:33026 "EHLO mga18.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726720AbfCRR56 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 18 Mar 2019 13:57:58 -0400
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga005.fm.intel.com ([10.253.24.32])
  by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Mar 2019 10:57:57 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.58,494,1544515200"; 
   d="scan'208";a="329714040"
Received: from linux.intel.com ([10.54.29.200])
  by fmsmga005.fm.intel.com with ESMTP; 18 Mar 2019 10:57:55 -0700
Received: from [10.251.91.19] (abudanko-mobl.ccr.corp.intel.com [10.251.91.19])
        by linux.intel.com (Postfix) with ESMTP id 9B6AD580238;
        Mon, 18 Mar 2019 10:57:52 -0700 (PDT)
Subject: Re: [PATCH v9 00/12] perf: enable compression of record mode trace to
 save storage space
To:     Jiri Olsa <jolsa@redhat.com>
Cc:     Arnaldo Carvalho de Melo <acme@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Ingo Molnar <mingo@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Andi Kleen <ak@linux.intel.com>,
        linux-kernel <linux-kernel@vger.kernel.org>
References: <c1423198-e474-1739-e800-4615cce501ce@linux.intel.com>
 <20190318114625.GB7900@krava>
From:   Alexey Budankov <alexey.budankov@linux.intel.com>
Organization: Intel Corp.
Message-ID: <99c0d81f-95e2-7036-d8f1-5ca3e9160acd@linux.intel.com>
Date:   Mon, 18 Mar 2019 20:57:51 +0300
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.5.1
MIME-Version: 1.0
In-Reply-To: <20190318114625.GB7900@krava>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 18.03.2019 14:46, Jiri Olsa wrote:
> On Sat, Mar 16, 2019 at 11:58:30AM +0300, Alexey Budankov wrote:
> 
> SNIP
> 
>> ---
>> Alexey Budankov (12):
>>   feature: implement libzstd check, LIBZSTD_DIR and NO_LIBZSTD defines
>>   perf record: implement --mmap-flush=<number> option
>>   perf session: define bytes_transferred and bytes_compressed metrics
>>   perf record: implement COMPRESSED event record and its attributes
>>   perf mmap: implement dedicated memory buffer for data compression
>>   perf util: introduce Zstd streaming based compression API
>>   perf record: implement compression for serial trace streaming
>>   perf record: implement compression for AIO trace streaming
>>   perf record: implement -z,--compression_level[=<n>] option
>>   perf report: implement record trace decompression
>>   perf inject: enable COMPRESSED records decompression
>>   perf tests: implement Zstd comp/decomp integration test
>>
>>  tools/build/Makefile.feature                  |   6 +-
>>  tools/build/feature/Makefile                  |   6 +-
>>  tools/build/feature/test-all.c                |   5 +
>>  tools/build/feature/test-libzstd.c            |  12 +
>>  tools/perf/Documentation/perf-record.txt      |  17 ++
>>  .../Documentation/perf.data-file-format.txt   |  24 ++
>>  tools/perf/Makefile.config                    |  20 ++
>>  tools/perf/Makefile.perf                      |   3 +
>>  tools/perf/builtin-inject.c                   |   4 +
>>  tools/perf/builtin-record.c                   | 285 +++++++++++++++---
>>  tools/perf/builtin-report.c                   |   5 +-
>>  tools/perf/builtin-version.c                  |   2 +
>>  tools/perf/perf.h                             |   2 +
>>  .../tests/shell/record+zstd_comp_decomp.sh    |  28 ++
>>  tools/perf/util/Build                         |   2 +
>>  tools/perf/util/compress.h                    |  54 ++++
>>  tools/perf/util/env.h                         |  11 +
>>  tools/perf/util/event.c                       |   1 +
>>  tools/perf/util/event.h                       |   7 +
>>  tools/perf/util/evlist.c                      |   8 +-
>>  tools/perf/util/evlist.h                      |   3 +-
>>  tools/perf/util/header.c                      |  55 +++-
>>  tools/perf/util/header.h                      |   1 +
>>  tools/perf/util/mmap.c                        | 106 ++-----
>>  tools/perf/util/mmap.h                        |  17 +-
>>  tools/perf/util/session.c                     | 124 +++++++-
>>  tools/perf/util/session.h                     |  14 +
>>  tools/perf/util/tool.h                        |   2 +
>>  tools/perf/util/zstd.c                        | 111 +++++++
>>  29 files changed, 801 insertions(+), 134 deletions(-)
>>  create mode 100644 tools/build/feature/test-libzstd.c
>>  create mode 100755 tools/perf/tests/shell/record+zstd_comp_decomp.sh
>>  create mode 100644 tools/perf/util/zstd.c
>>
>> ---
>> Changes in v9:
>> - fixed issue with improper max COMPRESSED record size calculation
>> - moved up calculation of ratio variable in 03/12
>> - made minor corrections in changelogs
>> - corrected several checkpatch.pl warnings and errors
> 
> apart from 2 comments I'm ok with this patchset

Comments are addressed in v10.

> 
> Reviewed-by: Jiri Olsa <jolsa@kernel.org>

Thanks,
Alexey

> 
> thanks a lot,
> jirka
>