From: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
imunsie@au1.ibm.com, fbarrat@linux.vnet.ibm.com
Cc: kernel-janitors@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cxl: Fix memory allocation failure test
Date: Mon, 31 Oct 2016 17:16:46 +1100 [thread overview]
Message-ID: <99cf0e87-a130-446b-0628-9fba55098dda@au1.ibm.com> (raw)
In-Reply-To: <20161030193557.23862-1-christophe.jaillet@wanadoo.fr>
On 31/10/16 06:35, Christophe JAILLET wrote:
> 'cxl_context_alloc()' does not return an error pointer. It is just a
> shortcut for a call to 'kzalloc' with 'sizeof(struct cxl_context)' as the
> size parameter.
>
> So its return value should be compared with NULL.
> While fixing it, simplify a bit the code.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
> ---
> un-compiled because I don't have the required cross build environment.
Compiles on my system!
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnellan@au1.ibm.com IBM Australia Limited
next prev parent reply other threads:[~2016-10-31 6:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-30 19:35 [PATCH] cxl: Fix memory allocation failure test Christophe JAILLET
2016-10-30 20:11 ` walter harms
2016-10-31 6:16 ` Andrew Donnellan [this message]
2016-11-02 16:45 ` Frederic Barrat
2016-11-16 1:56 ` Ian Munsie
2016-11-22 0:34 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99cf0e87-a130-446b-0628-9fba55098dda@au1.ibm.com \
--to=andrew.donnellan@au1.ibm.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=fbarrat@linux.vnet.ibm.com \
--cc=imunsie@au1.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).