From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C46CC433B4 for ; Fri, 14 May 2021 09:57:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 06CF861459 for ; Fri, 14 May 2021 09:57:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232376AbhENJ6q (ORCPT ); Fri, 14 May 2021 05:58:46 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:38254 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230212AbhENJ6m (ORCPT ); Fri, 14 May 2021 05:58:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620986250; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8rzJBsGwhabN6jmugEogWwENANkkfJK8/J4mWGWKpXU=; b=WbHpA5Qp7iSepViXgW5hsyY6DLRSYzaUxmAk+inLG/zaMHIxnAsqruNtZsbsv50vX3xEuF Z4BzTt0IHe202Np1aM/Rr3sOpRhGedMjhatrq09qCbyxNF4xkgI4EfiieOLjRJi0C+jAAb Gd+u7Bv90fR3kWttAgt8FmYkhDOqeaI= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-197-QtgbUvR2OtKzi1E-lBkyug-1; Fri, 14 May 2021 05:57:28 -0400 X-MC-Unique: QtgbUvR2OtKzi1E-lBkyug-1 Received: by mail-ej1-f69.google.com with SMTP id sd18-20020a170906ce32b02903cedf584542so3347249ejb.9 for ; Fri, 14 May 2021 02:57:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=8rzJBsGwhabN6jmugEogWwENANkkfJK8/J4mWGWKpXU=; b=bsy04jZxXbw2M2gGB8zZsvhblpI37xBwJ+6bVyXvIJF/lZeZcZ9vBsB7scu+OLf5q5 qxe7NwL3Iwou13mY3AgMJzugh6QS/LDcRCiOSFKUlYRRfvg7JMi5JCIGdwbBFyBPWmzD 6vFZ08b0szWlEgpMdlPQSEU6Vjc3SASA8Rbpo1opIDJVCLGimhFUzHBXdSY7wFDU31qk 54IO/hbWpSJ5uYAZVPNiSdwuZrhe6PKzgDDQvMU+GIhW72ZLQdWKXb1Tl777E0aI4c6g sh1X2rAO7Q09FC24QfIs80jtZ66ASXKqt0vXCvAC2OaJlQKajk/Up/Xqrj5VjHeQo0Bo Polg== X-Gm-Message-State: AOAM531jKgR5o4GX9uCNU0k0cn03aQwPSQcp4HEkLfCXpozxgy6rSv+/ iMqE0zYs0IhmBVRRO35w+Nw/lKW9qGehS0/4znLpVwiirpVmdo8UnF6InRsNs6pVAOj3f8L0xvi 3CRQlbniOrLlDA92Vruvs4RiG X-Received: by 2002:a17:907:7747:: with SMTP id kx7mr31478207ejc.400.1620986247255; Fri, 14 May 2021 02:57:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyrSoRF79fxMuEqrHhj6EHjL5Zsyke7AE/1JPBWbafFqeSeIeeKtVnbLG/x5jm0octAFZwKQQ== X-Received: by 2002:a17:907:7747:: with SMTP id kx7mr31478183ejc.400.1620986247091; Fri, 14 May 2021 02:57:27 -0700 (PDT) Received: from [192.168.3.132] (p5b0c6501.dip0.t-ipconnect.de. [91.12.101.1]) by smtp.gmail.com with ESMTPSA id ju17sm3413760ejc.72.2021.05.14.02.57.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 May 2021 02:57:26 -0700 (PDT) Subject: Re: [PATCH 01/22] mm: Add vma_lookup() To: Liam Howlett , "maple-tree@lists.infradead.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Andrew Morton Cc: Song Liu , Davidlohr Bueso , "Paul E . McKenney" , Matthew Wilcox , Laurent Dufour , David Rientjes , Axel Rasmussen , Suren Baghdasaryan , Vlastimil Babka , Rik van Riel , Peter Zijlstra , Michel Lespinasse References: <20210510165839.2692974-1-Liam.Howlett@Oracle.com> <20210510165839.2692974-2-Liam.Howlett@Oracle.com> From: David Hildenbrand Organization: Red Hat Message-ID: <99e04b50-7210-8a2f-4eda-08747b8570fb@redhat.com> Date: Fri, 14 May 2021 11:57:25 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210510165839.2692974-2-Liam.Howlett@Oracle.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10.05.21 18:58, Liam Howlett wrote: > he third use of find_vma() is by developers who do not know that the > function starts searching at the provided address upwards for the next > vma. This results in a bug that is often overlooked for a long time. > > Adding the new vma_lookup() function will allow for cleaner code by Sounds helpful to me Acked-by: David Hildenbrand -- Thanks, David / dhildenb