From: Neeraj Upadhyay <neeraju@codeaurora.org>
To: paulmck@linux.ibm.com
Cc: josh@joshtriplett.org, rostedt@goodmis.org,
mathieu.desnoyers@efficios.com, jiangshanlai@gmail.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rcu/tree_plugin: Fix nohz status in stall warning
Date: Sat, 9 Mar 2019 09:12:50 +0530 [thread overview]
Message-ID: <99ea3a0a-31b1-be28-418e-a3a80b02260b@codeaurora.org> (raw)
In-Reply-To: <20190308211840.GW13351@linux.ibm.com>
On 3/9/19 2:48 AM, Paul E. McKenney wrote:
> On Fri, Mar 08, 2019 at 11:51:49PM +0530, Neeraj Upadhyay wrote:
>> Fix stall warning, to show correct nohz marker.
>>
>> Signed-off-by: Neeraj Upadhyay <neeraju@codeaurora.org>
>
> Good eyes, thank you!
>
> I applied and pushed all three with modified commit logs. Please check
> to make sure that I didn't mess anything up. If testing and reviews
> are OK, I expect to submit them for the v5.2 merge window.
>
> I had to hand-apply this one, so in future patches could you please
> generate them against -rcu? It may be found here:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git
>
> Thanx, Paul
>
Thanks Paul, I reviewed the patches on -rcu; they look good. Thanks for
applying them! I will move my codebase to -rcu, for all future work.
Thanks
Neeraj
>> ---
>> kernel/rcu/tree_plugin.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/kernel/rcu/tree_plugin.h b/kernel/rcu/tree_plugin.h
>> index 97dba50..93da32c 100644
>> --- a/kernel/rcu/tree_plugin.h
>> +++ b/kernel/rcu/tree_plugin.h
>> @@ -1659,7 +1659,7 @@ static void print_cpu_stall_fast_no_hz(char *cp, int cpu)
>> rdp->last_accelerate & 0xffff, jiffies & 0xffff,
>> ".l"[rdp->all_lazy],
>> ".L"[!rcu_segcblist_n_nonlazy_cbs(&rdp->cblist)],
>> - ".D"[!rdp->tick_nohz_enabled_snap]);
>> + ".D"[!!rdp->tick_nohz_enabled_snap]);
>> }
>>
>> #else /* #ifdef CONFIG_RCU_FAST_NO_HZ */
>> --
>> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a
>> member of the Code Aurora Forum, hosted by The Linux Foundation
>>
>
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a
member of the Code Aurora Forum, hosted by The Linux Foundation
prev parent reply other threads:[~2019-03-09 3:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-08 18:21 [PATCH] rcu/tree_plugin: Fix nohz status in stall warning Neeraj Upadhyay
2019-03-08 21:18 ` Paul E. McKenney
2019-03-09 3:42 ` Neeraj Upadhyay [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99ea3a0a-31b1-be28-418e-a3a80b02260b@codeaurora.org \
--to=neeraju@codeaurora.org \
--cc=jiangshanlai@gmail.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=paulmck@linux.ibm.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).