archive mirror
 help / color / mirror / Atom feed
From: Brijesh Singh <>
To: "Paolo Bonzini" <>,
	"Radim Krčmář" <>
Cc: <>, <>, <>,
	<>, <>,
	<>, <>, <>,
Subject: Re: [PATCH] x86: kvm: Avoid guest page table walk when gpa_available is set
Date: Tue, 2 May 2017 16:44:19 -0500	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Hi Paolo,

>> I've tried the below patch and it seems to work fine. This does not
>> consider
>> PIO case and as you rightly pointed PIO should trigger #NPF relatively
>> rarely.
>> At least so far in my runs I have not seen PIO causing #NPF. If this sounds
>> acceptable approach then I can submit v2 with these changes and remove
>> gpa_val
>> additional.
> PIO can certainly cause #NPF, albeit rarely, so this is not a viable one.

For SEV guest cases, we anyway want to avoid any guest page table walks
(even if it happens rarely). Sounds like we have to depend on gpa_val variable.
I will refresh the patch to address one of Ramdim's feedback
(move vcpu->arch.gpa_val assignment from handle_exit to pf_interception).


      reply	other threads:[~2017-05-02 21:44 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-24 15:52 [PATCH] x86: kvm: Avoid guest page table walk when gpa_available is set Brijesh Singh
2017-04-24 16:16 ` Brijesh Singh
2017-04-24 20:52 ` Radim Krčmář
2017-04-24 22:14   ` Brijesh Singh
2017-04-25 14:03     ` Radim Krčmář
2017-04-25 22:02       ` Brijesh Singh
2017-04-26 20:44         ` Radim Krčmář
2017-04-28 19:15           ` Brijesh Singh
2017-05-02 16:24             ` Paolo Bonzini
2017-05-02 21:44               ` Brijesh Singh [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).