From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752606AbbLRLnj (ORCPT ); Fri, 18 Dec 2015 06:43:39 -0500 Received: from mx-rz-1.rrze.uni-erlangen.de ([131.188.11.20]:58855 "EHLO mx-rz-1.rrze.uni-erlangen.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751780AbbLRLnh (ORCPT ); Fri, 18 Dec 2015 06:43:37 -0500 X-Greylist: delayed 419 seconds by postgrey-1.27 at vger.kernel.org; Fri, 18 Dec 2015 06:43:37 EST X-RRZE-Submit-IP: 131.188.11.38 Message-ID: <99efe3549ef3d0b399b78b2f8f66947c.squirrel@faumail.uni-erlangen.de> In-Reply-To: <1450365401.30729.142.camel@linux.intel.com> References: <1450280177-4460-1-git-send-email-anton.wuerfel@fau.de> <1450280177-4460-9-git-send-email-anton.wuerfel@fau.de> <1450365401.30729.142.camel@linux.intel.com> Date: Fri, 18 Dec 2015 12:36:36 +0100 Subject: Re: [PATCH 08/11] tty: serial: 8250: Add parentheses to macro From: anton.wuerfel@fau.de To: "Andy Shevchenko" Cc: linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org, linux-kernel@i4.cs.fau.de, anton.wuerfel@fau.de, phillip.raffeck@fau.de User-Agent: SquirrelMail/1.4.23 [SVN] MIME-Version: 1.0 Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Andy, > What about the rest of the drivers under drivers/tty/serial? > > What do you propose to do with, for example, the following > > drivers/tty/serial/cpm_uart/cpm_uart_core.c:1392:#define > CPM_UART_CONSOLE       &cpm_scc_uart_console > drivers/tty/serial/cpm_uart/cpm_uart_core.c:1394:#define > CPM_UART_CONSOLE       NULL > >>  #else >>  #define SERIAL8250_CONSOLE NULL >>  #endif > thanks for your reply. Phillip and me are newcomers to kernel development, so we tried to touch as few files as possible and gain some experience in creating patches and communication on LKML. We will consider sending further patches in the future. Regards, Phillip Raffeck Anton Wuerfel > -- > Andy Shevchenko > Intel Finland Oy > >