Re: [PATCH 6/6] dt-bindings: power: supply: qcom,smb2: add bindings for smb2 driver

[Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>]

On 03/04/2022 15:31, Kuldeep Singh wrote:
> On Sun, Apr 03, 2022 at 09:56:25AM +0200, Krzysztof Kozlowski wrote:
>> On 03/04/2022 09:14, Kuldeep Singh wrote:
>>> On Fri, Apr 01, 2022 at 09:26:43PM +0100, Caleb Connolly wrote:
>>>> Add devicetree bindings for the Qualcomm PMI8998/PM660 SMB2 charger
>>>> drivers.
>>>>
>>
>> (...)
>>
>>>
>>>> +    pmic {
>>>> +      #address-cells = <1>;
>>>> +      #size-cells = <0>;
>>>> +      #interrupt-cells = <4>;
>>>> +
>>>> +      smb2@1000 {
>>>> +        compatible = "qcom,pmi8998-smb2";
>>>> +        reg = <0x1000>;
>>>> +
>>>> +        interrupts = <0x2 0x13 0x4 IRQ_TYPE_EDGE_BOTH>;
>>>> +        interrupt-names = "usb-plugin";
>>>> +
>>>
>>> In-between new lines may not be required.
>>> And DTs use tabs instead of 2 spaces, we can follow that here also.
>>
>> The DT examples in bindings use spaces. Either two (like YAML) or four
>> (for easier reading).
> 
> ok, since example snippet is taken from DT that's why I said four
> spaces(tab) as it will be closest to actual env.

You said "use tabs", which is 8 spaces in Linux. So to clarify - we do
not use tabs here, so do not use tabs.

>>>> +        io-channels = <&pmi8998_rradc 3>,
>>>> +                      <&pmi8998_rradc 4>;
>>>> +        io-channel-names = "usbin_i",
>>>> +                           "usbin_v";
>>>
>>> Channel-names can be written in one line.
>>
>> They match the format of io-channels, so this is quite readable.
> 
> io-channels doesn't exceed max characters in line(i.e 75) even after
> being clubbed. Won't be better if kept in one line?
> This might be personal perspective but I thought it's worth mentioning.

I find current code readable. The other option would be fine as well,
kind of does not matter to me much.

Best regards,
Krzysztof