From: Paolo Valente <paolo.valente@linaro.org>
To: Yu Kuai <yukuai3@huawei.com>
Cc: axboe@kernel.dk, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, yi.zhang@huawei.com
Subject: Re: [PATCH v2 0/4] optimize the bfq queue idle judgment
Date: Thu, 26 Aug 2021 18:59:55 +0200 [thread overview]
Message-ID: <9A983576-4EE3-441A-8515-14A819A94B8B@linaro.org> (raw)
In-Reply-To: <20210806020826.1407257-1-yukuai3@huawei.com>
> Il giorno 6 ago 2021, alle ore 04:08, Yu Kuai <yukuai3@huawei.com> ha scritto:
>
> Chagnes in V2:
> - as suggested by Paolo, add support to track if root_group have any
> pending requests, and use that to handle the situation when only one
> group is activated while root group doesn't have any pending requests.
> - modify commit message in patch 2
>
Hi,
sorry for my delay. I've just finished reviewing your new patches.
As I already said, I like the improvement you are making. Now the way
you make it also seems effective to me. I still have a design
concern. You will find it in my detailed comments on your patches.
Thanks
Paolo
> Yu Kuai (4):
> block, bfq: add support to track if root_group have any pending
> requests
> block, bfq: do not idle if only one cgroup is activated
> block, bfq: add support to record request size information
> block, bfq: consider request size in bfq_asymmetric_scenario()
>
> block/bfq-iosched.c | 69 ++++++++++++++++++++++++++++++++++++++-------
> block/bfq-iosched.h | 29 +++++++++++++++++--
> block/bfq-wf2q.c | 37 +++++++++++++++---------
> 3 files changed, 110 insertions(+), 25 deletions(-)
>
> --
> 2.31.1
>
prev parent reply other threads:[~2021-08-26 17:00 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-06 2:08 [PATCH v2 0/4] optimize the bfq queue idle judgment Yu Kuai
2021-08-06 2:08 ` [PATCH v2 1/4] block, bfq: add support to track if root_group have any pending requests Yu Kuai
2021-08-26 17:00 ` Paolo Valente
2021-09-02 13:23 ` yukuai (C)
2021-08-06 2:08 ` [PATCH v2 2/4] block, bfq: do not idle if only one cgroup is activated Yu Kuai
2021-08-26 17:00 ` Paolo Valente
2021-09-02 13:31 ` yukuai (C)
2021-09-07 9:10 ` Paolo Valente
2021-09-07 11:19 ` yukuai (C)
2021-08-06 2:08 ` [PATCH v2 3/4] block, bfq: add support to record request size information Yu Kuai
2021-08-26 17:00 ` Paolo Valente
2021-08-06 2:08 ` [PATCH v2 4/4] block, bfq: consider request size in bfq_asymmetric_scenario() Yu Kuai
2021-08-26 17:00 ` Paolo Valente
2021-09-07 11:29 ` yukuai (C)
2021-09-15 7:36 ` Paolo Valente
2021-09-15 7:47 ` yukuai (C)
2021-08-14 2:34 ` [PATCH v2 0/4] optimize the bfq queue idle judgment yukuai (C)
2021-08-24 14:09 ` yukuai (C)
2021-08-26 16:59 ` Paolo Valente [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9A983576-4EE3-441A-8515-14A819A94B8B@linaro.org \
--to=paolo.valente@linaro.org \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yi.zhang@huawei.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).