From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751623AbcGNTAI (ORCPT ); Thu, 14 Jul 2016 15:00:08 -0400 Received: from mga01.intel.com ([192.55.52.88]:2606 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751119AbcGNTAA convert rfc822-to-8bit (ORCPT ); Thu, 14 Jul 2016 15:00:00 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,364,1464678000"; d="scan'208";a="139337687" From: "Rosen, Rami" To: "Levy, Amir (Jer)" , "Winkler, Tomas" , "andreas.noever@gmail.com" , "gregkh@linuxfoundation.org" , "bhelgaas@google.com" CC: "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" , thunderbolt-linux , "Westerberg, Mika" , "Rosen, Rami" Subject: RE: [PATCH v3 5/8] thunderbolt: Communication with the ICM (firmware) Thread-Topic: [PATCH v3 5/8] thunderbolt: Communication with the ICM (firmware) Thread-Index: AQHR3cO36meifi+u1026NKd1LYcXSaAXrS4AgABYYlCAAAl3gIAAN5Uw Date: Thu, 14 Jul 2016 18:59:54 +0000 Message-ID: <9B0331B6EBBD0E4684FBFAEDA55776F92CD7E6C8@HASMSX110.ger.corp.intel.com> References: <1468495702-7467-1-git-send-email-amir.jer.levy@intel.com> <1468495702-7467-6-git-send-email-amir.jer.levy@intel.com> <5B8DA87D05A7694D9FA63FD143655C1B54294E4A@hasmsx108.ger.corp.intel.com> <9B0331B6EBBD0E4684FBFAEDA55776F92CD7D05F@HASMSX110.ger.corp.intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYmFjMWVkYTMtMmMwNi00OTBjLTllNDYtMTc1MGFjODZjNjM3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IkRUdndvcmpISVVqajY5d2lWYlVieU1FRXVQRjdFMnJMTklhSWcydnl5QU09In0= x-ctpclassification: CTP_IC x-originating-ip: [10.184.70.10] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Amir, >This patch is the communication with the FW. >The network functionality is added in the next patches in the series >and with it, more messages from FW. >Indeed this function always returns true in this patch, >but while writing it, I predicted that the network functionality will >use the send_event flag differently. >You can see the documentation of send_event - currently unused in this patch. >I don't see any harm that in this patch, this function will always return true, >while applying the rest of the series will change it. Ok, seems reasonable. >The prototype of suspend is return int: >http://lxr.free-electrons.com/source/include/linux/pm.h#L295 >The prototype of resume is return int: >http://lxr.free-electrons.com/source/include/linux/pm.h#L295 You are right about this, I missed the macro invocation in your code, SET_SYSTEM_SLEEP_PM_OPS(nhi_suspend, nhi_resume), apologies. Regards, Rami Rosen Intel Corporation