From: "Saleem, Shiraz" <shiraz.saleem@intel.com>
To: "Håkon Bugge" <Haakon.Bugge@oracle.com>,
"Doug Ledford" <dledford@redhat.com>,
"Latif, Faisal" <faisal.latif@intel.com>,
"jgg@ziepe.ca" <jgg@ziepe.ca>
Cc: "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] RDMA/i40iw: Fix incorrect iterator type
Date: Sun, 23 Sep 2018 14:24:12 +0000 [thread overview]
Message-ID: <9DD61F30A802C4429A01CA4200E302A7A2F99554@fmsmsx115.amr.corp.intel.com> (raw)
In-Reply-To: <20180917140707.1253738-1-Haakon.Bugge@oracle.com>
>Subject: [PATCH] RDMA/i40iw: Fix incorrect iterator type
>
>Commit f27b4746f378 ("i40iw: add connection management code") uses an
>incorrect rcu iterator, whilst holding the rtnl_lock. Since the critical region invokes
>i40iw_manage_qhash(), which is a sleeping function, the rcu locking and
>traversal cannot be used.
>
>Signed-off-by: Håkon Bugge <haakon.bugge@oracle.com>
>---
> drivers/infiniband/hw/i40iw/i40iw_cm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks doing this Hakon!
Acked-by: Shiraz Saleem <shiraz.saleem@intel.com>
prev parent reply other threads:[~2018-09-23 14:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-17 14:07 [PATCH] RDMA/i40iw: Fix incorrect iterator type Håkon Bugge
2018-09-19 16:13 ` Jason Gunthorpe
2018-09-23 14:24 ` Saleem, Shiraz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9DD61F30A802C4429A01CA4200E302A7A2F99554@fmsmsx115.amr.corp.intel.com \
--to=shiraz.saleem@intel.com \
--cc=Haakon.Bugge@oracle.com \
--cc=dledford@redhat.com \
--cc=faisal.latif@intel.com \
--cc=jgg@ziepe.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).