From: "Eelco Chaudron" <echaudro@redhat.com>
To: "Ilya Maximets" <i.maximets@samsung.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
bpf@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
"Björn Töpel" <bjorn.topel@intel.com>,
"Magnus Karlsson" <magnus.karlsson@intel.com>,
"Jakub Kicinski" <jakub.kicinski@netronome.com>,
"Alexei Starovoitov" <ast@kernel.org>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"Jeff Kirsher" <jeffrey.t.kirsher@intel.com>,
intel-wired-lan@lists.osuosl.org,
"William Tu" <u9012063@gmail.com>
Subject: Re: [PATCH net] ixgbe: fix double clean of tx descriptors with xdp
Date: Wed, 21 Aug 2019 12:09:06 +0200 [thread overview]
Message-ID: <9EFD9B47-2CD0-4D7A-BA22-D87018894E91@redhat.com> (raw)
In-Reply-To: <20190820151611.10727-1-i.maximets@samsung.com>
On 20 Aug 2019, at 17:16, Ilya Maximets wrote:
> Tx code doesn't clear the descriptor status after cleaning.
> So, if the budget is larger than number of used elems in a ring, some
> descriptors will be accounted twice and xsk_umem_complete_tx will move
> prod_tail far beyond the prod_head breaking the comletion queue ring.
>
> Fix that by limiting the number of descriptors to clean by the number
> of used descriptors in the tx ring.
>
> Fixes: 8221c5eba8c1 ("ixgbe: add AF_XDP zero-copy Tx support")
> Signed-off-by: Ilya Maximets <i.maximets@samsung.com>
> ---
>
> Not tested yet because of lack of available hardware.
> So, testing is very welcome.
>
Hi Ilya, this patch fixes the issue I reported earlier on the Open
vSwitch mailing list regarding complete queue overrun.
Tested-by: Eelco Chaudron <echaudro@redhat.com>
<SNIP>
prev parent reply other threads:[~2019-08-21 10:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20190820151644eucas1p179d6d1da42bb6be0aad8f58ac46624ce@eucas1p1.samsung.com>
2019-08-20 15:16 ` [PATCH net] ixgbe: fix double clean of tx descriptors with xdp Ilya Maximets
2019-08-20 15:35 ` Alexander Duyck
2019-08-20 15:58 ` Ilya Maximets
2019-08-21 1:17 ` Alexander Duyck
2019-08-21 16:21 ` Ilya Maximets
2019-08-21 16:57 ` Alexander Duyck
2019-08-21 21:38 ` William Tu
2019-08-22 8:17 ` Ilya Maximets
2019-08-22 16:07 ` William Tu
2019-08-22 16:30 ` Ilya Maximets
2019-08-22 7:12 ` [Intel-wired-lan] " Björn Töpel
2019-08-22 8:05 ` Ilya Maximets
2019-08-22 7:10 ` Björn Töpel
2019-08-21 10:09 ` Eelco Chaudron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9EFD9B47-2CD0-4D7A-BA22-D87018894E91@redhat.com \
--to=echaudro@redhat.com \
--cc=ast@kernel.org \
--cc=bjorn.topel@intel.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=i.maximets@samsung.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jakub.kicinski@netronome.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
--cc=u9012063@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).