From: Yoder Stuart-B08248 <B08248@freescale.com>
To: Alex Williamson <alex.williamson@redhat.com>,
Sethi Varun-B16395 <B16395@freescale.com>
Cc: Joerg Roedel <joro@8bytes.org>,
Wood Scott-B07421 <B07421@freescale.com>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"galak@kernel.crashing.org" <galak@kernel.crashing.org>,
"benh@kernel.crashing.org" <benh@kernel.crashing.org>
Subject: RE: [PATCH 5/5 v11] iommu/fsl: Freescale PAMU driver and iommu implementation.
Date: Thu, 4 Apr 2013 16:43:03 +0000 [thread overview]
Message-ID: <9F6FE96B71CF29479FF1CDC8046E15035A26DD@039-SN1MPN1-003.039d.mgd.msft.net> (raw)
In-Reply-To: <1365088930.2882.296.camel@bling.home>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 4100 bytes --]
> -----Original Message-----
> From: Alex Williamson [mailto:alex.williamson@redhat.com]
> Sent: Thursday, April 04, 2013 10:22 AM
> To: Sethi Varun-B16395
> Cc: Joerg Roedel; Yoder Stuart-B08248; Wood Scott-B07421; iommu@lists.linux-foundation.org; linuxppc-
> dev@lists.ozlabs.org; linux-kernel@vger.kernel.org; galak@kernel.crashing.org; benh@kernel.crashing.org
> Subject: Re: [PATCH 5/5 v11] iommu/fsl: Freescale PAMU driver and iommu implementation.
>
> On Thu, 2013-04-04 at 13:00 +0000, Sethi Varun-B16395 wrote:
> >
> > > -----Original Message-----
> > > From: Alex Williamson [mailto:alex.williamson@redhat.com]
> > > Sent: Wednesday, April 03, 2013 11:32 PM
> > > To: Joerg Roedel
> > > Cc: Sethi Varun-B16395; Yoder Stuart-B08248; Wood Scott-B07421;
> > > iommu@lists.linux-foundation.org; linuxppc-dev@lists.ozlabs.org; linux-
> > > kernel@vger.kernel.org; galak@kernel.crashing.org;
> > > benh@kernel.crashing.org
> > > Subject: Re: [PATCH 5/5 v11] iommu/fsl: Freescale PAMU driver and iommu
> > > implementation.
> > >
> > > On Tue, 2013-04-02 at 18:18 +0200, Joerg Roedel wrote:
> > > > Cc'ing Alex Williamson
> > > >
> > > > Alex, can you please review the iommu-group part of this patch?
> > >
> > > Sure, it looks pretty reasonable. AIUI, all PCI devices are below some
> > > kind of host bridge that is either new and supports partitioning or old
> > > and doesn't. I don't know if that's a visibility or isolation
> > > requirement, perhaps PCI ACS-ish. In the new host bridge case, each
> > > device gets a group. This seems not to have any quirks for multifunction
> > > devices though. On AMD and Intel IOMMUs we test multifunction device ACS
> > > support to determine whether all the functions should be in the same
> > > group. Is there any reason to trust multifunction devices on PAMU?
> > >
> > [Sethi Varun-B16395] In the case where we can partition endpoints we
> > can distinguish transactions based on the bus,device,function number
> > combination. This support is available in the PCIe controller (host
> > bridge).
>
> So can x86 IOMMUs, that's the visibility aspect of IOMMU groups.
> Visibility alone doesn't necessarily imply that a device is isolated
> though. A multifunction PCI device that doesn't expose ACS support may
> not isolate functions from each other. For example a peer-to-peer DMA
> between functions may not be translated by the upstream IOMMU. IOMMU
> groups should encompass both visibility and isolation.
>
> > > I also find it curious what happens to the iommu group of the host
> > > bridge. In the partitionable case the host bridge group is removed, in
> > > the non-partitionable case the host bridge group becomes the group for
> > > the children, removing the host bridge. It's unique to PAMU so far that
> > > these host bridges are even in an iommu group (x86 only adds pci
> > > devices), but I don't see it as necessarily wrong leaving it in either
> > > scenario. Does it solve some problem to remove them from the groups?
> > > Thanks,
> > [Sethi Varun-B16395] The PCIe controller isn't a partitionable entity,
> > it would always be owned by the host.
>
> Ownership of a device shouldn't play into the group context. An IOMMU
> group should be defined by it's visibility and isolation from other
> devices. Whether the PCIe controller is allowed to be handed to
> userspace is a question for VFIO. Thanks,
Right now the add_device() callback gets called for all platform
devices (including PCI controller) and PCI devices. PCI controllers
are a kind of special case in that their device tree node has a
property indicating that it is DMA capable...but in fact the
PCI controller itself does not DMA, but it's the PCI endpoints
under it.
So, as you noted the bridge/controller shouldn't be in an IOMMU
group and so since the platform 'add device' code didn't special
case PCI controllers, this patch removes their group if it's there.
Stuart
ÿôèº{.nÇ+·®+%Ëÿ±éݶ\x17¥wÿº{.nÇ+·¥{±þG«éÿ{ayº\x1dÊÚë,j\a¢f£¢·hïêÿêçz_è®\x03(éÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?¨èÚ&£ø§~á¶iOæ¬z·vØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?I¥
next prev parent reply other threads:[~2013-04-04 16:43 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-28 19:53 [PATCH 0/5 v11] iommu/fsl: Freescale PAMU driver and IOMMU API implementation Varun Sethi
2013-03-28 19:53 ` [PATCH 1/5 v11] iommu/fsl: Make iova dma_addr_t in the iommu_iova_to_phys API Varun Sethi
2013-03-28 19:53 ` [PATCH 2/5 v11] powerpc: Add iommu domain pointer to device archdata Varun Sethi
2013-04-02 15:08 ` Joerg Roedel
2013-04-03 5:17 ` Sethi Varun-B16395
2013-04-11 18:16 ` Kumar Gala
2013-06-20 14:29 ` Sethi Varun-B16395
2013-06-20 14:41 ` joro
2013-03-28 19:54 ` [PATCH 3/5 v11] iommu/fsl: Add the window permission flag as a parameter to iommu_window_enable API Varun Sethi
2013-03-28 19:54 ` [PATCH 4/5 v11] iommu/fsl: Add additional iommu attributes required by the PAMU driver Varun Sethi
2013-04-02 15:10 ` Joerg Roedel
2013-04-03 5:21 ` Sethi Varun-B16395
2013-04-03 8:08 ` Joerg Roedel
2013-03-28 19:54 ` [PATCH 5/5 v11] iommu/fsl: Freescale PAMU driver and iommu implementation Varun Sethi
2013-04-02 15:29 ` Yoder Stuart-B08248
2013-04-02 16:18 ` Joerg Roedel
2013-04-03 1:35 ` Timur Tabi
2013-04-03 1:52 ` Scott Wood
2013-04-03 5:12 ` Sethi Varun-B16395
2013-04-03 15:55 ` Yoder Stuart-B08248
2013-04-03 7:01 ` Sethi Varun-B16395
2013-04-03 18:01 ` Alex Williamson
2013-04-04 13:00 ` Sethi Varun-B16395
2013-04-04 15:22 ` Alex Williamson
2013-04-04 16:35 ` Sethi Varun-B16395
2013-04-04 16:43 ` Alex Williamson
2013-04-05 0:01 ` Sethi Varun-B16395
2013-04-04 16:43 ` Yoder Stuart-B08248 [this message]
2013-04-02 16:23 ` [PATCH 0/5 v11] iommu/fsl: Freescale PAMU driver and IOMMU API implementation Joerg Roedel
2013-04-02 17:50 ` Sethi Varun-B16395
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9F6FE96B71CF29479FF1CDC8046E15035A26DD@039-SN1MPN1-003.039d.mgd.msft.net \
--to=b08248@freescale.com \
--cc=B07421@freescale.com \
--cc=B16395@freescale.com \
--cc=alex.williamson@redhat.com \
--cc=benh@kernel.crashing.org \
--cc=galak@kernel.crashing.org \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).