From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E78FC61DA7 for ; Sat, 28 Jan 2023 13:30:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233632AbjA1NaY (ORCPT ); Sat, 28 Jan 2023 08:30:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35114 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230103AbjA1NaU (ORCPT ); Sat, 28 Jan 2023 08:30:20 -0500 X-Greylist: delayed 138 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Sat, 28 Jan 2023 05:30:20 PST Received: from proxima.lasnet.de (proxima.lasnet.de [IPv6:2a01:4f8:121:31eb:3::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0D75D20057; Sat, 28 Jan 2023 05:30:19 -0800 (PST) Received: from [192.168.2.51] (p4fe71212.dip0.t-ipconnect.de [79.231.18.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: stefan@datenfreihafen.org) by proxima.lasnet.de (Postfix) with ESMTPSA id 2F8D6C0B7D; Sat, 28 Jan 2023 14:30:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=datenfreihafen.org; s=2021; t=1674912618; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4mdqGqv2BgX/GxZf2yMkOIhITBqaR1xv+UfObZcYJAs=; b=twtC5u5k+Pj4DFgTKWHmW9bdmhMXmQ8fk/rOLBSpwcvKYidnvVgJQWW//Yjbz45CWrPH5A 8qxvoYAj4qPN3jxWhvJz191zgQ3fMWIyLBgDCMabO37zCFezW/zhA0icA1TxQ8hWX1oPqV lDJBdVpnyCuvozVxlJJVaaBDFsAeelpNdBbJknpkxLuEwLozDOqLtdVidYGzSUoDFthjNM Cq+jgmbbTcUuIfMjutRfZi3n95jK5XHbyYEEN6hiAqen5uqb5K5yXB07tGjHYKtRMUfnSi +pXMVkt/EqFtQRYUnAyXN/ul1v9h196q0pUk2b4AlLGhshr1NMvxYInmEBdLDA== Message-ID: <9a09a41b-1eb9-edc9-28ad-acb920e04ae4@datenfreihafen.org> Date: Sat, 28 Jan 2023 14:30:17 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH] ca8210: move to gpio descriptors Content-Language: en-US To: Arnd Bergmann , Arnd Bergmann , Alexander Aring Cc: "open list:GPIO SUBSYSTEM" , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Hauke Mehrtens , linux-wpan@vger.kernel.org, Netdev , linux-kernel@vger.kernel.org References: <20230126161737.2985704-1-arnd@kernel.org> <57e74219-d439-4d10-9bb5-53fe7b30b46f@app.fastmail.com> From: Stefan Schmidt In-Reply-To: <57e74219-d439-4d10-9bb5-53fe7b30b46f@app.fastmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Arnd. On 26.01.23 17:25, Arnd Bergmann wrote: > On Thu, Jan 26, 2023, at 17:17, Arnd Bergmann wrote: > >> if (ret) { >> - dev_crit(&spi->dev, "request_irq %d failed\n", pdata->irq_id); >> - gpiod_unexport(gpio_to_desc(pdata->gpio_irq)); >> - gpio_free(pdata->gpio_irq); >> + dev_crit(&spi->dev, "request_irq %d failed\n", priv->irq_id); >> + gpiod_put(priv->gpio_irq); >> } > > I just realized that this bit depends on the "gpiolib: remove > legacy gpio_export" patch I sent to the gpio mailing list earlier. > > We can probably just defer this change until that is merged, > or alternatively I can rebase this patch to avoid the > dependency. Deferring the change until i picked it up from Linus or net-next in my tree is fine. This driver is not heavily worked on (its actually marked as orphaned) so the patch should still apply in a few days. I will keep it in my patchwork queue of patches to be applied. No extra work needed from your side. regards Stefan Schmidt