From: linmiaohe <linmiaohe@huawei.com>
To: "maz@kernel.org" <maz@kernel.org>,
"james.morse@arm.com" <james.morse@arm.com>,
"julien.thierry.kdev@gmail.com" <julien.thierry.kdev@gmail.com>,
"suzuki.poulose@arm.com" <suzuki.poulose@arm.com>,
"christoffer.dall@arm.com" <christoffer.dall@arm.com>,
"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
"eric.auger@redhat.com" <eric.auger@redhat.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"will@kernel.org" <will@kernel.org>,
"andre.przywara@arm.com" <andre.przywara@arm.com>,
"tglx@linutronix.de" <tglx@linutronix.de>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Re: [PATCH] KVM: arm/arm64: Fix some obsolete comments
Date: Thu, 16 Jan 2020 02:01:27 +0000 [thread overview]
Message-ID: <9a12f0f18f37418e921afede5f6e3645@huawei.com> (raw)
friendly ping. :)
> From: Miaohe Lin <linmiaohe@huawei.com>
>
> Fix various comments, including comment typo, and obsolete comments no longer make sense.
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> ---
> virt/kvm/arm/arch_timer.c | 5 ++---
> virt/kvm/arm/arm.c | 1 -
> virt/kvm/arm/vgic/vgic-its.c | 2 +-
> 3 files changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/virt/kvm/arm/arch_timer.c b/virt/kvm/arm/arch_timer.c index 73867f97040c..d8d2f4bec935 100644
> --- a/virt/kvm/arm/arch_timer.c
> +++ b/virt/kvm/arm/arch_timer.c
> @@ -322,9 +322,8 @@ static void timer_emulate(struct arch_timer_context *ctx)
> }
>
> /*
> - * If the timer can fire now, we don't need to have a soft timer
> - * scheduled for the future. If the timer cannot fire at all,
> - * then we also don't need a soft timer.
> + * If the timer cannot fire at all, we don't need to have a
> + * soft timer scheduled for the future.
> */
> if (!kvm_timer_irq_can_fire(ctx)) {
> soft_timer_cancel(&ctx->hrtimer);
> diff --git a/virt/kvm/arm/arm.c b/virt/kvm/arm/arm.c index 8de4daf25097..7687663ab71b 100644
> --- a/virt/kvm/arm/arm.c
> +++ b/virt/kvm/arm/arm.c
> @@ -525,7 +525,6 @@ static bool need_new_vmid_gen(struct kvm_vmid *vmid)
>
> /**
> * update_vmid - Update the vmid with a valid VMID for the current generation
> - * @kvm: The guest that struct vmid belongs to
> * @vmid: The stage-2 VMID information struct
> */
> static void update_vmid(struct kvm_vmid *vmid) diff --git a/virt/kvm/arm/vgic/vgic-its.c b/virt/kvm/arm/vgic/vgic-its.c index 98c7360d9fb7..d64569b30b5c 100644
> --- a/virt/kvm/arm/vgic/vgic-its.c
> +++ b/virt/kvm/arm/vgic/vgic-its.c
> @@ -2564,7 +2564,7 @@ static int vgic_its_restore_collection_table(struct vgic_its *its) }
>
> /**
> - * vgic_its_save_tables_v0 - Save the ITS tables into guest ARM
> + * vgic_its_save_tables_v0 - Save the ITS tables into guest RAM
> * according to v0 ABI
> */
> static int vgic_its_save_tables_v0(struct vgic_its *its)
> --
> 2.19.1
>
next reply other threads:[~2020-01-16 2:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-16 2:01 linmiaohe [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-11-29 3:19 [PATCH] KVM: arm/arm64: Fix some obsolete comments linmiaohe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a12f0f18f37418e921afede5f6e3645@huawei.com \
--to=linmiaohe@huawei.com \
--cc=andre.przywara@arm.com \
--cc=catalin.marinas@arm.com \
--cc=christoffer.dall@arm.com \
--cc=eric.auger@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=james.morse@arm.com \
--cc=julien.thierry.kdev@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=suzuki.poulose@arm.com \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).