From: Juergen Gross <jgross@suse.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Arnd Bergmann <arnd@arndb.de>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>,
Paul Durrant <paul.durrant@citrix.com>,
linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org
Subject: Re: [PATCH] [v2] xen: avoid link error on ARM
Date: Tue, 5 Mar 2019 15:57:44 +0100 [thread overview]
Message-ID: <9a285a75-b9ea-37a9-b5bd-ba2a068dd944@suse.com> (raw)
In-Reply-To: <35654e1a-d066-0581-749f-7e3b65023988@oracle.com>
On 05/03/2019 14:43, Boris Ostrovsky wrote:
> On 3/5/19 8:30 AM, Arnd Bergmann wrote:
>>
>> diff --git a/drivers/xen/privcmd.c b/drivers/xen/privcmd.c
>> index b24ddac1604b..290b6aca7e1d 100644
>> --- a/drivers/xen/privcmd.c
>> +++ b/drivers/xen/privcmd.c
>> @@ -723,26 +723,6 @@ static long privcmd_ioctl_restrict(struct file *file, void __user *udata)
>> return 0;
>> }
>>
>> -struct remap_pfn {
>> - struct mm_struct *mm;
>> - struct page **pages;
>> - pgprot_t prot;
>> - unsigned long i;
>> -};
>> -
>> -static int remap_pfn_fn(pte_t *ptep, pgtable_t token, unsigned long addr,
>> - void *data)
>> -{
>> - struct remap_pfn *r = data;
>> - struct page *page = r->pages[r->i];
>> - pte_t pte = pte_mkspecial(pfn_pte(page_to_pfn(page), r->prot));
>> -
>> - set_pte_at(r->mm, addr, ptep, pte);
>> - r->i++;
>> -
>> - return 0;
>> -}
>> -
>> static long privcmd_ioctl_mmap_resource(struct file *file, void __user *udata)
>> {
>> struct privcmd_data *data = file->private_data;
>> @@ -809,15 +789,7 @@ static long privcmd_ioctl_mmap_resource(struct file *file, void __user *udata)
>> goto out;
>>
>> if (xen_feature(XENFEAT_auto_translated_physmap)) {
>> - struct remap_pfn r = {
>> - .mm = vma->vm_mm,
>> - .pages = vma->vm_private_data,
>> - .prot = vma->vm_page_prot,
>> - };
>> -
>> - rc = apply_to_page_range(r.mm, kdata.addr,
>> - kdata.num << PAGE_SHIFT,
>> - remap_pfn_fn, &r);
>> + rc = xen_remap_vma_range(vma, kdata.addr, kdata.num << PAGE_SHIFT);
>
> I wonder whether drivers/xen/xlate_mmu.c might be a good place for these
> routines.
Hmm, probably. This would require a stub in the header to avoid
problems in case of CONFIG_XEN_AUTO_XLATE not defined, though
(the #ifdef is already there).
I think this is the cleanest solution.
Juergen
next prev parent reply other threads:[~2019-03-05 14:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-05 13:30 [PATCH] [v2] xen: avoid link error on ARM Arnd Bergmann
2019-03-05 13:35 ` Juergen Gross
2019-03-05 13:43 ` Boris Ostrovsky
2019-03-05 14:57 ` Juergen Gross [this message]
2019-03-05 16:49 ` Arnd Bergmann
2019-03-05 16:56 ` Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a285a75-b9ea-37a9-b5bd-ba2a068dd944@suse.com \
--to=jgross@suse.com \
--cc=arnd@arndb.de \
--cc=boris.ostrovsky@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleksandr_andrushchenko@epam.com \
--cc=paul.durrant@citrix.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).