From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750983AbdHLFrw (ORCPT ); Sat, 12 Aug 2017 01:47:52 -0400 Received: from lelnx194.ext.ti.com ([198.47.27.80]:22350 "EHLO lelnx194.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750778AbdHLFru (ORCPT ); Sat, 12 Aug 2017 01:47:50 -0400 Subject: Re: [PATCH 1/6] dt-bindings: ti,edma: Add 66AK2G specific information To: Rob Herring CC: Santosh Shilimkar , Linux ARM Mailing List , , Device Tree Mailing List , Tero Kristo , Sekhar Nori , Peter Ujfalusi , Keerthy References: <20170801044119.16201-1-lokeshvutla@ti.com> <20170801044119.16201-2-lokeshvutla@ti.com> <20170810000034.vvcdvdez3og6lhux@rob-hp-laptop> From: Lokesh Vutla Message-ID: <9a2a0a3d-cc6a-d672-ed38-bef406635d3c@ti.com> Date: Sat, 12 Aug 2017 11:13:24 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170810000034.vvcdvdez3og6lhux@rob-hp-laptop> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 10 August 2017 05:30 AM, Rob Herring wrote: > On Tue, Aug 01, 2017 at 10:11:14AM +0530, Lokesh Vutla wrote: >> Update ti,edma binding documentation to reflect 66AK2G specific >> properties. >> >> Signed-off-by: Lokesh Vutla >> --- >> Documentation/devicetree/bindings/dma/ti-edma.txt | 95 +++++++++++++++++++++-- >> 1 file changed, 90 insertions(+), 5 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/dma/ti-edma.txt b/Documentation/devicetree/bindings/dma/ti-edma.txt >> index 18090e7226b4..05fe2931d025 100644 >> --- a/Documentation/devicetree/bindings/dma/ti-edma.txt >> +++ b/Documentation/devicetree/bindings/dma/ti-edma.txt >> @@ -9,7 +9,12 @@ execute the actual DMA tansfer. >> eDMA3 Channel Controller >> >> Required properties: >> -- compatible: "ti,edma3-tpcc" for the channel controller(s) >> +-------------------- >> +- compatible: Should be: >> + - "ti,edma3-tpcc" for the channel controller(s) on OMAP, >> + AM33xx and AM43xx SoCs. >> + - "ti,k2g-edma3-tpcc", "ti,edma3-tpcc" for the > > If power-domains is mandatory, I don't think the fallback is > appropriate. Or do you expect it to work if the driver ignores the power > domain? power-domains is required for pm_runtime_*() apis to work on 66AK2G. Driver doesn't handle this property separately. Driver still works with "ti,edma3-tpcc" compatible. Thanks and regards, Lokesh