From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Sam Protsenko <semen.protsenko@linaro.org>,
Rob Herring <robh+dt@kernel.org>, Mark Brown <broonie@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jaewon Kim <jaewon02.kim@samsung.com>,
Chanho Park <chanho61.park@samsung.com>,
David Virag <virag.david003@gmail.com>,
Youngmin Nam <youngmin.nam@samsung.com>,
devicetree@vger.kernel.org, linux-spi@vger.kernel.org,
linux-serial@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-i2c@vger.kernel.org
Subject: Re: [PATCH 5/8] tty: serial: samsung: Enable console as module
Date: Mon, 29 Nov 2021 09:52:15 +0100 [thread overview]
Message-ID: <9a51b37b-d2c4-fb73-bd3f-447c94a66c82@canonical.com> (raw)
In-Reply-To: <20211127223253.19098-6-semen.protsenko@linaro.org>
On 27/11/2021 23:32, Sam Protsenko wrote:
> Enable serial driver to be built as a module. To do so, init the console
> support on driver/module load instead of using console_initcall().
>
> This is needed for proper support of USIv2 driver (which can be built as
> a module, which in turn makes SERIAL_SAMSUNG be a module too). It also
> might be useful for Android GKI modularization efforts.
>
> Inspired by commit 87a0b9f98ac5 ("tty: serial: meson: enable console as
> module").
>
> Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
> ---
> drivers/tty/serial/Kconfig | 2 +-
> drivers/tty/serial/samsung_tty.c | 21 +++++++++++++++++++--
> 2 files changed, 20 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
> index fc543ac97c13..0e5ccb25bdb1 100644
> --- a/drivers/tty/serial/Kconfig
> +++ b/drivers/tty/serial/Kconfig
> @@ -263,7 +263,7 @@ config SERIAL_SAMSUNG_UARTS
>
> config SERIAL_SAMSUNG_CONSOLE
> bool "Support for console on Samsung SoC serial port"
> - depends on SERIAL_SAMSUNG=y
> + depends on SERIAL_SAMSUNG
> select SERIAL_CORE_CONSOLE
> select SERIAL_EARLYCON
> help
> diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c
> index f986a9253dc8..92a63e9392ed 100644
> --- a/drivers/tty/serial/samsung_tty.c
> +++ b/drivers/tty/serial/samsung_tty.c
> @@ -1720,10 +1720,10 @@ static int __init s3c24xx_serial_console_init(void)
> register_console(&s3c24xx_serial_console);
> return 0;
> }
> -console_initcall(s3c24xx_serial_console_init);
>
> #define S3C24XX_SERIAL_CONSOLE &s3c24xx_serial_console
> #else
> +static inline int s3c24xx_serial_console_init(void) { return 0; }
> #define S3C24XX_SERIAL_CONSOLE NULL
> #endif
>
> @@ -2898,7 +2898,24 @@ static struct platform_driver samsung_serial_driver = {
> },
> };
>
> -module_platform_driver(samsung_serial_driver);
> +static int __init samsung_serial_init(void)
> +{
> + int ret;
> +
> + ret = s3c24xx_serial_console_init();
> + if (ret)
> + return ret;
This will trigger warns on module re-loading, won't it? Either suppress
unbind or cleanup in module exit.
> +
> + return platform_driver_register(&samsung_serial_driver);
> +}
> +
> +static void __exit samsung_serial_exit(void)
> +{
> + platform_driver_unregister(&samsung_serial_driver);
> +}
> +
> +module_init(samsung_serial_init);
> +module_exit(samsung_serial_exit);
>
> #ifdef CONFIG_SERIAL_SAMSUNG_CONSOLE
> /*
>
Best regards,
Krzysztof
next prev parent reply other threads:[~2021-11-29 8:54 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-27 22:32 [PATCH 0/8] soc: samsung: Add USIv2 driver Sam Protsenko
2021-11-27 22:32 ` [PATCH 1/8] dt-bindings: soc: samsung: Add Exynos USIv2 bindings Sam Protsenko
2021-11-27 22:32 ` [PATCH 2/8] dt-bindings: soc: samsung: Add Exynos USIv2 bindings doc Sam Protsenko
2021-11-29 8:33 ` Krzysztof Kozlowski
2021-11-27 22:32 ` [PATCH 3/8] soc: samsung: Add USIv2 driver Sam Protsenko
2021-11-29 8:49 ` Krzysztof Kozlowski
2021-11-27 22:32 ` [PATCH 4/8] tty: serial: samsung: Remove USI initialization Sam Protsenko
2021-11-28 14:28 ` Greg Kroah-Hartman
2021-11-28 16:26 ` Sam Protsenko
2021-11-28 17:03 ` Sam Protsenko
2021-11-27 22:32 ` [PATCH 5/8] tty: serial: samsung: Enable console as module Sam Protsenko
2021-11-29 8:52 ` Krzysztof Kozlowski [this message]
2021-11-29 20:18 ` Sam Protsenko
2021-11-29 20:38 ` Sam Protsenko
2021-11-27 22:32 ` [PATCH 6/8] tty: serial: Make SERIAL_SAMSUNG=y impossible when EXYNOS_USI_V2=m Sam Protsenko
2021-11-28 14:27 ` Greg Kroah-Hartman
2021-11-28 23:54 ` Sam Protsenko
2021-11-27 22:32 ` [PATCH 7/8] i2c: Make I2C_EXYNOS5=y " Sam Protsenko
2021-11-29 0:02 ` Sam Protsenko
2021-11-27 22:32 ` [PATCH 8/8] spi: Make SPI_S3C64XX=y " Sam Protsenko
2021-11-29 0:02 ` Sam Protsenko
2021-11-28 3:15 ` [PATCH 0/8] soc: samsung: Add USIv2 driver David Virag
2021-11-29 9:02 ` Krzysztof Kozlowski
2021-11-29 13:56 ` Sam Protsenko
2021-11-29 17:35 ` Krzysztof Kozlowski
2021-11-29 19:19 ` David Virag
2021-11-30 0:01 ` Sam Protsenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a51b37b-d2c4-fb73-bd3f-447c94a66c82@canonical.com \
--to=krzysztof.kozlowski@canonical.com \
--cc=broonie@kernel.org \
--cc=chanho61.park@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jaewon02.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=semen.protsenko@linaro.org \
--cc=virag.david003@gmail.com \
--cc=youngmin.nam@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).