linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vlastimil Babka <vbabka@suse.cz>
To: Roman Gushchin <roman.gushchin@linux.dev>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
	Johannes Weiner <hannes@cmpxchg.org>,
	Michal Hocko <mhocko@kernel.org>,
	Shakeel Butt <shakeelb@google.com>,
	Muchun Song <muchun.song@linux.dev>,
	Dennis Zhou <dennis@kernel.org>,
	David Rientjes <rientjes@google.com>,
	Naresh Kamboju <naresh.kamboju@linaro.org>
Subject: Re: [PATCH v5 6/6] mm: kmem: reimplement get_obj_cgroup_from_current()
Date: Fri, 20 Oct 2023 07:41:22 +0200	[thread overview]
Message-ID: <9a5a8167-488b-3819-8aa5-ddd5bd5bacc2@suse.cz> (raw)
In-Reply-To: <20231019225346.1822282-7-roman.gushchin@linux.dev>

On 10/20/23 00:53, Roman Gushchin wrote:
> Reimplement get_obj_cgroup_from_current() using current_obj_cgroup().
> get_obj_cgroup_from_current() and current_obj_cgroup() share 80% of
> the code, so the new implementation is almost trivial.

Great.

> get_obj_cgroup_from_current() is a convenient function used by the
> bpf subsystem, so there is no reason to get rid of it completely.
> 
> Signed-off-by: Roman Gushchin (Cruise) <roman.gushchin@linux.dev>

Reviwed-by: Vlastimil Babka <vbabka@suse.cz>

Thanks!


  reply	other threads:[~2023-10-20  5:41 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-19 22:53 [PATCH v5 0/6] mm: improve performance of accounted kernel memory allocations Roman Gushchin
2023-10-19 22:53 ` [PATCH v5 1/6] mm: kmem: optimize get_obj_cgroup_from_current() Roman Gushchin
2023-10-19 22:53 ` [PATCH v5 2/6] mm: kmem: add direct objcg pointer to task_struct Roman Gushchin
2023-10-20  5:33   ` Vlastimil Babka
2023-10-19 22:53 ` [PATCH v5 3/6] mm: kmem: make memcg keep a reference to the original objcg Roman Gushchin
2023-10-19 22:53 ` [PATCH v5 4/6] mm: kmem: scoped objcg protection Roman Gushchin
2023-10-19 22:53 ` [PATCH v5 5/6] percpu: " Roman Gushchin
2023-10-19 22:53 ` [PATCH v5 6/6] mm: kmem: reimplement get_obj_cgroup_from_current() Roman Gushchin
2023-10-20  5:41   ` Vlastimil Babka [this message]
2023-10-20  6:31   ` Shakeel Butt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9a5a8167-488b-3819-8aa5-ddd5bd5bacc2@suse.cz \
    --to=vbabka@suse.cz \
    --cc=akpm@linux-foundation.org \
    --cc=cgroups@vger.kernel.org \
    --cc=dennis@kernel.org \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhocko@kernel.org \
    --cc=muchun.song@linux.dev \
    --cc=naresh.kamboju@linaro.org \
    --cc=rientjes@google.com \
    --cc=roman.gushchin@linux.dev \
    --cc=shakeelb@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).