From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-29.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1CCDC433E0 for ; Tue, 16 Mar 2021 13:22:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8537F64FE4 for ; Tue, 16 Mar 2021 13:22:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234847AbhCPNVp (ORCPT ); Tue, 16 Mar 2021 09:21:45 -0400 Received: from linux.microsoft.com ([13.77.154.182]:41564 "EHLO linux.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234806AbhCPNVJ (ORCPT ); Tue, 16 Mar 2021 09:21:09 -0400 Received: from [192.168.0.114] (unknown [49.207.206.253]) by linux.microsoft.com (Postfix) with ESMTPSA id A6A77209C340; Tue, 16 Mar 2021 06:21:06 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com A6A77209C340 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1615900868; bh=/HhHLcw0Zaoz9msZE8YkI9qb0aU2DiNbyWd7BALqXzA=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=iQrv1KyJeecpIb05+awvMxMnR+XoFPneksxyu8fUntwlZ/IRWv0gAnLQdrcbNEY16 hkhHwZBr2s1TANs7Oph/B54BYoronwOzr7WDCsFlNe4wFnzzdWFSXTmwGStBBwJrfj SD6ij9tigA6dsvVHO4PhiOfBwTsKBadyltVJTNFA= Subject: Re: [PATCH v2 1/2] optee: fix tee out of memory failure seen during kexec reboot To: Jens Wiklander , Allen Pais Cc: zajec5@gmail.com, bcm-kernel-feedback-list@broadcom.com, Linux ARM , Linux Kernel Mailing List , op-tee@lists.trustedfirmware.org References: <20210225090610.242623-1-allen.lkml@gmail.com> <20210225090610.242623-2-allen.lkml@gmail.com> From: Allen Pais Message-ID: <9a6c017c-d156-f939-f907-d6dfe83c41ac@linux.microsoft.com> Date: Tue, 16 Mar 2021 18:51:03 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> >> [ 0.368428] tee_bnxt_fw optee-clnt0: tee_shm_alloc failed >> [ 0.368461] tee_bnxt_fw: probe of optee-clnt0 failed with error -22 >> >> tee_shm_release() is not invoked on dma shm buffer. >> >> Implement .shutdown() method to handle the release of the buffers >> correctly. >> >> More info: >> https://github.com/OP-TEE/optee_os/issues/3637 >> >> Signed-off-by: Allen Pais >> --- >> drivers/tee/optee/core.c | 20 ++++++++++++++++++++ >> 1 file changed, 20 insertions(+) > > This looks good to me. Do you have a practical way of testing this on > QEMU for instance? > Jens, I could not reproduce nor create a setup using QEMU, I could only do it on a real h/w. I have extensively tested the fix and I don't see any issues. Thanks.