From: Adrian Hunter <adrian.hunter@intel.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: "Tomáš Trnka" <trnka@scm.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
"Peter Zijlstra" <peterz@infradead.org>,
"Ingo Molnar" <mingo@redhat.com>
Subject: Re: perf top -p broken for multithreaded processes since 5.19
Date: Sat, 3 Sep 2022 20:35:09 +0300 [thread overview]
Message-ID: <9a7bc232-e647-0667-4402-2f207003854b@intel.com> (raw)
In-Reply-To: <YxNf2/H5Iyz5M8sn@kernel.org>
On 3/09/22 17:08, Arnaldo Carvalho de Melo wrote:
> Em Sat, Sep 03, 2022 at 10:14:25AM +0300, Adrian Hunter escreveu:
>> On 2/09/22 22:17, Arnaldo Carvalho de Melo wrote:
>>> Em Fri, Sep 02, 2022 at 05:50:22PM +0300, Adrian Hunter escreveu:
>>>> On 2/09/22 17:46, Tomáš Trnka wrote:
>>>>> Hello,
>>>>>
>>>>> A bug in perf v5.19 and newer completely breaks monitoring multithreaded
>>>>> processes using "perf top -p". The tool fails to start with "Failed to mmap
>>>>> with 22 (Invalid argument)". It still seems to work fine on single-threaded
>>>>> processes. "perf record" is also unaffected.
>>>>
>>>> It has been reported here:
>>>>
>>>> https://bugzilla.kernel.org/show_bug.cgi?id=216441
>>>
>>> If I do:
>>>
>>> ⬢[acme@toolbox perf-urgent]$ git log -2
>>> commit dfeb0bc60782471c293938e71b1a1117cfac2cb3 (HEAD -> perf/urgent)
>>> Author: Arnaldo Carvalho de Melo <acme@redhat.com>
>>> Date: Fri Sep 2 16:15:39 2022 -0300
>>>
>>> Revert "libperf evlist: Check nr_mmaps is correct"
>>>
>>> This reverts commit 4ce47d842d4c16c07b135b8a7975b8f0672bcc0e.
>>>
>>> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>>>
>>> commit 78cd283f6b8ab701cb35eafd5af8140560a88f16
>>> Author: Arnaldo Carvalho de Melo <acme@redhat.com>
>>> Date: Fri Sep 2 16:13:41 2022 -0300
>>>
>>> Revert "libperf evlist: Allow mixing per-thread and per-cpu mmaps"
>>>
>>> This reverts commit ae4f8ae16a07896403c90305d4b9be27f657c1fc.
>>>
>>> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>>> ⬢[acme@toolbox perf-urgent]$
>>>
>>> It works again, Tomáš can you please try doing this to see if this works
>>> for you?
>>>
>>
>> This is the fix I have so far. I would like to test it some more though.
>
> Ok, so I'll leave it for the next pull req, possibly after Linux
> Plumbers.
>
> What do you think about reverting those two patches for v6.0 and then
> add this for v6.1?
That would break sideband collection with selected CPUs, so I would
prefer to avoid that.
The fix is a effectively a partial revert of "libperf evlist: Allow
mixing per-thread and per-cpu mmaps" anyway. I just need a few days
to do more testing.
next prev parent reply other threads:[~2022-09-03 17:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-02 14:46 perf top -p broken for multithreaded processes since 5.19 Tomáš Trnka
2022-09-02 14:50 ` Adrian Hunter
2022-09-02 19:17 ` Arnaldo Carvalho de Melo
2022-09-03 7:14 ` Adrian Hunter
2022-09-03 14:08 ` Arnaldo Carvalho de Melo
2022-09-03 17:35 ` Adrian Hunter [this message]
[not found] ` <CA+JHD91ReRGYNiBuO=1CGNZy1egcMjDo+VFO=kmCFrqE0mnK7w@mail.gmail.com>
2022-09-05 11:46 ` Adrian Hunter
2022-09-05 10:42 ` Jiri Olsa
2022-09-04 10:15 ` perf top -p broken for multithreaded processes since 5.19 #forregzbot Thorsten Leemhuis
2022-09-19 15:18 ` Thorsten Leemhuis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a7bc232-e647-0667-4402-2f207003854b@intel.com \
--to=adrian.hunter@intel.com \
--cc=acme@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=trnka@scm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).