From: Janosch Frank <frankja@linux.ibm.com>
To: Janis Schoetterl-Glausch <scgl@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Claudio Imbrenda <imbrenda@linux.ibm.com>,
Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>
Cc: David Hildenbrand <david@redhat.com>,
Jonathan Corbet <corbet@lwn.net>,
kvm@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-s390@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>,
Shuah Khan <shuah@kernel.org>,
Sven Schnelle <svens@linux.ibm.com>,
Thomas Huth <thuth@redhat.com>
Subject: Re: [PATCH v6 01/14] KVM: s390: selftest: memop: Pass mop_desc via pointer
Date: Thu, 26 Jan 2023 12:51:47 +0100 [thread overview]
Message-ID: <9a8086e5-7794-5d76-6f96-69b218d1cc25@linux.ibm.com> (raw)
In-Reply-To: <20230125212608.1860251-2-scgl@linux.ibm.com>
On 1/25/23 22:25, Janis Schoetterl-Glausch wrote:
> The struct is quite large, so this seems nicer.
>
> Signed-off-by: Janis Schoetterl-Glausch <scgl@linux.ibm.com>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Janosch Frank <frankja@linux.ibm.com>
> ---
> tools/testing/selftests/kvm/s390x/memop.c | 44 +++++++++++------------
> 1 file changed, 22 insertions(+), 22 deletions(-)
>
> diff --git a/tools/testing/selftests/kvm/s390x/memop.c b/tools/testing/selftests/kvm/s390x/memop.c
> index 3fd81e58f40c..9c05d1205114 100644
> --- a/tools/testing/selftests/kvm/s390x/memop.c
> +++ b/tools/testing/selftests/kvm/s390x/memop.c
> @@ -48,53 +48,53 @@ struct mop_desc {
> uint8_t key;
> };
>
> -static struct kvm_s390_mem_op ksmo_from_desc(struct mop_desc desc)
> +static struct kvm_s390_mem_op ksmo_from_desc(const struct mop_desc *desc)
> {
> struct kvm_s390_mem_op ksmo = {
> - .gaddr = (uintptr_t)desc.gaddr,
> - .size = desc.size,
> - .buf = ((uintptr_t)desc.buf),
> + .gaddr = (uintptr_t)desc->gaddr,
> + .size = desc->size,
> + .buf = ((uintptr_t)desc->buf),
> .reserved = "ignored_ignored_ignored_ignored"
> };
>
> - switch (desc.target) {
> + switch (desc->target) {
> case LOGICAL:
> - if (desc.mode == READ)
> + if (desc->mode == READ)
> ksmo.op = KVM_S390_MEMOP_LOGICAL_READ;
> - if (desc.mode == WRITE)
> + if (desc->mode == WRITE)
> ksmo.op = KVM_S390_MEMOP_LOGICAL_WRITE;
> break;
> case SIDA:
> - if (desc.mode == READ)
> + if (desc->mode == READ)
> ksmo.op = KVM_S390_MEMOP_SIDA_READ;
> - if (desc.mode == WRITE)
> + if (desc->mode == WRITE)
> ksmo.op = KVM_S390_MEMOP_SIDA_WRITE;
> break;
> case ABSOLUTE:
> - if (desc.mode == READ)
> + if (desc->mode == READ)
> ksmo.op = KVM_S390_MEMOP_ABSOLUTE_READ;
> - if (desc.mode == WRITE)
> + if (desc->mode == WRITE)
> ksmo.op = KVM_S390_MEMOP_ABSOLUTE_WRITE;
> break;
> case INVALID:
> ksmo.op = -1;
> }
> - if (desc.f_check)
> + if (desc->f_check)
> ksmo.flags |= KVM_S390_MEMOP_F_CHECK_ONLY;
> - if (desc.f_inject)
> + if (desc->f_inject)
> ksmo.flags |= KVM_S390_MEMOP_F_INJECT_EXCEPTION;
> - if (desc._set_flags)
> - ksmo.flags = desc.set_flags;
> - if (desc.f_key) {
> + if (desc->_set_flags)
> + ksmo.flags = desc->set_flags;
> + if (desc->f_key) {
> ksmo.flags |= KVM_S390_MEMOP_F_SKEY_PROTECTION;
> - ksmo.key = desc.key;
> + ksmo.key = desc->key;
> }
> - if (desc._ar)
> - ksmo.ar = desc.ar;
> + if (desc->_ar)
> + ksmo.ar = desc->ar;
> else
> ksmo.ar = 0;
> - if (desc._sida_offset)
> - ksmo.sida_offset = desc.sida_offset;
> + if (desc->_sida_offset)
> + ksmo.sida_offset = desc->sida_offset;
>
> return ksmo;
> }
> @@ -183,7 +183,7 @@ static int err_memop_ioctl(struct test_info info, struct kvm_s390_mem_op *ksmo)
> else \
> __desc.gaddr = __desc.gaddr_v; \
> } \
> - __ksmo = ksmo_from_desc(__desc); \
> + __ksmo = ksmo_from_desc(&__desc); \
> print_memop(__info.vcpu, &__ksmo); \
> err##memop_ioctl(__info, &__ksmo); \
> })
next prev parent reply other threads:[~2023-01-26 11:52 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-25 21:25 [PATCH v6 00/14] KVM: s390: Extend MEM_OP ioctl by storage key checked cmpxchg Janis Schoetterl-Glausch
2023-01-25 21:25 ` [PATCH v6 01/14] KVM: s390: selftest: memop: Pass mop_desc via pointer Janis Schoetterl-Glausch
2023-01-26 11:51 ` Janosch Frank [this message]
2023-01-25 21:25 ` [PATCH v6 02/14] KVM: s390: selftest: memop: Replace macros by functions Janis Schoetterl-Glausch
2023-01-26 12:00 ` Janosch Frank
2023-01-25 21:25 ` [PATCH v6 03/14] KVM: s390: selftest: memop: Move testlist into main Janis Schoetterl-Glausch
2023-01-26 12:03 ` Janosch Frank
2023-01-25 21:25 ` [PATCH v6 04/14] KVM: s390: selftest: memop: Add bad address test Janis Schoetterl-Glausch
2023-01-26 15:23 ` Janosch Frank
2023-01-25 21:25 ` [PATCH v6 05/14] KVM: s390: selftest: memop: Fix typo Janis Schoetterl-Glausch
2023-01-25 21:26 ` [PATCH v6 06/14] KVM: s390: selftest: memop: Fix wrong address being used in test Janis Schoetterl-Glausch
2023-01-25 21:26 ` [PATCH v6 07/14] KVM: s390: selftest: memop: Fix integer literal Janis Schoetterl-Glausch
2023-01-26 6:38 ` Thomas Huth
2023-01-25 21:26 ` [PATCH v6 08/14] KVM: s390: Move common code of mem_op functions into functions Janis Schoetterl-Glausch
2023-01-26 6:48 ` Thomas Huth
2023-01-26 13:02 ` Janosch Frank
2023-01-26 16:47 ` Janis Schoetterl-Glausch
2023-01-26 17:01 ` Janis Schoetterl-Glausch
2023-01-25 21:26 ` [PATCH v6 09/14] KVM: s390: Dispatch to implementing function at top level of vm mem_op Janis Schoetterl-Glausch
2023-01-26 12:13 ` Thomas Huth
2023-01-25 21:26 ` [PATCH v6 10/14] KVM: s390: Refactor absolute vm mem_op function Janis Schoetterl-Glausch
2023-01-26 12:18 ` Thomas Huth
2023-01-26 13:02 ` Janosch Frank
2023-02-03 14:48 ` Janosch Frank
2023-02-03 15:32 ` Janis Schoetterl-Glausch
2023-01-25 21:26 ` [PATCH v6 11/14] KVM: s390: Refactor absolute vcpu " Janis Schoetterl-Glausch
2023-01-25 21:26 ` [PATCH v6 12/14] KVM: s390: Extend MEM_OP ioctl by storage key checked cmpxchg Janis Schoetterl-Glausch
2023-01-26 8:19 ` Heiko Carstens
2023-01-26 16:10 ` Janosch Frank
2023-01-27 18:15 ` Janis Schoetterl-Glausch
2023-01-28 9:29 ` kernel test robot
2023-01-28 14:38 ` kernel test robot
2023-01-28 14:38 ` kernel test robot
2023-01-25 21:26 ` [PATCH v6 13/14] Documentation: KVM: s390: Describe KVM_S390_MEMOP_F_CMPXCHG Janis Schoetterl-Glausch
2023-01-25 21:26 ` [PATCH v6 14/14] KVM: s390: selftest: memop: Add cmpxchg tests Janis Schoetterl-Glausch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a8086e5-7794-5d76-6f96-69b218d1cc25@linux.ibm.com \
--to=frankja@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=corbet@lwn.net \
--cc=david@redhat.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=scgl@linux.ibm.com \
--cc=shuah@kernel.org \
--cc=svens@linux.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).