From: Kishon Vijay Abraham I <kishon@ti.com>
To: "Fabio Estevam" <festevam@gmail.com>, "Guido Günther" <agx@sigxcpu.org>
Cc: "Rob Herring" <robh+dt@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Shawn Guo" <shawnguo@kernel.org>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"NXP Linux Team" <linux-imx@nxp.com>,
"Thierry Reding" <treding@nvidia.com>,
"Andreas Färber" <afaerber@suse.de>,
"Martin Blumenstingl" <martin.blumenstingl@googlemail.com>,
"Heiko Stuebner" <heiko@sntech.de>,
"Johan Hovold" <johan@kernel.org>,
"Lucas Stach" <l.stach@pengutronix.de>,
"Abel Vesa" <abel.vesa@nxp.com>, "Li Jun" <jun.li@nxp.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
"DRI mailing list" <dri-devel@lists.freedesktop.org>,
"Robert Chiras" <robert.chiras@nxp.com>,
"Sam Ravnborg" <sam@ravnborg.org>,
"Maxime Ripard" <maxime.ripard@bootlin.com>
Subject: Re: [PATCH v11 2/2] phy: Add driver for mixel mipi dphy found on NXP's i.MX8 SoCs
Date: Thu, 20 Jun 2019 14:18:53 +0530 [thread overview]
Message-ID: <9a872f5b-1544-32a0-bd93-1d6333468114@ti.com> (raw)
In-Reply-To: <69fcb327-8b51-df9e-12d9-d75751974bce@ti.com>
Hi,
On 24/05/19 9:31 PM, Kishon Vijay Abraham I wrote:
> Hi,
>
> On 24/05/19 5:53 PM, Fabio Estevam wrote:
>> Hi Kishon,
>>
>> On Sun, May 12, 2019 at 7:49 AM Guido Günther <agx@sigxcpu.org> wrote:
>>>
>>> This adds support for the Mixel DPHY as found on i.MX8 CPUs but since
>>> this is an IP core it will likely be found on others in the future. So
>>> instead of adding this to the nwl host driver make it a generic PHY
>>> driver.
>>>
>>> The driver supports the i.MX8MQ. Support for i.MX8QM and i.MX8QXP can be
>>> added once the necessary system controller bits are in via
>>> mixel_dphy_devdata.
>>>
>>> Signed-off-by: Guido Günther <agx@sigxcpu.org>
>>> Co-developed-by: Robert Chiras <robert.chiras@nxp.com>
>>> Signed-off-by: Robert Chiras <robert.chiras@nxp.com>
>>> Reviewed-by: Fabio Estevam <festevam@gmail.com>
>>> Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
>>
>> Would you have any comments on this series, please?
>
> I don't have any comments. I'll queue this once I start queuing patches for the
> next merge window.
Can you fix the following checkpatch warning and repost?
WARNING: quoted string split across lines
#420: FILE: drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c:280:
+ dev_dbg(&phy->dev, "hs_prepare: %u, clk_prepare: %u, "
+ "hs_zero: %u, clk_zero: %u, "
WARNING: quoted string split across lines
#421: FILE: drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c:281:
+ "hs_zero: %u, clk_zero: %u, "
+ "hs_trail: %u, clk_trail: %u, "
WARNING: quoted string split across lines
#422: FILE: drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c:282:
+ "hs_trail: %u, clk_trail: %u, "
+ "rxhs_settle: %u\n",
Thanks
Kishon
next prev parent reply other threads:[~2019-06-20 8:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-12 10:48 [PATCH v11 0/2] Mixel MIPI DPHY support for NXPs i.MX8 SOCs Guido Günther
2019-05-12 10:48 ` [PATCH v11 1/2] dt-bindings: phy: Add documentation for mixel dphy Guido Günther
2019-05-12 10:48 ` [PATCH v11 2/2] phy: Add driver for mixel mipi dphy found on NXP's i.MX8 SoCs Guido Günther
2019-05-24 12:23 ` Fabio Estevam
2019-05-24 16:01 ` Kishon Vijay Abraham I
2019-06-20 8:48 ` Kishon Vijay Abraham I [this message]
2019-06-20 19:43 ` Guido Günther
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a872f5b-1544-32a0-bd93-1d6333468114@ti.com \
--to=kishon@ti.com \
--cc=abel.vesa@nxp.com \
--cc=afaerber@suse.de \
--cc=agx@sigxcpu.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=festevam@gmail.com \
--cc=heiko@sntech.de \
--cc=johan@kernel.org \
--cc=jun.li@nxp.com \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=maxime.ripard@bootlin.com \
--cc=robert.chiras@nxp.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sam@ravnborg.org \
--cc=shawnguo@kernel.org \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).