From: Jesper Juhl <jesper.juhl@gmail.com>
To: Olaf Hering <olh@suse.de>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] disable per cpu intr in /proc/stat
Date: Sun, 22 Jan 2006 21:38:22 +0100 [thread overview]
Message-ID: <9a8748490601221238t318e483g9b0013f5cb7a85ce@mail.gmail.com> (raw)
In-Reply-To: <20060122202204.GA26295@suse.de>
On 1/22/06, Olaf Hering <olh@suse.de> wrote:
> (No bugzilla or benchmark)
>
> From: schwab@suse.de
> Subject: Reading /proc/stat is slooow
>
> Don't compute and display the per-irq sums on ia64 either, too much
> overhead for mostly useless figures.
>
> --- linux-2.6.14/fs/proc/proc_misc.c.~1~ 2005-12-06 18:12:28.840059961 +0100
> +++ linux-2.6.14/fs/proc/proc_misc.c 2005-12-06 18:13:51.211896515 +0100
> @@ -498,7 +498,7 @@ static int show_stat(struct seq_file *p,
> }
> seq_printf(p, "intr %llu", (unsigned long long)sum);
>
> -#if !defined(CONFIG_PPC64) && !defined(CONFIG_ALPHA)
> +#if !defined(CONFIG_PPC64) && !defined(CONFIG_ALPHA) && !defined(CONFIG_IA64)
> for (i = 0; i < NR_IRQS; i++)
> seq_printf(p, " %u", kstat_irqs(i));
> #endif
Hmm, this changes userspace visible data... should we be doing that?
--
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
next prev parent reply other threads:[~2006-01-22 20:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-22 20:22 [PATCH] disable per cpu intr in /proc/stat Olaf Hering
2006-01-22 20:31 ` Andrew Morton
2006-01-22 20:59 ` Tony Luck
2006-01-22 20:38 ` Jesper Juhl [this message]
2006-01-23 0:02 Albert Cahalan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a8748490601221238t318e483g9b0013f5cb7a85ce@mail.gmail.com \
--to=jesper.juhl@gmail.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olh@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).