From: "Jesper Juhl" <jesper.juhl@gmail.com>
To: "Anton Salikhmetov" <salikhmetov@gmail.com>
Cc: linux-mm@kvack.org, jakob@unthought.net,
linux-kernel@vger.kernel.org, valdis.kletnieks@vt.edu,
riel@redhat.com, ksm@42.dk, staubach@redhat.com,
torvalds@linux-foundation.org, a.p.zijlstra@chello.nl,
akpm@linux-foundation.org, protasnb@gmail.com, miklos@szeredi.hu,
r.e.wolff@bitwizard.nl, hidave.darkstar@gmail.com,
hch@infradead.org
Subject: Re: [PATCH -v7 2/2] Update ctime and mtime for memory-mapped files
Date: Tue, 22 Jan 2008 02:54:26 +0100 [thread overview]
Message-ID: <9a8748490801211754t51cbc65bg20dea2f8cf6d4516@mail.gmail.com> (raw)
In-Reply-To: <4df4ef0c0801211751w39d7b9e5ne2e8b788051d3e3a@mail.gmail.com>
On 22/01/2008, Anton Salikhmetov <salikhmetov@gmail.com> wrote:
> 2008/1/22, Jesper Juhl <jesper.juhl@gmail.com>:
> > Some very pedantic nitpicking below;
> >
> > On 22/01/2008, Anton Salikhmetov <salikhmetov@gmail.com> wrote:
...
> > > + if (file && (vma->vm_flags & VM_SHARED)) {
> > > + if (flags & MS_ASYNC)
> > > + vma_wrprotect(vma);
> > > + if (flags & MS_SYNC) {
> >
> > "else if" ??
>
> The MS_ASYNC and MS_SYNC flags are mutually exclusive, that is why I
> did not use the "else-if" here. Moreover, this function itself checks
> that they never come together.
>
I would say that them being mutually exclusive would be a reason *for*
using "else-if" here.
--
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
next prev parent reply other threads:[~2008-01-22 1:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-22 0:32 [PATCH -v7 0/2] Fixing the issue with memory-mapped file times Anton Salikhmetov
2008-01-22 0:32 ` [PATCH -v7 1/2] Massive code cleanup of sys_msync() Anton Salikhmetov
2008-01-22 0:32 ` [PATCH -v7 2/2] Update ctime and mtime for memory-mapped files Anton Salikhmetov
2008-01-22 1:40 ` Jesper Juhl
2008-01-22 1:51 ` Anton Salikhmetov
2008-01-22 1:54 ` Jesper Juhl [this message]
2008-01-22 1:57 ` Anton Salikhmetov
2008-01-22 2:18 ` Jesper Juhl
2008-01-22 2:07 ` Anton Salikhmetov
2008-01-22 2:16 ` Jesper Juhl
2008-01-22 2:16 ` Linus Torvalds
2008-01-22 2:39 ` Anton Salikhmetov
2008-01-22 8:52 ` Miklos Szeredi
2008-01-22 4:39 ` Andi Kleen
2008-01-22 1:34 ` [PATCH -v7 0/2] Fixing the issue with memory-mapped file times Jesper Juhl
2008-01-22 1:40 ` Anton Salikhmetov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a8748490801211754t51cbc65bg20dea2f8cf6d4516@mail.gmail.com \
--to=jesper.juhl@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=hch@infradead.org \
--cc=hidave.darkstar@gmail.com \
--cc=jakob@unthought.net \
--cc=ksm@42.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=miklos@szeredi.hu \
--cc=protasnb@gmail.com \
--cc=r.e.wolff@bitwizard.nl \
--cc=riel@redhat.com \
--cc=salikhmetov@gmail.com \
--cc=staubach@redhat.com \
--cc=torvalds@linux-foundation.org \
--cc=valdis.kletnieks@vt.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).