From: "Limonciello, Mario" <mario.limonciello@amd.com>
To: Werner Sembach <wse@tuxedocomputers.com>,
Raul E Rangel <rrangel@chromium.org>,
linux-acpi@vger.kernel.org, linux-input@vger.kernel.org
Cc: andriy.shevchenko@linux.intel.com, dmitry.torokhov@gmail.com,
hdegoede@redhat.com, rafael@kernel.org,
mika.westerberg@linux.intel.com, timvp@google.com,
linus.walleij@linaro.org, jingle.wu@emc.com.tw,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Alistair Francis <alistair@alistair23.me>,
Jiri Kosina <jikos@kernel.org>, Rob Herring <robh@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 09/13] HID: i2c-hid: acpi: Stop setting wakeup_capable
Date: Thu, 12 Jan 2023 14:09:54 -0600 [thread overview]
Message-ID: <9a88391c-699f-e366-f88b-70fa481aaf7d@amd.com> (raw)
In-Reply-To: <5824c823-dced-bdff-dbd1-5cec9e89480f@tuxedocomputers.com>
On 1/12/2023 13:57, Werner Sembach wrote:
> Hi,
>
> Am 29.09.22 um 18:19 schrieb Raul E Rangel:
>> This is now handled by the i2c-core drive >
>> Signed-off-by: Raul E Rangel <rrangel@chromium.org>
>> Acked-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
>> ---
>>
>> (no changes since v5)
>>
>> Changes in v5:
>> - Added Acked-by: Benjamin Tissoires
>>
>> drivers/hid/i2c-hid/i2c-hid-acpi.c | 5 -----
>> 1 file changed, 5 deletions(-)
>>
>> diff --git a/drivers/hid/i2c-hid/i2c-hid-acpi.c
>> b/drivers/hid/i2c-hid/i2c-hid-acpi.c
>> index b96ae15e0ad917e..375c77c3db74d92 100644
>> --- a/drivers/hid/i2c-hid/i2c-hid-acpi.c
>> +++ b/drivers/hid/i2c-hid/i2c-hid-acpi.c
>> @@ -105,11 +105,6 @@ static int i2c_hid_acpi_probe(struct i2c_client
>> *client)
>> acpi_device_fix_up_power(adev);
>> - if (acpi_gbl_FADT.flags & ACPI_FADT_LOW_POWER_S0) {
>> - device_set_wakeup_capable(dev, true);
>> - device_set_wakeup_enable(dev, false);
>> - }
>> -
>> return i2c_hid_core_probe(client, &ihid_acpi->ops,
>> hid_descriptor_address, 0);
>> }
>
> this patch is causing a regression on the Clevo NL50RU of which the
> touchpad instantly wakes up the device when going to sleep. That wasn't
> triggered until this patch by the default settings: Setting wake capable
> but not enabling it by default. So unless a user enabled it by hand, the
> device went correctly to sleep.
>
> I'm not deep into this subsystem so I don't know what the best approach
> is to ?work around this firmware bug?/?fix this issue?:
> - Changing the default back again?
> - Adding a quirk list for bad devices?
> - Maybe this isn't a firmware bug, but the touchpad was not meant to
> wakeup the device and we can somehow detect that?
>
"Generally" laptops that support modern standby/s2idle can be woken from
the touchpad.
By chance can you check Windows? Wait a few minutes after you put it to
sleep to ensure it's really gotten down to a hardware sleep state.
> For reference: The debugging issue that lead me here:
> https://gitlab.freedesktop.org/drm/amd/-/issues/1722#note_1719789
TLDR - That bug has multiple conflated issues, and you can ignore 95% of
it. It's just the last few comments we concluded and bisected down this
regression.
next prev parent reply other threads:[~2023-01-12 20:41 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-29 16:19 [PATCH v6 00/13] acpi: i2c: Use SharedAndWake and ExclusiveAndWake to enable wake irq Raul E Rangel
2022-09-29 16:19 ` [PATCH v6 01/13] HID: i2c-hid: Use PM subsystem to manage " Raul E Rangel
2022-09-29 16:19 ` [PATCH v6 02/13] Input: elan_i2c - " Raul E Rangel
2022-09-29 16:19 ` [PATCH v6 03/13] Input: elants_i2c " Raul E Rangel
2022-09-29 16:19 ` [PATCH v6 04/13] Input: raydium_ts_i2c " Raul E Rangel
2022-09-29 16:19 ` [PATCH v6 05/13] gpiolib: acpi: Add wake_capable variants of acpi_dev_gpio_irq_get Raul E Rangel
2022-09-29 16:19 ` [PATCH v6 06/13] ACPI: resources: Add wake_capable parameter to acpi_dev_irq_flags Raul E Rangel
2022-09-29 19:17 ` Rafael J. Wysocki
2022-09-29 19:27 ` Raul Rangel
2022-09-29 19:38 ` Rafael J. Wysocki
2022-09-29 21:20 ` Raul Rangel
2022-09-29 23:22 ` Dmitry Torokhov
2022-09-30 17:13 ` Rafael J. Wysocki
2022-09-30 17:42 ` Andy Shevchenko
2022-09-30 17:54 ` Rafael J. Wysocki
2022-09-30 17:55 ` Dmitry Torokhov
2022-10-15 16:56 ` Rafael J. Wysocki
2022-10-17 14:53 ` Raul Rangel
2022-11-07 18:36 ` Raul Rangel
2022-11-22 22:13 ` Dmitry Torokhov
2022-09-29 16:19 ` [PATCH v6 07/13] i2c: acpi: Use ACPI wake capability bit to set wake_irq Raul E Rangel
2022-10-01 22:51 ` Wolfram Sang
2022-09-29 16:19 ` [PATCH v6 08/13] ACPI: PM: Take wake IRQ into consideration when entering suspend-to-idle Raul E Rangel
2022-09-29 19:06 ` Rafael J. Wysocki
2022-09-29 16:19 ` [PATCH v6 09/13] HID: i2c-hid: acpi: Stop setting wakeup_capable Raul E Rangel
2022-11-21 14:49 ` Andy Shevchenko
2022-11-30 18:06 ` Raul Rangel
2023-01-12 19:57 ` Werner Sembach
2023-01-12 20:09 ` Limonciello, Mario [this message]
2022-09-29 16:19 ` [PATCH v6 10/13] HID: i2c-hid: Don't set wake_capable and wake_irq Raul E Rangel
2022-09-29 16:19 ` [PATCH v6 11/13] Input: elan_i2c - " Raul E Rangel
2022-09-29 16:19 ` [PATCH v6 12/13] Input: elants_i2c " Raul E Rangel
2022-09-29 16:19 ` [PATCH v6 13/13] Input: raydium_ts_i2c " Raul E Rangel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a88391c-699f-e366-f88b-70fa481aaf7d@amd.com \
--to=mario.limonciello@amd.com \
--cc=alistair@alistair23.me \
--cc=andriy.shevchenko@linux.intel.com \
--cc=benjamin.tissoires@redhat.com \
--cc=dmitry.torokhov@gmail.com \
--cc=hdegoede@redhat.com \
--cc=jikos@kernel.org \
--cc=jingle.wu@emc.com.tw \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=rrangel@chromium.org \
--cc=timvp@google.com \
--cc=wse@tuxedocomputers.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).