From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4810C433F5 for ; Sat, 12 Feb 2022 13:13:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235586AbiBLNNt (ORCPT ); Sat, 12 Feb 2022 08:13:49 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:33252 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231276AbiBLNNr (ORCPT ); Sat, 12 Feb 2022 08:13:47 -0500 Received: from smtprelay03.ispgateway.de (smtprelay03.ispgateway.de [80.67.18.15]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 31B6D2656A; Sat, 12 Feb 2022 05:13:38 -0800 (PST) Received: from [92.206.166.137] (helo=note-book.lan) by smtprelay03.ispgateway.de with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nIsDb-0002iA-PA; Sat, 12 Feb 2022 14:13:39 +0100 Message-ID: <9a89a99872ff2fd67f097224584121e50b8a2f07.camel@apitzsch.eu> Subject: Re: [PATCH v2 2/3] dt-bindings: leds: sgm3140: Document ocp8110 compatible From: =?ISO-8859-1?Q?Andr=E9?= Apitzsch To: Rob Herring Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-leds@vger.kernel.org, Pavel Machek , Matthias Brugger , Linus Walleij Date: Sat, 12 Feb 2022 14:13:32 +0100 In-Reply-To: References: <20211117091405.7412-1-git@apitzsch.eu> <20220207230638.56730-1-git@apitzsch.eu> <20220207230638.56730-3-git@apitzsch.eu> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Df-Sender: YW5kcmVAYXBpdHpzY2guZXU= Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Freitag, dem 11.02.2022 um 10:34 -0600 schrieb Rob Herring: > On Tue, Feb 08, 2022 at 12:06:37AM +0100, André Apitzsch wrote: > > Signed-off-by: André Apitzsch > > Commit msg? What's this h/w? > Thanks for the feedback. Would the following message be sufficient? """ dt-bindings: leds: sgm3140: Document ocp8110 compatible Add devicetree binding for Orient Chip OCP8110 charge pump used for camera flash LEDs. """ > > --- > > Documentation/devicetree/bindings/leds/leds-sgm3140.yaml | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml b/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml > > index f68259619488..1c345cf16d08 100644 > > --- a/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml > > +++ b/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml > > @@ -18,7 +18,9 @@ description: | > > > > properties: > > compatible: > > - const: sgmicro,sgm3140 > > + enum: > > + - ocs,ocp8110 > > + - sgmicro,sgm3140 > > > > enable-gpios: > > maxItems: 1 > > -- > > 2.35.1 > > > >