From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8AF7CC433FE for ; Fri, 21 Oct 2022 08:34:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230183AbiJUIel (ORCPT ); Fri, 21 Oct 2022 04:34:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34214 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230152AbiJUIeE (ORCPT ); Fri, 21 Oct 2022 04:34:04 -0400 Received: from domac.alu.hr (domac.alu.hr [IPv6:2001:b68:2:2800::3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F9AB66A4F for ; Fri, 21 Oct 2022 01:33:46 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by domac.alu.hr (Postfix) with ESMTP id 0A975604F6; Fri, 21 Oct 2022 10:33:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=alu.unizg.hr; s=mail; t=1666341224; bh=FYEHqBa2gPIZMrM22Myqr5qLWw42mXxsenCkjl3eufA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=IscHtkLqWGyLvjd5xm3rpVajIjhrb8racOSMCN6n3JgGTCLE7BaW3lxu4kO+1xHkc aHmIFS/n1WHl4zC0HZo1CxRgarMQ1YdT8YDuHlYnsuvoK9ReUdR7RuAFirhVT9x0OD MquiXmtq0cm9JC2kMCz0O/PeDHjUT2G5Qx9eepVyU5y2JSWAQnDaT6wKWwLmcrvYWQ VTf8l+kamYcDmBSH0nPxWJ/Q6SEkVTYtmiiLw0xkdJ3wkncboulmJhSdbaTWRux83V 8YGdHa2jfOFaFTEgPmB8GiaQHhmgQPpi7wdMflNWHnjV6ZXvtoV4b3LH6mWsia+ZH4 3Rr+qnQzngtFQ== X-Virus-Scanned: Debian amavisd-new at domac.alu.hr Received: from domac.alu.hr ([127.0.0.1]) by localhost (domac.alu.hr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0QjIVAizkO5a; Fri, 21 Oct 2022 10:33:41 +0200 (CEST) Received: from [10.0.2.105] (grf-nat.grf.hr [161.53.83.23]) by domac.alu.hr (Postfix) with ESMTPSA id E6B96604F5; Fri, 21 Oct 2022 10:33:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=alu.unizg.hr; s=mail; t=1666341221; bh=FYEHqBa2gPIZMrM22Myqr5qLWw42mXxsenCkjl3eufA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=TgCcHh8EAqtRwyscsRG4X0BdelQusn5UKOaIHcY4Fl2MLxkBfVEM0NX/cShaRH3JB qjF/FpE3VKtQVTvy78AMiiD6AHNt5FyUgr4tF9NgSD6RDwe5VmPMXa2Xn5r/vJqRZy ge/mjtoUIxr/miQ3AeNsgQc3CkjhXLPmsBwuodreoS6Fgdc1bdgVMGd2EKOz66/hoU OLTy15OmRKr9vDR0b5DL7E7I4hmGgBPNyEZ/7x8ejGqExvWYq9lcoQz3cg1DupC4jJ P+FneH59VpQ9Y1hSx9Sd/RR9NAZ+aSYvGa4Ndh+Yetr9QU+sgdyX0bx/YmDDClRNCs 1zKFDwP2Eobzw== Message-ID: <9a91e006-8a13-ec76-eea9-d15f02cb512a@alu.unizg.hr> Date: Fri, 21 Oct 2022 10:33:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 Subject: Re: BISECT result: 6.0.0-RC kernels trigger Firefox snap bug with 6.0.0-rc3 through 6.0.0-rc7 Content-Language: en-US To: Phillip Lougher , Slade Watkins , Bagas Sanjaya Cc: Jintao Yin , hsinyi@chromium.org, linux-kernel@vger.kernel.org, marcmiltenberger@gmail.com, regressions@leemhuis.info, regressions@lists.linux.dev References: <20221018174157.1897-1-phillip@squashfs.org.uk> <20221020135545.586-1-nicememory@gmail.com> <41ef4b22-eea8-2d67-99d8-6aaae7d25ac1@squashfs.org.uk> <02b72b86-7240-5530-477a-c8bdcfd35ef5@gmail.com> <3a6c0d0c-68ad-ffbb-0e56-c0282ac84149@squashfs.org.uk> From: Mirsad Goran Todorovac In-Reply-To: <3a6c0d0c-68ad-ffbb-0e56-c0282ac84149@squashfs.org.uk> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21.10.2022. 3:48, Phillip Lougher wrote: > On 21/10/2022 00:44, Slade Watkins wrote: >> [Resend due to formatting issue, thanks gmail.] >> >> On Thu, Oct 20, 2022 at 7:23 PM Bagas Sanjaya >> wrote: >>> >>> Ah! I was about to test his third fixup patch. I prefer to go >>> with your fix instead (as the formal patch). >> >> +1, agreed. >> >> -srw > > His patch is wrong, plus he's broken a number of rules of conduct, two > serious.  But, I will not reprimand him as kernel maintainer for what is > probably extreme naivety, unless I have to. > > The link to the full set of patches is here > > https://lore.kernel.org/lkml/20221020223616.7571-1-phillip@squashfs.org.uk/ > > > The first patch fixes the regression reported here in the correct way. > > The second patch fixes another regression (which is separate to the > regression causing the issue here).  This is where the code incorrectly > extends readahead beyond the end of the file.  This is the reason for > the unused trailing pages that Jintao Yin noticed.  But, this patch > fixes the cause, rather than fixing the symptom. > > The third patch fixes the buffer release race condition that I > posted a fix for earlier. > > Spitting this into three patches is one of the rules.  Each patch should > do one thing, and one thing only.  Three separate regressions means > three separate patches.  This is a requirement for "git bisect" to work > effectively. Confirming successful build mainline vanilla 6.0.2 with patches [012/3]. And the combination of Firefox snap windows and tabs that reproduced the regression appears to work. Best regards, Mirsad -- Mirsad Todorovac System engineer Faculty of Graphic Arts | Academy of Fine Arts University of Zagreb Republic of Croatia, the European Union -- Sistem inženjer Grafički fakultet | Akademija likovnih umjetnosti Sveučilište u Zagrebu