linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lukasz Luba <lukasz.luba@arm.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: cwchoi00@gmail.com, myungjoo.ham@samsung.com,
	kyungmin.park@samsung.com, linux-pm@vger.kernel.org,
	linux-kernel@vger.kernel.org, rafael@kernel.org
Subject: Re: [PATCH] powercap/drivers/dtpm: Add dtpm devfreq with energy model support
Date: Tue, 23 Mar 2021 15:56:17 +0000	[thread overview]
Message-ID: <9a9931f4-ece5-4fe9-5f88-871a2e759200@arm.com> (raw)
In-Reply-To: <20210319162836.9364-1-daniel.lezcano@linaro.org>

Hi Daniel,

On 3/19/21 4:28 PM, Daniel Lezcano wrote:
> Currently the dtpm supports the CPUs via cpufreq and the energy
> model. This change provides the same for the device which supports
> devfreq.
> 
> Each device supporting devfreq and having an energy model can register
> themselves in the list of supported devices.
> 
> The concept is the same as the cpufreq dtpm support: the QoS is used
> to aggregate the requests and the energy model gives the value of the
> instantaneous power consumption ponderated by the load of the device.
> 


I've just started the review, but I have a blocking question:

Why there is no unregister function (like 'dtmp_unregister_devfreq')?
Do you consider any devfreq drivers to be modules?

The code looks like an API that it's going to be called directly in
e.g. GPU driver in it's probe function. In that case probably the
module unloading should call dtmp unregister.

Could you explain this to me please? So I can continue the review.

Regards,
Lukasz

  reply	other threads:[~2021-03-23 15:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-19 16:28 [PATCH] powercap/drivers/dtpm: Add dtpm devfreq with energy model support Daniel Lezcano
2021-03-23 15:56 ` Lukasz Luba [this message]
2021-03-23 15:59   ` Daniel Lezcano
2021-03-23 16:00   ` Daniel Lezcano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9a9931f4-ece5-4fe9-5f88-871a2e759200@arm.com \
    --to=lukasz.luba@arm.com \
    --cc=cwchoi00@gmail.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=myungjoo.ham@samsung.com \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).