linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Jianjun Wang (王建军)" <Jianjun.Wang@mediatek.com>
To: "robh@kernel.org" <robh@kernel.org>
Cc: "linux-mediatek@lists.infradead.org"
	<linux-mediatek@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	"bhelgaas@google.com" <bhelgaas@google.com>,
	"Ryder Lee (李庚諺)" <Ryder.Lee@mediatek.com>,
	"TingHan Shen (沈廷翰)" <TingHan.Shen@mediatek.com>,
	"Rex-BC Chen (陳柏辰)" <Rex-BC.Chen@mediatek.com>
Subject: Re: [PATCH] dt-bindings: PCI: mediatek-gen3: Add support for MT8195
Date: Wed, 25 Aug 2021 05:23:48 +0000	[thread overview]
Message-ID: <9aa2ff56984f2d80152e4800a71cb7f71d0e1203.camel@mediatek.com> (raw)
In-Reply-To: <YSUE08dgiGhFsjwH@robh.at.kernel.org>

On Tue, 2021-08-24 at 09:40 -0500, Rob Herring wrote:
> On Fri, Aug 20, 2021 at 10:35:21AM +0800, Jianjun Wang wrote:
> > MT8195 is an ARM platform SoC which has the same PCIe IP with
> > MT8192.
> 
> If it is the same, then 8192 should be a fallback compatible. 'The
> same' 
> means the current driver for 8192 will work unchanged.

Hi Rob,

Thanks for your review.

Yes, the controller driver works fine in the MT8195 platform without
any change, and we would like to use the compatible string in device
tree as follows:

"mediatek,mt8195-pcie", "mediatek,mt8192-pcie"

Thanks.
> 
> > 
> > Signed-off-by: Jianjun Wang <jianjun.wang@mediatek.com>
> > ---
> >  Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml | 4
> > +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/pci/mediatek-pcie-
> > gen3.yaml b/Documentation/devicetree/bindings/pci/mediatek-pcie-
> > gen3.yaml
> > index 742206dbd965..dcebb1036207 100644
> > --- a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
> > +++ b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
> > @@ -48,7 +48,9 @@ allOf:
> >  
> >  properties:
> >    compatible:
> > -    const: mediatek,mt8192-pcie
> > +    oneOf:
> > +      - const: mediatek,mt8192-pcie
> > +      - const: mediatek,mt8195-pcie
> >  
> >    reg:
> >      maxItems: 1
> > -- 
> > 2.18.0
> > 
> > 
> 
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek

      reply	other threads:[~2021-08-25  5:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-20  2:35 [PATCH] dt-bindings: PCI: mediatek-gen3: Add support for MT8195 Jianjun Wang
2021-08-24 14:39 ` Rob Herring
2021-08-24 14:40 ` Rob Herring
2021-08-25  5:23   ` Jianjun Wang (王建军) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9aa2ff56984f2d80152e4800a71cb7f71d0e1203.camel@mediatek.com \
    --to=jianjun.wang@mediatek.com \
    --cc=Rex-BC.Chen@mediatek.com \
    --cc=Ryder.Lee@mediatek.com \
    --cc=TingHan.Shen@mediatek.com \
    --cc=bhelgaas@google.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=matthias.bgg@gmail.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).