From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753611AbdLIAB7 (ORCPT ); Fri, 8 Dec 2017 19:01:59 -0500 Received: from ale.deltatee.com ([207.54.116.67]:47382 "EHLO ale.deltatee.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752902AbdLIAB6 (ORCPT ); Fri, 8 Dec 2017 19:01:58 -0500 To: linux-ntb@googlegroups.com, linux-kernel@vger.kernel.org Cc: Jon Mason , Dave Jiang , Allen Hubbe References: <20171209000106.18259-1-logang@deltatee.com> From: Logan Gunthorpe Message-ID: <9abd06be-fb6e-8acd-a954-db3ddd019ed9@deltatee.com> Date: Fri, 8 Dec 2017 17:01:52 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171209000106.18259-1-logang@deltatee.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 172.16.1.162 X-SA-Exim-Rcpt-To: Allen.Hubbe@emc.com, dave.jiang@intel.com, jdmason@kudzu.us, linux-kernel@vger.kernel.org, linux-ntb@googlegroups.com X-SA-Exim-Mail-From: logang@deltatee.com Subject: Re: [PATCH] ntb_netdev: set the net_device's parent X-SA-Exim-Version: 4.2.1 (built Tue, 02 Aug 2016 21:08:31 +0000) X-SA-Exim-Scanned: Yes (on ale.deltatee.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sorry ignore this. I sent an old patch :( Logan On 08/12/17 05:01 PM, Logan Gunthorpe wrote: > At present, ntb_netdev devices end up under /sys/devices/virtual/net > completely unconnected to the ntb trees below them. This patch sets the > parent of the net_device (using SET_NETDEV_DEV) to the client_dev > device. This results in a better connected sysfs path for the network > device: > > /sys/devices/pci0000:00/0000:00:03.0/0000:03:00.1/0000:03:00.1/ntb_netdev0/net/eth2 > > Signed-off-by: Logan Gunthorpe > Cc: Jon Mason > Cc: Dave Jiang > Cc: Allen Hubbe > --- > drivers/net/ntb_netdev.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/ntb_netdev.c b/drivers/net/ntb_netdev.c > index 4daf3d0926a8..0250aa9ae2cb 100644 > --- a/drivers/net/ntb_netdev.c > +++ b/drivers/net/ntb_netdev.c > @@ -418,6 +418,8 @@ static int ntb_netdev_probe(struct device *client_dev) > if (!ndev) > return -ENOMEM; > > + SET_NETDEV_DEV(ndev, client_dev); > + > dev = netdev_priv(ndev); > dev->ndev = ndev; > dev->pdev = pdev; >