linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] irqchip/tango: Set irq handler and data in one go
@ 2018-07-22 18:02 Martin Kaiser
  2018-08-17 12:10 ` [PATCH resend] " Martin Kaiser
  0 siblings, 1 reply; 3+ messages in thread
From: Martin Kaiser @ 2018-07-22 18:02 UTC (permalink / raw)
  To: Marc Zyngier, Jason Cooper, Thomas Gleixner
  Cc: linux-kernel, linux-arm-kernel, Martin Kaiser

Replace the two separate calls for setting the irq handler and data with
a single irq_set_chained_handler_and_data() call.

Signed-off-by: Martin Kaiser <martin@kaiser.cx>
---
 drivers/irqchip/irq-tango.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/irqchip/irq-tango.c b/drivers/irqchip/irq-tango.c
index 0c085303a583..580e2d72b9ba 100644
--- a/drivers/irqchip/irq-tango.c
+++ b/drivers/irqchip/irq-tango.c
@@ -205,8 +205,7 @@ static int __init tangox_irq_init(void __iomem *base, struct resource *baseres,
 
 	tangox_irq_domain_init(dom);
 
-	irq_set_chained_handler(irq, tangox_irq_handler);
-	irq_set_handler_data(irq, dom);
+	irq_set_chained_handler_and_data(irq, tangox_irq_handler, dom);
 
 	return 0;
 }
-- 
2.1.4


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH resend] irqchip/tango: Set irq handler and data in one go
  2018-07-22 18:02 [PATCH] irqchip/tango: Set irq handler and data in one go Martin Kaiser
@ 2018-08-17 12:10 ` Martin Kaiser
  2018-08-17 13:45   ` Marc Zyngier
  0 siblings, 1 reply; 3+ messages in thread
From: Martin Kaiser @ 2018-08-17 12:10 UTC (permalink / raw)
  To: Marc Zyngier
  Cc: Florian Fainelli, Jason Cooper, Thomas Gleixner,
	linux-arm-kernel, linux-kernel, Martin Kaiser

Replace the two separate calls for setting the irq handler and data with
a single irq_set_chained_handler_and_data() call.

Signed-off-by: Martin Kaiser <martin@kaiser.cx>
---
Resending this, it seems this got lost along the way. Not a major change,
of course. But should also be simple to review.

Thanks & Best regards,
Martin

 drivers/irqchip/irq-tango.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/irqchip/irq-tango.c b/drivers/irqchip/irq-tango.c
index 0c085303a583..580e2d72b9ba 100644
--- a/drivers/irqchip/irq-tango.c
+++ b/drivers/irqchip/irq-tango.c
@@ -205,8 +205,7 @@ static int __init tangox_irq_init(void __iomem *base, struct resource *baseres,
 
 	tangox_irq_domain_init(dom);
 
-	irq_set_chained_handler(irq, tangox_irq_handler);
-	irq_set_handler_data(irq, dom);
+	irq_set_chained_handler_and_data(irq, tangox_irq_handler, dom);
 
 	return 0;
 }
-- 
2.1.4


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH resend] irqchip/tango: Set irq handler and data in one go
  2018-08-17 12:10 ` [PATCH resend] " Martin Kaiser
@ 2018-08-17 13:45   ` Marc Zyngier
  0 siblings, 0 replies; 3+ messages in thread
From: Marc Zyngier @ 2018-08-17 13:45 UTC (permalink / raw)
  To: Martin Kaiser
  Cc: Florian Fainelli, Jason Cooper, Thomas Gleixner,
	linux-arm-kernel, linux-kernel

On 17/08/18 13:10, Martin Kaiser wrote:
> Replace the two separate calls for setting the irq handler and data with
> a single irq_set_chained_handler_and_data() call.
> 
> Signed-off-by: Martin Kaiser <martin@kaiser.cx>
> ---
> Resending this, it seems this got lost along the way. Not a major change,
> of course. But should also be simple to review.
> 
> Thanks & Best regards,
> Martin
> 
>  drivers/irqchip/irq-tango.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/irqchip/irq-tango.c b/drivers/irqchip/irq-tango.c
> index 0c085303a583..580e2d72b9ba 100644
> --- a/drivers/irqchip/irq-tango.c
> +++ b/drivers/irqchip/irq-tango.c
> @@ -205,8 +205,7 @@ static int __init tangox_irq_init(void __iomem *base, struct resource *baseres,
>  
>  	tangox_irq_domain_init(dom);
>  
> -	irq_set_chained_handler(irq, tangox_irq_handler);
> -	irq_set_handler_data(irq, dom);
> +	irq_set_chained_handler_and_data(irq, tangox_irq_handler, dom);
>  
>  	return 0;
>  }
> 

Queued, thanks.

	M.
-- 
Jazz is not dead. It just smells funny...

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-08-17 13:45 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-22 18:02 [PATCH] irqchip/tango: Set irq handler and data in one go Martin Kaiser
2018-08-17 12:10 ` [PATCH resend] " Martin Kaiser
2018-08-17 13:45   ` Marc Zyngier

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).