From: David Hildenbrand <david@redhat.com>
To: Jann Horn <jannh@google.com>
Cc: security@kernel.org, Andrew Morton <akpm@linux-foundation.org>,
Yang Shi <shy828301@gmail.com>, Peter Xu <peterx@redhat.com>,
John Hubbard <jhubbard@nvidia.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH v3 2/3] mm/khugepaged: Fix GUP-fast interaction by sending IPI
Date: Mon, 28 Nov 2022 18:00:49 +0100 [thread overview]
Message-ID: <9ae67ddb-d2b0-57bb-a181-d35a7af51c67@redhat.com> (raw)
In-Reply-To: <CAG48ez02g3ind9p9op-t_k3eruANE4idhjT044rK5+qK8_-EFA@mail.gmail.com>
On 28.11.22 17:58, Jann Horn wrote:
> On Mon, Nov 28, 2022 at 2:46 PM David Hildenbrand <david@redhat.com> wrote:
>> On 25.11.22 22:37, Jann Horn wrote:
>>> Since commit 70cbc3cc78a99 ("mm: gup: fix the fast GUP race against THP
>>> collapse"), the lockless_pages_from_mm() fastpath rechecks the pmd_t to
>>> ensure that the page table was not removed by khugepaged in between.
>>>
>>> However, lockless_pages_from_mm() still requires that the page table is not
>>> concurrently freed.
>>
>> That's an interesting point. For anon THPs, the page table won't get
>> immediately freed, but instead will be deposited in the "pgtable list"
>> stored alongside the THP.
>>
>> From there, it might get withdrawn (pgtable_trans_huge_withdraw()) and
>>
>> a) Reused as a page table when splitting the THP. That should be fine,
>> no garbage in it, simply a page table again.
>
> Depends on the definition of "fine" - it will be a page table again,
> but deposited page tables are not associated with a specific address,
> so it might be reused at a different address. If GUP-fast on address A
> races with a page table from address A being deposited and reused at
> address B, and then GUP-fast returns something from address B, that's
> not exactly great either.
The "PMD changed" check should catch that. We only care about not
dereferencing something that's garbage and not a page/folio if I
remember the previous discussions on that correctly.
Anyhow, feel free to add my
Acked-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2022-11-28 17:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-25 21:37 [PATCH v3 1/3] mm/khugepaged: Take the right locks for page table retraction Jann Horn
2022-11-25 21:37 ` [PATCH v3 2/3] mm/khugepaged: Fix GUP-fast interaction by sending IPI Jann Horn
2022-11-28 13:46 ` David Hildenbrand
2022-11-28 16:58 ` Jann Horn
2022-11-28 17:00 ` David Hildenbrand [this message]
2022-11-25 21:37 ` [PATCH v3 3/3] mm/khugepaged: Invoke MMU notifiers in shmem/file collapse paths Jann Horn
2022-11-28 17:37 ` David Hildenbrand
2022-11-28 17:57 ` Jann Horn
2022-11-28 18:06 ` David Hildenbrand
2022-11-28 13:52 ` [PATCH v3 1/3] mm/khugepaged: Take the right locks for page table retraction David Hildenbrand
2022-11-28 17:28 ` Jann Horn
2022-11-28 17:34 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ae67ddb-d2b0-57bb-a181-d35a7af51c67@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=jannh@google.com \
--cc=jhubbard@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=peterx@redhat.com \
--cc=security@kernel.org \
--cc=shy828301@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).