From: Bart Van Assche <bvanassche@acm.org>
To: Akinobu Mita <akinobu.mita@gmail.com>
Cc: linux-kernel@vger.kernel.org, Jaegeuk Kim <jaegeuk@kernel.org>
Subject: Re: [PATCH] fault-inject: Declare the second argument of setup_fault_attr() const
Date: Wed, 28 Jul 2021 16:05:30 -0700 [thread overview]
Message-ID: <9afbc59c-f745-03c1-c74d-264a7180ec87@acm.org> (raw)
In-Reply-To: <20210708183427.22842-1-bvanassche@acm.org>
On 7/8/21 11:34 AM, Bart Van Assche wrote:
> This patch makes it possible to pass a const char * argument to
> setup_fault_attr() without having to cast away constness.
>
> Cc: Akinobu Mita <akinobu.mita@gmail.com>
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
> ---
> include/linux/fault-inject.h | 2 +-
> lib/fault-inject.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/fault-inject.h b/include/linux/fault-inject.h
> index e525f6957c49..afc649f0102b 100644
> --- a/include/linux/fault-inject.h
> +++ b/include/linux/fault-inject.h
> @@ -42,7 +42,7 @@ struct fault_attr {
> }
>
> #define DECLARE_FAULT_ATTR(name) struct fault_attr name = FAULT_ATTR_INITIALIZER
> -int setup_fault_attr(struct fault_attr *attr, char *str);
> +int setup_fault_attr(struct fault_attr *attr, const char *str);
> bool should_fail(struct fault_attr *attr, ssize_t size);
>
> #ifdef CONFIG_FAULT_INJECTION_DEBUG_FS
> diff --git a/lib/fault-inject.c b/lib/fault-inject.c
> index ce12621b4275..45520151b32d 100644
> --- a/lib/fault-inject.c
> +++ b/lib/fault-inject.c
> @@ -15,7 +15,7 @@
> * setup_fault_attr() is a helper function for various __setup handlers, so it
> * returns 0 on error, because that is what __setup handlers do.
> */
> -int setup_fault_attr(struct fault_attr *attr, char *str)
> +int setup_fault_attr(struct fault_attr *attr, const char *str)
> {
> unsigned long probability;
> unsigned long interval;
Hi Akinobu,
Did I send this patch to the right person?
Thanks,
Bart.
next prev parent reply other threads:[~2021-07-28 23:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-08 18:34 [PATCH] fault-inject: Declare the second argument of setup_fault_attr() const Bart Van Assche
2021-07-28 23:05 ` Bart Van Assche [this message]
2021-07-29 0:35 ` Akinobu Mita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9afbc59c-f745-03c1-c74d-264a7180ec87@acm.org \
--to=bvanassche@acm.org \
--cc=akinobu.mita@gmail.com \
--cc=jaegeuk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).