From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BBECC43381 for ; Wed, 10 Mar 2021 16:42:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5FD1564FC1 for ; Wed, 10 Mar 2021 16:42:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232095AbhCJQlc (ORCPT ); Wed, 10 Mar 2021 11:41:32 -0500 Received: from mga02.intel.com ([134.134.136.20]:46597 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231790AbhCJQl0 (ORCPT ); Wed, 10 Mar 2021 11:41:26 -0500 IronPort-SDR: VThSInN9ZKeyZjjzpHUgKsQlo4QDu9NRljxJTdE9Af67rR9dW1LZRof+7DeN9vmDx3IBwkBjdP 44NBn4gJ8NQw== X-IronPort-AV: E=McAfee;i="6000,8403,9919"; a="175612703" X-IronPort-AV: E=Sophos;i="5.81,237,1610438400"; d="scan'208";a="175612703" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Mar 2021 08:41:23 -0800 IronPort-SDR: YYDjhh1OA5FA/uN50/iTRjQ0hrwf4lSd5EzYDJrUKp2IotZ73mJSacsS+5eHu3txj+eR013M9t BFj6NdzrLPcg== X-IronPort-AV: E=Sophos;i="5.81,237,1610438400"; d="scan'208";a="403742860" Received: from huiyingw-mobl.amr.corp.intel.com (HELO [10.212.214.84]) ([10.212.214.84]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Mar 2021 08:41:21 -0800 Subject: Re: [PATCH V2] ASoC: soc-core: Prevent warning if no DMI table is present To: Takashi Iwai , Mark Brown Cc: alsa-devel@alsa-project.org, Kai Vehmanen , Liam Girdwood , linux-kernel@vger.kernel.org, Takashi Iwai , Ranjani Sridharan , linux-tegra@vger.kernel.org, Jon Hunter , Bard liao References: <20210303115526.419458-1-jonathanh@nvidia.com> <91480f92-a3f5-e71f-acdc-ea74488ab0a1@linux.intel.com> <20210310133534.GD4746@sirena.org.uk> <6a2352e6-f2b7-def1-de58-52fbeb7846e5@linux.intel.com> <20210310161814.GA28564@sirena.org.uk> From: Pierre-Louis Bossart Message-ID: <9b073d01-f2fe-a99b-e53c-4a0b3f95ca05@linux.intel.com> Date: Wed, 10 Mar 2021 10:41:18 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/10/21 10:37 AM, Takashi Iwai wrote: > On Wed, 10 Mar 2021 17:18:14 +0100, > Mark Brown wrote: >> >> On Wed, Mar 10, 2021 at 09:44:07AM -0600, Pierre-Louis Bossart wrote: >>> On 3/10/21 7:35 AM, Mark Brown wrote: >> >>>> Just change it to a system level check for ACPI, checking for OF would >>>> leave problems for board files or any other alternative firmware >>>> interfaces. >> >>> did you mean if (!IS_ENABLED(CONFIG_ACPI)) ? >> >> Is there a runtime check? > > Well, basically both DMI and ACPI are completely different things, so > I don't think it's right to check the availability of ACPI as a signal > of the availability of DMI. would this work? if (!IS_ENABLED(CONFIG_DMI)) return 0;