From: Mario Limonciello <mario.limonciello@dell.com>
To: dvhart@infradead.org, Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
platform-driver-x86@vger.kernel.org,
Andy Lutomirski <luto@kernel.org>,
quasisec@google.com, pali.rohar@gmail.com, rjw@rjwysocki.net,
mjg59@google.com, hch@lst.de, Greg KH <greg@kroah.com>,
Alan Cox <gnomes@lxorguk.ukuu.org.uk>,
Mario Limonciello <mario.limonciello@dell.com>
Subject: [PATCH v12 01/16] platform/x86: dell-smbios: Prefix class/select with cmd_
Date: Wed, 1 Nov 2017 14:25:22 -0500 [thread overview]
Message-ID: <9b1448731683c407ae1a05c5dcfb9aec1102724a.1509561822.git.mario.limonciello@dell.com> (raw)
In-Reply-To: <cover.1509561822.git.mario.limonciello@dell.com>
In-Reply-To: <cover.1509561822.git.mario.limonciello@dell.com>
Later on these structures will be brought up to userspace.
the word "class" is a reserved word in c++ and this will prevent
uapi headers from being included directly in c++ programs.
To make life easier on these applications, prepare the change now.
Signed-off-by: Mario Limonciello <mario.limonciello@dell.com>
---
drivers/platform/x86/dell-smbios.c | 4 ++--
drivers/platform/x86/dell-smbios.h | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/platform/x86/dell-smbios.c b/drivers/platform/x86/dell-smbios.c
index e9b1ca07c872..ffc174638aa4 100644
--- a/drivers/platform/x86/dell-smbios.c
+++ b/drivers/platform/x86/dell-smbios.c
@@ -86,8 +86,8 @@ void dell_smbios_send_request(int class, int select)
command.ebx = virt_to_phys(buffer);
command.ecx = 0x42534931;
- buffer->class = class;
- buffer->select = select;
+ buffer->cmd_class = class;
+ buffer->cmd_select = select;
dcdbas_smi_request(&command);
}
diff --git a/drivers/platform/x86/dell-smbios.h b/drivers/platform/x86/dell-smbios.h
index 45cbc2292cd3..742dd8bd66b9 100644
--- a/drivers/platform/x86/dell-smbios.h
+++ b/drivers/platform/x86/dell-smbios.h
@@ -22,8 +22,8 @@ struct notifier_block;
* system management mode, hence the volatiles */
struct calling_interface_buffer {
- u16 class;
- u16 select;
+ u16 cmd_class;
+ u16 cmd_select;
volatile u32 input[4];
volatile u32 output[4];
} __packed;
--
2.14.1
next prev parent reply other threads:[~2017-11-01 19:29 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-01 19:25 [PATCH v12 00/16] Introduce support for Dell SMBIOS over WMI Mario Limonciello
2017-11-01 19:25 ` Mario Limonciello [this message]
2017-11-02 0:30 ` [PATCH v12 01/16] platform/x86: dell-smbios: Prefix class/select with cmd_ Edward O'Callaghan
2017-11-01 19:25 ` [PATCH v12 02/16] platform/x86: wmi: Add new method wmidev_evaluate_method Mario Limonciello
2017-11-01 19:25 ` [PATCH v12 03/16] platform/x86: dell-wmi: increase severity of some failures Mario Limonciello
2017-11-01 19:25 ` [PATCH v12 04/16] platform/x86: dell-wmi: clean up wmi descriptor check Mario Limonciello
2017-11-01 19:25 ` [PATCH v12 05/16] platform/x86: dell-wmi: don't check length returned Mario Limonciello
2017-11-01 19:25 ` [PATCH v12 06/16] platform/x86: dell-wmi-descriptor: split WMI descriptor into it's own driver Mario Limonciello
2017-11-01 19:25 ` [PATCH v12 07/16] platform/x86: wmi: Don't allow drivers to get each other's GUIDs Mario Limonciello
2017-11-01 19:25 ` [PATCH v12 08/16] platform/x86: dell-smbios: only run if proper oem string is detected Mario Limonciello
2017-11-01 19:25 ` [PATCH v12 09/16] platform/x86: dell-smbios: Add a sysfs interface for SMBIOS tokens Mario Limonciello
2017-11-01 19:25 ` [PATCH v12 10/16] platform/x86: dell-smbios: Introduce dispatcher for SMM calls Mario Limonciello
2018-01-27 14:48 ` Pali Rohár
2017-11-01 19:25 ` [PATCH v12 11/16] platform/x86: dell-smbios-wmi: Add new WMI dispatcher driver Mario Limonciello
2017-11-01 19:25 ` [PATCH v12 12/16] platform/x86: dell-smbios-smm: test for WSMT Mario Limonciello
2017-11-01 19:25 ` [PATCH v12 13/16] platform/x86: dell-smbios: Add filtering support Mario Limonciello
2017-11-01 19:25 ` [PATCH v12 14/16] platform/x86: wmi: create userspace interface for drivers Mario Limonciello
2017-11-02 0:31 ` Edward O'Callaghan
2017-11-01 19:25 ` [PATCH v12 15/16] platform/x86: dell-smbios-wmi: introduce userspace interface Mario Limonciello
2017-11-01 19:25 ` [PATCH v12 16/16] tools/wmi: add a sample for dell smbios communication over WMI Mario Limonciello
2017-11-03 0:50 ` [PATCH v12 00/16] Introduce support for Dell SMBIOS " Darren Hart
2017-11-03 16:30 ` Mario.Limonciello
2017-11-03 21:00 ` Darren Hart
2017-11-03 21:02 ` Mario.Limonciello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b1448731683c407ae1a05c5dcfb9aec1102724a.1509561822.git.mario.limonciello@dell.com \
--to=mario.limonciello@dell.com \
--cc=andy.shevchenko@gmail.com \
--cc=dvhart@infradead.org \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=greg@kroah.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mjg59@google.com \
--cc=pali.rohar@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=quasisec@google.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).