From: Alexey Kardashevskiy <aik@ozlabs.ru>
To: Steven Rostedt <rostedt@goodmis.org>,
Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Alex Williamson <alex.williamson@redhat.com>,
kvm@vger.kernel.org, Laura Abbott <labbott@redhat.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Cornelia Huck <cohuck@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vfio_pci: set TRACE_INCLUDE_PATH to fix the build error
Date: Fri, 11 Jan 2019 12:13:35 +1100 [thread overview]
Message-ID: <9b1c9668-98cb-2a30-2fb0-b797b47aa9b6@ozlabs.ru> (raw)
In-Reply-To: <20190110144701.ah3hmedqmyqf5uzt@home.goodmis.org>
On 11/01/2019 01:47, Steven Rostedt wrote:
> On Tue, Jan 08, 2019 at 12:08:03PM +0900, Masahiro Yamada wrote:
>> ---
>>
>> drivers/vfio/pci/trace.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/vfio/pci/trace.h b/drivers/vfio/pci/trace.h
>> index 228ccdb..4d13e51 100644
>> --- a/drivers/vfio/pci/trace.h
>> +++ b/drivers/vfio/pci/trace.h
>> @@ -94,7 +94,7 @@ TRACE_EVENT(vfio_pci_npu2_mmap,
>> #endif /* _TRACE_VFIO_PCI_H */
>>
>> #undef TRACE_INCLUDE_PATH
>> -#define TRACE_INCLUDE_PATH .
>> +#define TRACE_INCLUDE_PATH ../../drivers/vfio/pci
>
> Note, the reason why I did not show this method in the samples/trace_events/
> is that there's one "gotcha" that you need to be careful about. It may not be
> an issue here, but please be aware of it.
>
> The words in TRACE_INCLUDE_PATH can be updated by C preprocessor defines. For
> example, if for some reason you had:
>
> #define pci special_pci
>
> The above would turn into:
>
> ../../drivers/vfio/special_pci
>
> and it wont build, and you will be left scratching your head wondering why.
Lovely :) imho it is +1 for
CFLAGS_vfio_pci_nvlink2.o += -I$(src)
and a comment.
--
Alexey
next prev parent reply other threads:[~2019-01-11 1:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-08 3:08 [PATCH] vfio_pci: set TRACE_INCLUDE_PATH to fix the build error Masahiro Yamada
2019-01-08 9:47 ` Cornelia Huck
2019-01-08 19:28 ` Alex Williamson
2019-01-10 14:47 ` Steven Rostedt
2019-01-11 1:13 ` Alexey Kardashevskiy [this message]
2019-01-11 1:41 ` Alex Williamson
2019-01-11 1:49 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b1c9668-98cb-2a30-2fb0-b797b47aa9b6@ozlabs.ru \
--to=aik@ozlabs.ru \
--cc=alex.williamson@redhat.com \
--cc=cohuck@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=labbott@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mpe@ellerman.id.au \
--cc=rostedt@goodmis.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).