From: Daniel Borkmann <daniel@iogearbox.net>
To: Josef Bacik <josef@toxicpanda.com>,
rostedt@goodmis.org, mingo@redhat.com, davem@davemloft.net,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
ast@kernel.org, kernel-team@fb.com, linux-btrfs@vger.kernel.org
Cc: Josef Bacik <jbacik@fb.com>
Subject: Re: [PATCH v7 3/5] bpf: add a bpf_override_function helper
Date: Fri, 24 Nov 2017 10:46:28 +0100 [thread overview]
Message-ID: <9b416c77-33f8-dacc-82c3-811a265155ed@iogearbox.net> (raw)
In-Reply-To: <1511385814-20863-4-git-send-email-josef@toxicpanda.com>
On 11/22/2017 10:23 PM, Josef Bacik wrote:
> From: Josef Bacik <jbacik@fb.com>
>
> Error injection is sloppy and very ad-hoc. BPF could fill this niche
> perfectly with it's kprobe functionality. We could make sure errors are
> only triggered in specific call chains that we care about with very
> specific situations. Accomplish this with the bpf_override_funciton
> helper. This will modify the probe'd callers return value to the
> specified value and set the PC to an override function that simply
> returns, bypassing the originally probed function. This gives us a nice
> clean way to implement systematic error injection for all of our code
> paths.
>
> Acked-by: Alexei Starovoitov <ast@kernel.org>
> Acked-by: Ingo Molnar <mingo@kernel.org>
> Signed-off-by: Josef Bacik <jbacik@fb.com>
Series looks good to me as well; BPF bits:
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
next prev parent reply other threads:[~2017-11-24 9:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-22 21:23 [PATCH v7 0/4] Add the ability to do BPF directed error injection Josef Bacik
2017-11-22 21:23 ` [PATCH v7 1/5] add infrastructure for tagging functions as error injectable Josef Bacik
2017-11-28 18:58 ` Jonathan Corbet
2017-11-28 20:02 ` Josef Bacik
2017-11-29 16:59 ` Daniel Borkmann
2017-11-30 20:15 ` Josef Bacik
2017-11-22 21:23 ` [PATCH v7 2/5] btrfs: make open_ctree " Josef Bacik
2017-11-22 21:23 ` [PATCH v7 3/5] bpf: add a bpf_override_function helper Josef Bacik
2017-11-24 9:46 ` Daniel Borkmann [this message]
2017-11-22 21:23 ` [PATCH v7 4/5] samples/bpf: add a test for bpf_override_return Josef Bacik
2017-11-22 21:23 ` [PATCH v7 5/5] btrfs: allow us to inject errors at io_ctl_init Josef Bacik
2017-11-23 1:19 ` [PATCH v7 0/4] Add the ability to do BPF directed error injection Alexei Starovoitov
2017-11-28 16:22 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b416c77-33f8-dacc-82c3-811a265155ed@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=ast@kernel.org \
--cc=davem@davemloft.net \
--cc=jbacik@fb.com \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).