From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1034217AbcIWTpd (ORCPT ); Fri, 23 Sep 2016 15:45:33 -0400 Received: from mout.web.de ([212.227.15.4]:60910 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758556AbcIWTpb (ORCPT ); Fri, 23 Sep 2016 15:45:31 -0400 Subject: [PATCH 2/4] i2c-dev: Improve another size determination in i2cdev_ioctl_rdwr() To: linux-i2c@vger.kernel.org, Wolfram Sang References: <566ABCD9.1060404@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring Message-ID: <9b43145c-7666-c4bb-37de-7d1a9ebea72a@users.sourceforge.net> Date: Fri, 23 Sep 2016 21:45:25 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:Mn//jSfAkePWhRkWgrZ0GnobOb52rd55D53IYEVmWHHlzswGqdC U4L1Lr5xh1rlwqkAqz+JTAa2S+RMaMcdwpzBGu4cjOWCmTbGPdL1GGJ1KUIrYBjE/OZvSil Vo42TBInhva4yrtHyxj/eFrCp4Ch2M15Bxm/KZTCMN/yScflFs/dFeEOB4k9gTVQazyV4Q+ TSHjXVY5bvytdFRpk1Qlg== X-UI-Out-Filterresults: notjunk:1;V01:K0:YrcQ9SN0XXo=:mfPfP7luAl2Y8t+20w51uH mE4f9GhCxI1o7sBfp+m4xw705CuBnodkaEwjRflMINVN4SDX3MmbL4esaWtKGMj0Tr9gR4BA7 uxUzNibFFKHItvP0P4OfgbSxGvyzjCRpZqgfF34SwCcO2zY9IChogrtgbJh8U1xojBzp7lXxW PqHbZ5RL+aElLl3ZQQKrJW0jAHuo2yOwgqfxkmgYVXCaMSrGhBMILy1MCyDC2e1Y5EFu261vY vt3Rds+BB/kChYMGT5u+N7gW9zjIageqbvExGSJG4ZDptmKuUKq4JA4JxECXXAj60nsUlDCxN VpFlH0vbTTpaOu/dX6omlNoxRUqPhgZWtIKfIkd21TGvxv3pEJ16xDtTci8ui8RawlTOHeMvl rKuwo1MnPfZt4YKWQa98Am9lVRd6MI7iq6wKi9ynKAeOAD0ug5OzhudlaoxP7I3f6k6om0juT 1YaaMEKhSr+5Bf0KfHBwrN8NrdplXS3lRjrCp0qzlqVU46gvD1cM+L5SuoE8W56G0o+70xYxD ug2jWmyiXktrNyr42+XL+eXyCjMezFkd8J5ZYCiTPWO2C96DTcszP5rDk2nA0AL/mY8ALtKTt GCol0Yq5vyOQ82QICD5jq1NNa7XRb29CEQRNchK9xY+4liXD0tVJcaWuOUysjJAI43LLmf73U tGNLajxRB2wP6dp/xYLRiWmKGIF9Qnf0h3j7biQLKoyTylCTjAd07MHKOCl+RYJAF1H+2WuXJ yi3A9JcuO77Ixq37a+loDgcbZEl+ioj099qQ6tkd/QKrgd4y1ercFtAnxZkeZPj4Yeqyjp4ez 6LaRa6a Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Fri, 23 Sep 2016 20:45:40 +0200 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/i2c/i2c-dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/i2c-dev.c b/drivers/i2c/i2c-dev.c index 6d8226d..a6e35ce 100644 --- a/drivers/i2c/i2c-dev.c +++ b/drivers/i2c/i2c-dev.c @@ -256,7 +256,7 @@ static noinline int i2cdev_ioctl_rdwr(struct i2c_client *client, return -EINVAL; rdwr_pa = memdup_user(rdwr_arg.msgs, - rdwr_arg.nmsgs * sizeof(struct i2c_msg)); + rdwr_arg.nmsgs * sizeof(*rdwr_pa)); if (IS_ERR(rdwr_pa)) return PTR_ERR(rdwr_pa); -- 2.10.0