linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Flavio Suligoi <f.suligoi@asem.it>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "Rafael J . Wysocki" <rjw@rjwysocki.net>,
	Len Brown <lenb@kernel.org>,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
	"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v1] docs: ACPI: enumeration: add PCI hierarchy representation
Date: Thu, 19 Nov 2020 16:17:19 +0000	[thread overview]
Message-ID: <9b5ab860bb77427892edbe443889a006@asem.it> (raw)
In-Reply-To: <20201119110921.GB4077@smile.fi.intel.com>

Hi Andy!


> On Thu, Nov 19, 2020 at 11:12:33AM +0100, Flavio Suligoi wrote:
> 
> Thank you very much for nice piece of documentation!
> My comments below.

Thanks for your suggestions! I'll use them in the next version
of the patch!

> > +particular the DSDT (see also [2])::
> 
> > +	cd /sys/firmware/acpi
> > +	cp -a tables/ ~
> > +	cd ~/tables/
> 
> acpidump followed by acpixtract from ACPI tools is better to advertise.

Ok, I'll use acpixtract

> 
> > +	find . -type f -exec mv {} {}.aml \;
> 
> Unnecessary step. But I think you wanted to have it to distinguish sources
> and
> binaries in the text below.

Right, I think that is important include the SSDT tables for external
symbol resolution. For this reason I renamed the binary tables, to
use the following command:

> > +	iasl -e SSDT?.* -d DSDT.aml

> --
> With Best Regards,
> Andy Shevchenko
> 

Best regards,
Flavio

      reply	other threads:[~2020-11-19 16:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-19 10:12 [PATCH v1] docs: ACPI: enumeration: add PCI hierarchy representation Flavio Suligoi
2020-11-19 11:09 ` Andy Shevchenko
2020-11-19 16:17   ` Flavio Suligoi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9b5ab860bb77427892edbe443889a006@asem.it \
    --to=f.suligoi@asem.it \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=rjw@rjwysocki.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).