From: Joe Perches <joe@perches.com>
To: Jeff Lien <jeff.lien@wdc.com>,
linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
linux-block@vger.kernel.org, linux-scsi@vger.kernel.org
Cc: herbert@gondor.apana.org.au, tim.c.chen@linux.intel.com,
martin.petersen@oracle.com, david.darrington@wdc.com,
jeff.furlong@wdc.com
Subject: Re: [PATCH] Performance Improvement in CRC16 Calculations.
Date: Fri, 10 Aug 2018 12:23:06 -0700 [thread overview]
Message-ID: <9b5b906f42dfab78f382c90f66851717d258a15d.camel@perches.com> (raw)
In-Reply-To: <1533928331-21303-1-git-send-email-jeff.lien@wdc.com>
On Fri, 2018-08-10 at 14:12 -0500, Jeff Lien wrote:
> This patch provides a performance improvement for the CRC16 calculations done in read/write
> workloads using the T10 Type 1/2/3 guard field. For example, today with sequential write
> workloads (one thread/CPU of IO) we consume 100% of the CPU because of the CRC16 computation
> bottleneck. Today's block devices are considerably faster, but the CRC16 calculation prevents
> folks from utilizing the throughput of such devices. To speed up this calculation and expose
> the block device throughput, we slice the old single byte for loop into a 16 byte for loop,
> with a larger CRC table to match. The result has shown 5x performance improvements on various
> big endian and little endian systems running the 4.18.0 kernel version.
Thanks.
This seems a sensible tradeoff for the 4k text size increase.
> diff --git a/crypto/crct10dif_common.c b/crypto/crct10dif_common.c
[]
trivia:
> +static const __u16 t10_dif_crc_table[16][256] = {
> + {
> + 0x0000u, 0x8BB7u, 0x9CD9u, 0x176Eu, 0xB205u, 0x39B2u, 0x2EDCu, 0xA56Bu,
All the 'u's are unnecessary visual noise.
next prev parent reply other threads:[~2018-08-10 19:24 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-10 19:12 [PATCH] Performance Improvement in CRC16 Calculations Jeff Lien
2018-08-10 19:23 ` Joe Perches [this message]
2018-08-10 20:02 ` Nicolas Pitre
2018-08-11 0:11 ` Joe Perches
2018-08-11 0:34 ` Nicolas Pitre
2018-08-11 2:39 ` Douglas Gilbert
2018-08-11 9:04 ` Joe Perches
2018-08-11 15:06 ` Joe Perches
2018-08-13 18:41 ` Jeffrey Lien
2018-08-13 3:36 ` Douglas Gilbert
2018-08-13 4:29 ` Joe Perches
2018-08-10 20:00 ` Nicolas Pitre
2018-08-10 20:16 ` Eric Biggers
2018-08-16 14:02 ` Jeffrey Lien
2018-08-16 14:22 ` Douglas Gilbert
2018-08-16 15:41 ` Christophe LEROY
2018-08-16 17:38 ` Douglas Gilbert
2018-08-17 3:20 ` Martin K. Petersen
2018-08-16 15:47 ` Christophe LEROY
2018-08-10 20:56 ` Douglas Gilbert
2018-08-11 15:36 ` Martin K. Petersen
2018-08-11 16:35 ` Joe Perches
2018-08-22 1:40 ` Martin K. Petersen
2018-08-22 6:20 ` Christoph Hellwig
2018-08-24 15:32 ` Jeffrey Lien
2018-08-24 15:39 ` Ard Biesheuvel
2018-08-24 16:29 ` Martin K. Petersen
2018-08-24 17:38 ` Ard Biesheuvel
2018-08-24 21:46 ` Martin K. Petersen
2018-08-24 21:54 ` Ard Biesheuvel
2018-08-24 22:12 ` Martin K. Petersen
2018-08-25 6:12 ` Herbert Xu
2018-08-26 2:35 ` Martin K. Petersen
2018-08-26 2:40 ` [PATCH 1/4] crypto: Introduce notifier for new crypto algorithms Martin K. Petersen
2018-08-26 2:40 ` [PATCH 2/4] crc-t10dif: Pick better transform if one becomes available Martin K. Petersen
2018-08-27 6:13 ` Herbert Xu
2018-08-26 2:40 ` [PATCH 3/4] crc-t10dif: Allow current transform to be inspected in sysfs Martin K. Petersen
2018-08-26 2:40 ` [PATCH 4/4] block: Integrity profile init function to trigger module loads Martin K. Petersen
2018-08-26 8:22 ` Ard Biesheuvel
2018-08-26 13:30 ` Martin K. Petersen
2018-08-26 13:44 ` Ard Biesheuvel
2018-08-26 13:48 ` Martin K. Petersen
2018-08-27 6:09 ` [PATCH 1/4] crypto: Introduce notifier for new crypto algorithms Herbert Xu
2018-08-30 14:57 ` Martin K. Petersen
2018-08-30 15:00 ` [PATCH v2 1/3] " Martin K. Petersen
2018-08-30 15:00 ` [PATCH v2 2/3] crc-t10dif: Pick better transform if one becomes available Martin K. Petersen
2018-08-30 15:00 ` [PATCH v2 3/3] crc-t10dif: Allow current transform to be inspected in sysfs Martin K. Petersen
2018-08-31 17:17 ` [PATCH v2 1/3] crypto: Introduce notifier for new crypto algorithms Jeffrey Lien
2018-09-04 5:21 ` Herbert Xu
2018-09-04 13:30 ` Torsten Duwe
2018-08-24 16:30 ` [PATCH] Performance Improvement in CRC16 Calculations Martin K. Petersen
2018-08-13 4:44 ` Chaitanya Kulkarni
2018-08-13 11:45 ` David Laight
2018-08-13 13:50 ` David Laight
2018-08-13 22:44 ` Tim Chen
2018-08-15 12:51 ` Jeffrey Lien
2018-08-15 18:31 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b5b906f42dfab78f382c90f66851717d258a15d.camel@perches.com \
--to=joe@perches.com \
--cc=david.darrington@wdc.com \
--cc=herbert@gondor.apana.org.au \
--cc=jeff.furlong@wdc.com \
--cc=jeff.lien@wdc.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=tim.c.chen@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).