From: Tadeusz Struk <tadeusz.struk@intel.com>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: linux-kselftest@vger.kernel.org, shuah@kernel.org,
linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org,
linux-security-module@vger.kernel.org, PeterHuewe@gmx.de,
jgg@ziepe.ca
Subject: Re: [PATCH 2/2] selftests: tpm2: Extend tests to cover partial reads
Date: Mon, 11 Feb 2019 09:55:36 -0800 [thread overview]
Message-ID: <9b879fd2-5c0a-aecc-b6cb-02e5255c22f6@intel.com> (raw)
In-Reply-To: <20190211164803.GG8431@linux.intel.com>
On 2/11/19 8:48 AM, Jarkko Sakkinen wrote:
> You are missing a cover letter from this patch set. Please have it in
> v2. Also use tag "selftests/tpm2" instead of having two tags in the
> short summaries. Now they look a bit weird.
Since when is the cover letter mandatory?
I understand that is helps for a complicated patch set
to explain the problem and solution in the cover letter,
but for this simple test case addition what's the point?
And there is nothing forcing a cover letter in
https://www.kernel.org/doc/html/v4.20/process/submitting-patches.html
Also double tags seams to be quite common for selftest.
See git log tools/testing/selftests/
Thanks,
--
Tadeusz
next prev parent reply other threads:[~2019-02-11 17:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-05 20:28 [PATCH 1/2] selftests: tpm2: Open tpm dev in unbuffered mode Tadeusz Struk
2019-02-05 20:28 ` [PATCH 2/2] selftests: tpm2: Extend tests to cover partial reads Tadeusz Struk
2019-02-11 16:48 ` Jarkko Sakkinen
2019-02-11 17:55 ` Tadeusz Struk [this message]
2019-02-12 23:06 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b879fd2-5c0a-aecc-b6cb-02e5255c22f6@intel.com \
--to=tadeusz.struk@intel.com \
--cc=PeterHuewe@gmx.de \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).