From: Avi Kivity <avi@scylladb.com> To: linux-kernel <linux-kernel@vger.kernel.org>, linux-aio@kvack.org, Goldwyn Rodrigues <rgoldwyn@suse.de> Subject: Spurious EIO on AIO+DIO+RWF_NOWAIT Date: Sun, 9 Dec 2018 13:19:51 +0200 Message-ID: <9bab0f40-5748-f147-efeb-5aac4fd44533@scylladb.com> (raw) I have an application that receives spurious EIO when running with RWF_NOWAIT enabled. Removing RWF_NOWAIT causes those EIOs to disappear. The application uses AIO+DIO, and errors were seen on both xfs and ext4. I suspect the following code: /* * Process one completed BIO. No locks are held. */ static blk_status_t dio_bio_complete(struct dio *dio, struct bio *bio) { struct bio_vec *bvec; unsigned i; blk_status_t err = bio->bi_status; if (err) { if (err == BLK_STS_AGAIN && (bio->bi_opf & REQ_NOWAIT)) dio->io_error = -EAGAIN; else dio->io_error = -EIO; } Could it be that REQ_NOWAIT was dropped from bio->bi_opf? or that bio->bi_status got changed along the way? Reducing the test case may be a lot of work, but I can package a binary using docker if a reproducer is needed. Seen on 4.18.19 and 4.19.something.
next reply index Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-12-09 11:19 Avi Kivity [this message] 2018-12-10 12:48 ` Goldwyn Rodrigues 2018-12-10 12:49 ` Avi Kivity 2018-12-12 12:05 ` Avi Kivity 2018-12-12 14:41 ` Goldwyn Rodrigues
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=9bab0f40-5748-f147-efeb-5aac4fd44533@scylladb.com \ --to=avi@scylladb.com \ --cc=linux-aio@kvack.org \ --cc=linux-kernel@vger.kernel.org \ --cc=rgoldwyn@suse.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
LKML Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git git clone --mirror https://lore.kernel.org/lkml/8 lkml/git/8.git git clone --mirror https://lore.kernel.org/lkml/9 lkml/git/9.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \ linux-kernel@vger.kernel.org public-inbox-index lkml Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel AGPL code for this site: git clone https://public-inbox.org/public-inbox.git