linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Avi Kivity <avi@scylladb.com>
To: linux-kernel <linux-kernel@vger.kernel.org>,
	linux-aio@kvack.org, Goldwyn Rodrigues <rgoldwyn@suse.de>
Subject: Spurious EIO on AIO+DIO+RWF_NOWAIT
Date: Sun, 9 Dec 2018 13:19:51 +0200	[thread overview]
Message-ID: <9bab0f40-5748-f147-efeb-5aac4fd44533@scylladb.com> (raw)

I have an application that receives spurious EIO when running with 
RWF_NOWAIT enabled. Removing RWF_NOWAIT causes those EIOs to disappear. 
The application uses AIO+DIO, and errors were seen on both xfs and ext4.


I suspect the following code:


/*
  * Process one completed BIO.  No locks are held.
  */
static blk_status_t dio_bio_complete(struct dio *dio, struct bio *bio)
{
         struct bio_vec *bvec;
         unsigned i;
         blk_status_t err = bio->bi_status;

         if (err) {
                 if (err == BLK_STS_AGAIN && (bio->bi_opf & REQ_NOWAIT))
                         dio->io_error = -EAGAIN;
                 else
                         dio->io_error = -EIO;
         }

Could it be that REQ_NOWAIT was dropped from bio->bi_opf? or that 
bio->bi_status got changed along the way?


Reducing the test case may be a lot of work, but I can package a binary 
using docker if a reproducer is needed. Seen on 4.18.19 and 4.19.something.


             reply	other threads:[~2018-12-09 11:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-09 11:19 Avi Kivity [this message]
2018-12-10 12:48 ` Goldwyn Rodrigues
2018-12-10 12:49   ` Avi Kivity
2018-12-12 12:05   ` Avi Kivity
2018-12-12 14:41     ` Goldwyn Rodrigues

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9bab0f40-5748-f147-efeb-5aac4fd44533@scylladb.com \
    --to=avi@scylladb.com \
    --cc=linux-aio@kvack.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rgoldwyn@suse.de \
    --subject='Re: Spurious EIO on AIO+DIO+RWF_NOWAIT' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).