From: Peter Rosin <peda@axentia.se>
To: Andy Shevchenko <andy.shevchenko@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Ludovic Desroches <ludovic.desroches@microchip.com>,
Linus Walleij <linus.walleij@linaro.org>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH] pinctrl: at91: allow use of of gpio-line-names property
Date: Thu, 9 Dec 2021 12:23:43 +0100 [thread overview]
Message-ID: <9bf029b2-f112-b0db-a314-51204244fc70@axentia.se> (raw)
In-Reply-To: <CAHp75Vfop8MpzkFRzQKt78UZc6DiEZTm2SYqJDtwm1KcsjC=+w@mail.gmail.com>
Hi!
On 2021-12-08 17:28, Andy Shevchenko wrote:
> On Wed, Dec 8, 2021 at 4:51 PM Alexander Dahl <ada@thorsis.com> wrote:
>> Am Tue, Dec 07, 2021 at 12:32:03AM +0100 schrieb Peter Rosin:
>>> If no line name is given (by not having a gpio-line-names property,
>>> or by having empty "" strings for some lines), fall back to the
>>> existing pioC12-style line name scheme.
>>>
>>> It is useful to be able to explicitly name lines from the schematics
>>> or its function, rather than having the MCU names forced upon every
>>> user.
>>
>> +1 from me.
>>
>> I asked about this some months ago, but I saw no clear
>> direction in the discussion. So for reference:
>>
>> https://lore.kernel.org/linux-gpio/946021874.11132.1615900079722@seven.thorsis.com/
>
> Thanks for the reminder. AFAICS from that discussion we kinda agreed
> on the names being excluded from the ABI path. Hence there is good and
> bad news.
>
> Bad one: NAK to this patch.
> Good one: Please, fix this in the gpiolib respective functions to make
> it once for all.
>
> Disclaimer, I'm not a maintainer of this subsystem, I might be
> perfectly wrong in my understanding of the state of affairs, let's
> hear what Linus and Bart can tell us about the subject. Above are just
> my wishes as a contributor to and consumer of this subsystem on how
> things should be done.
Understood, I'll send a new patch for gpiolib.c instead.
Cheers,
Peter
prev parent reply other threads:[~2021-12-09 11:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-06 23:32 [PATCH] pinctrl: at91: allow use of of gpio-line-names property Peter Rosin
2021-12-08 12:33 ` Alexander Dahl
2021-12-08 16:09 ` Peter Rosin
2021-12-08 16:28 ` Andy Shevchenko
2021-12-09 11:23 ` Peter Rosin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9bf029b2-f112-b0db-a314-51204244fc70@axentia.se \
--to=peda@axentia.se \
--cc=alexandre.belloni@bootlin.com \
--cc=andy.shevchenko@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=nicolas.ferre@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).