From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6371C4332F for ; Tue, 22 Mar 2022 08:42:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231531AbiCVIoA (ORCPT ); Tue, 22 Mar 2022 04:44:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58660 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230414AbiCVIn6 (ORCPT ); Tue, 22 Mar 2022 04:43:58 -0400 Received: from alexa-out-sd-02.qualcomm.com (alexa-out-sd-02.qualcomm.com [199.106.114.39]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9B9FD13CF6; Tue, 22 Mar 2022 01:42:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1647938551; x=1679474551; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=S4jlkx7h0dIsw5N/ts81viS5QONVadlkeQXydpcCgk8=; b=M+YwWCFt68LOgkE5B8EkvL4g+3E/q2gc+kAForGCwXJhsQoO4IFs9WRu 9BzZSmd5NKjVwsTDoGLnsFc2dFn63r+22PSQ+MY8xnNyQLEWebNcvVTXv ObsTzVJtQ+dTkOxGw8Xd6bG/6rwRZfErpQGYC3QcWUmLfk24mVOpxvqWV w=; Received: from unknown (HELO ironmsg-SD-alpha.qualcomm.com) ([10.53.140.30]) by alexa-out-sd-02.qualcomm.com with ESMTP; 22 Mar 2022 01:42:31 -0700 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg-SD-alpha.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Mar 2022 01:42:31 -0700 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Tue, 22 Mar 2022 01:42:30 -0700 Received: from [10.216.35.109] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Tue, 22 Mar 2022 01:42:26 -0700 Subject: Re: [PATCH v11 1/5] usb: dwc3: core: Add HS phy mode variable and phy poweroff flag To: Pavan Kondeti CC: Bjorn Andersson , Greg Kroah-Hartman , Felipe Balbi , Stephen Boyd , Doug Anderson , "Matthias Kaehlcke" , Mathias Nyman , , , , , References: <1647932876-23249-1-git-send-email-quic_c_sanm@quicinc.com> <1647932876-23249-2-git-send-email-quic_c_sanm@quicinc.com> <20220322080937.GI23316@hu-pkondeti-hyd.qualcomm.com> From: "Sandeep Maheswaram (Temp)" Message-ID: <9c0d15d5-c5d1-7233-60e3-de36fa9eb287@quicinc.com> Date: Tue, 22 Mar 2022 14:12:21 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.2.1 MIME-Version: 1.0 In-Reply-To: <20220322080937.GI23316@hu-pkondeti-hyd.qualcomm.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/22/2022 1:39 PM, Pavan Kondeti wrote: > Hi Sandeep, > > On Tue, Mar 22, 2022 at 12:37:52PM +0530, Sandeep Maheswaram wrote: >> Add variables in dwc3 structure to check HS phy mode which is >> used to configure interrupts and phy poweroff flag to check >> the phy status during system resume. >> >> Signed-off-by: Sandeep Maheswaram >> --- >> drivers/usb/dwc3/core.h | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h >> index 5c9d467..f11a60c 100644 >> --- a/drivers/usb/dwc3/core.h >> +++ b/drivers/usb/dwc3/core.h >> @@ -1154,6 +1154,9 @@ struct dwc3 { >> >> bool phys_ready; >> >> + unsigned int hs_phy_mode; >> + bool phy_power_off; >> + >> struct ulpi *ulpi; >> bool ulpi_ready; >> > Why adding members in a separate patch? This needs to be squashed with > 2/5 patch in the series where these members are used in taking host > mode PM decisions. Please fix this. > > Thanks, > Pavan Sure . Will do in next version. Regards Sandeep